hg: jdk8/tl/jdk: 17 new changesets

2012-04-10 Thread lana . steuck
Changeset: 93ca9cbc8940 Author:katleman Date: 2012-04-05 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93ca9cbc8940 Added tag jdk8-b33 for changeset 78cea258caab ! .hgtags Changeset: 100b6c2f75ba Author:rupashka Date: 2012-03-22 17:10 +0200 URL: http:/

hg: jdk8/tl/hotspot: 18 new changesets

2012-04-10 Thread lana . steuck
Changeset: bc8881f974b8 Author:jcoomes Date: 2012-03-23 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bc8881f974b8 7156659: new hotspot build - hs24-b06 Reviewed-by: johnc ! make/hotspot_version Changeset: 1139f6b1cbd4 Author:jcoomes Date: 2012-03-20 19:

hg: jdk8/tl/jaxws: Added tag jdk8-b33 for changeset ea80b2388dce

2012-04-10 Thread lana . steuck
Changeset: b3cad5619239 Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b3cad5619239 Added tag jdk8-b33 for changeset ea80b2388dce ! .hgtags

hg: jdk8/tl/langtools: 3 new changesets

2012-04-10 Thread lana . steuck
Changeset: e4241f09e2b6 Author:katleman Date: 2012-04-05 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e4241f09e2b6 Added tag jdk8-b33 for changeset 46831c72b7f6 ! .hgtags Changeset: 517f0789bd4e Author:lana Date: 2012-04-09 21:58 -0700 URL: http

hg: jdk8/tl: 2 new changesets

2012-04-10 Thread lana . steuck
Changeset: 06ef0b4daa4c Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/06ef0b4daa4c Added tag jdk8-b33 for changeset 42f275168fa5 ! .hgtags Changeset: 3b70add6ae45 Author:lana Date: 2012-04-09 21:55 -0700 URL: http://hg.open

hg: jdk8/tl/jaxp: Added tag jdk8-b33 for changeset 9bcab2b8b8ea

2012-04-10 Thread lana . steuck
Changeset: 19d53d500474 Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/19d53d500474 Added tag jdk8-b33 for changeset 9bcab2b8b8ea ! .hgtags

hg: jdk8/tl/corba: Added tag jdk8-b33 for changeset 1e2ac1ea3f6c

2012-04-10 Thread lana . steuck
Changeset: 0feb9b8a9538 Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0feb9b8a9538 Added tag jdk8-b33 for changeset 1e2ac1ea3f6c ! .hgtags

Builds of sawindbg.dll missing /SAFESEH option?

2012-04-10 Thread Kelly O'Hair
FYI... All dlls in the jdk build should be using /SAFESEH is there some reason that this dll does not? -kto ... latest jdk8/build forest build on windows Checking for /SAFESEH usage in: C:/jprt/T/P1/160106~1.KOH/s/build/windows-i586/../windows-i586-fastdebug/j2sdk-image/jre/bin/sawindbg.d

Re: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread Dmitry Samersoff
Dan, Thank you. -Dmitry On 2012-04-11 01:53, Daniel D. Daugherty wrote: On 4/10/12 3:47 PM, Dmitry Samersoff wrote: Dan, Looks good for me. Thanks! 1. 239 # If Full Debug Symbols is enabled, then we want the same debug and 240 # optimization flags as used by FASTDEBUG. We also want all

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread Dmitry Samersoff
Staffan, 1. MacosxOperatingSystem.c 49 return 0; Probably it should be -1 here. NIT: 133 if (gettimeofday(&now, NULL)) { if (gettimeofday(&now, NULL) < 0) { - IMHO is more readable. -Dmitry On 2012-04-03 17:39, Staffan Larsen wrote: Please review the following fix: webr

Re: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread serguei.spit...@oracle.com
On 4/10/12 2:47 PM, Dmitry Samersoff wrote: Dan, Looks good for me. 1. 239 # If Full Debug Symbols is enabled, then we want the same debug and 240 # optimization flags as used by FASTDEBUG. We also want all the 241 # debug info in one place (-xs). Sorry! I'm later at the party. What is th

Re: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread Daniel D. Daugherty
On 4/10/12 3:47 PM, Dmitry Samersoff wrote: Dan, Looks good for me. Thanks! 1. 239 # If Full Debug Symbols is enabled, then we want the same debug and 240 # optimization flags as used by FASTDEBUG. We also want all the 241 # debug info in one place (-xs). Sorry! I'm later at the party.

Re: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread Dmitry Samersoff
Dan, Looks good for me. 1. 239 # If Full Debug Symbols is enabled, then we want the same debug and 240 # optimization flags as used by FASTDEBUG. We also want all the 241 # debug info in one place (-xs). Sorry! I'm later at the party. What is the reason of enforcing certain optimization l

Re: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread Daniel D. Daugherty
Thanks Serguei! Dan On 4/10/12 2:51 PM, serguei.spit...@oracle.com wrote: Dan, It is good. Thanks, Serguei On 4/9/12 1:51 PM, Daniel D. Daugherty wrote: Greetings, Coming soon to a JDK repo near you! Full Debug Symbols! OK, to just a subset of libraries and programs... on Linux and Sola

Re: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread serguei.spit...@oracle.com
Dan, It is good. Thanks, Serguei On 4/9/12 1:51 PM, Daniel D. Daugherty wrote: Greetings, Coming soon to a JDK repo near you! Full Debug Symbols! OK, to just a subset of libraries and programs... on Linux and Solaris... If you're a Windows fan, the JDK repo has had Full Debug Symbols support

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread Mandy Chung
Staffan, Roger, There isn't any undocumented semantics other than what the specification for com.sun.management.OperatingSystemMXBean specifies (that is indicated by its method name): http://docs.oracle.com/javase/7/docs/jre/api/management/extension/index.html As Roger suggests, you can d

Re: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread Daniel D. Daugherty
Kelly, As always, thanks for filling in the history! I think I'll stick with changing as a little as possible, but I will add the comments that I mentioned below... Dan On 4/10/12 11:39 AM, Kelly O'Hair wrote: Keep in mind that Release.gmk has been edited by many many people and I suspect t

Re: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread Kelly O'Hair
Keep in mind that Release.gmk has been edited by many many people and I suspect there are dozens and dozens of various bugs in utilities, make itself, the systems being used, shell behaviors, etc. that some of this make logic could be working around. I have tried to get people to document that i

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread Daniel D. Daugherty
Staffan, I reviewed it and I think it looks OK. I tried looking at the code in MacosxOperatingSystem.c relative to the Linux version, but I think it is easily possible to miss something subtle here. You might try a direct ping to Mandy Chung since M&M was her area. You might also try a direct pi

Re: Fwd: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread Daniel D. Daugherty
On 4/10/12 7:54 AM, keith mcguigan wrote: Hi Dan, I think it looks good. Thanks! The new form of the 'find' commands in Release.gmk could use a comment, though. It took me a few minutes to realize that EXE_SUFFIX was empty for linux/solaris -- it looks like there's a redundancy in the l

hg: jdk8/tl/jdk: 7158930: (ann) library support for repeating annotations is not built when compiling the JDK

2012-04-10 Thread jonathan . gibbons
Changeset: eec133f2406a Author:jfranck Date: 2012-04-10 10:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eec133f2406a 7158930: (ann) library support for repeating annotations is not built when compiling the JDK Reviewed-by: ohair, erikj ! make/java/java/reflect/Makefile

hg: hsx/hotspot-rt/hotspot: 7133111: libsaproc debug print should be printed as unsigned long to fit large numbers on 64bit platform

2012-04-10 Thread staffan . larsen
Changeset: 10c12fb36ed2 Author:sla Date: 2012-04-05 14:16 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2 7133111: libsaproc debug print should be printed as unsigned long to fit large numbers on 64bit platform Reviewed-by: dcubed, mgronlun, dsamersoff

Re: RFR: 7148497: javax.management.MBeanAttributeInfo.hashCode throws NullPointerException

2012-04-10 Thread Staffan Larsen
Looks good! (Although I wish there was a better way to write code like this). /Staffan On 10 apr 2012, at 15:50, Frederic Parain wrote: > Greetings, > > This is a request for review for CR > 7148497: javax.management.MBeanAttributeInfo.hashCode throws > NullPointerException > http://bugs.sun.c

Re: Fwd: code review request for initial JDK FDS support (7071907)

2012-04-10 Thread keith mcguigan
Hi Dan, I think it looks good. The new form of the 'find' commands in Release.gmk could use a comment, though. It took me a few minutes to realize that EXE_SUFFIX was empty for linux/solaris -- it looks like there's a redundancy in the logic (both NOT name *.debuginfo AND name *.exe). I s

RFR: 7148497: javax.management.MBeanAttributeInfo.hashCode throws NullPointerException

2012-04-10 Thread Frederic Parain
Greetings, This is a request for review for CR 7148497: javax.management.MBeanAttributeInfo.hashCode throws NullPointerException http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148497 Even if the initial CR only refers to MBeanAttributeInfo.hashCode(), the problem is not limited to the MBe

hg: jdk8/tl/jdk: 7154809: JDI: update JDI/JDB debugee commandline option parsing

2012-04-10 Thread staffan . larsen
Changeset: fb52e8bd3718 Author:mgronlun Date: 2012-04-10 10:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb52e8bd3718 7154809: JDI: update JDI/JDB debugee commandline option parsing Summary: update debugee commandline parsing Reviewed-by: dcubed, dsamersoff, sla ! src/s

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread Staffan Larsen
Any takers for this review? (added core-libs-dev as well) Thanks, /Staffan On 3 apr 2012, at 15:39, Staffan Larsen wrote: > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sla/7147848/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147848 > > This