Re: RR(S) 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-05-07 Thread Deven You
Hi Dmitry, Besides David's suggestion, I don't see the @run main tag for the test, is it optional? Thanks a lot! On 05/06/2012 08:30 PM, Dmitry Samersoff wrote: David, Thank you for your response! On 2012-05-06 16:18, David Holmes wrote: Hi Dmitry, Sorry for late response but I've been

Re: RFR: 7161732: Improve handling of thread_id in OSThread

2012-05-07 Thread Rickard Bäckman
On 05/07/2012 10:55 AM, David Holmes wrote: On 7/05/2012 5:21 PM, Rickard Bäckman wrote: David, I can't find that code in any of the modified files (only as blue text in osThread_bsd.hpp, but that is removed code). Sorry the frames view of the webrev confused me. It is blue but that is

Re: AWT Dev Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-05-07 Thread Artem Ananiev
Hi, Mandy, the client part of the fix looks fine. Let me ask a naive question, though. From your explanation, I see that System.loadLibrary() is now aware of modules. What prevents us to change LoadLibraryAction the same way? FROM code looks much more elegant than the new (the old?) TO one.

Re: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt

2012-05-07 Thread Jonathan Lu
Thanks a lot, Alan. I'll go to serviceability-dev list for further discussion. Best regards! - Jonathan Lu On 05/02/2012 04:36 PM, Alan Bateman wrote: On 02/05/2012 09:27, Jonathan Lu wrote: Hi build-dev, I've got a minor change to fix an invalid path from README.txt of MemoryMonitor

Re: RFR: 7165755 OS Information much longer on linux than other platforms

2012-05-07 Thread David Holmes
On 4/05/2012 6:26 PM, Nils Loodin wrote: Updated this with pulling out some shared code to os_posix.cpp. Some methods were different enough that this wasn't possible though. Do you like this better? Webrev: http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ I don't see any os_posix.cpp