Hi Charles,
Verified, thanks!
Regards
- Jonathan
On 05/09/2012 11:29 AM, Charles Lee wrote:
Hi Jonathan,
The patch is committed @
Changeset: abb63b7357a1
Author:luchsh
Date: 2012-05-09 11:19 +0800
URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abb63b7357a1
7165722: Invalid path in
Hello Staffan,
Thanks for reviewing!
I think Charles has helped to push the patch.
Best regards!
- Jonathan
On 05/08/2012 09:24 PM, Staffan Larsen wrote:
Looks good to me. Do you want me to push it for you?
/Staffan
On 8 maj 2012, at 15:13, Jonathan Lu wrote:
Hi serviceability-dev,
is i
Hi Jonathan,
The patch is committed @
Changeset: abb63b7357a1
Author:luchsh
Date: 2012-05-09 11:19 +0800
URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abb63b7357a1
7165722: Invalid path in MemoryMonitor demo's README.txt
Reviewed-by: alanb, sla
Please verify it and thank you all for
Changeset: abb63b7357a1
Author:luchsh
Date: 2012-05-09 11:19 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abb63b7357a1
7165722: Invalid path in MemoryMonitor demo's README.txt
Reviewed-by: alanb, sla
! src/share/demo/management/MemoryMonitor/README.txt
Changeset: 0f63f3390ac9
Author:xuelei
Date: 2012-05-08 18:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f63f3390ac9
7166570: JSSE certificate validation has started to fail for certificate chains
Reviewed-by: wetmore
! src/share/classes/sun/security/validator/SimpleVali
Changeset: fbf98cbd2e6b
Author:xuelei
Date: 2012-05-08 17:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbf98cbd2e6b
7167092: Need to put the return clause in the synchronized block
Summary: a regression fix for bug 7153184
Reviewed-by: wetmore
! src/share/classes/sun/se
Changeset: 0251d217257f
Author:sla
Date: 2012-05-08 20:28 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0251d217257f
7162726: Wrong filter predicate of visible locals in SA JSJavaFrame
Reviewed-by: sla, dcubed
Contributed-by: Krystal Mok
! agent/src/share/classe
Changeset: 1ece20885be4
Author:sherman
Date: 2012-05-08 11:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ece20885be4
7157656: (zipfs) SeekableByteChannel to entry in zip file always reports its
position as 0
Summary: updated SeekableByteChannel.read() to count the bytes
Looks good!
Yumin
On 5/4/2012 4:01 AM, Nils Loodin wrote:
Built it and connected to a running java process and ran some commands.
I see other issues, but the connecting part actually works now.
This will probably open up more bugs.
/Nils Loodin
On May 4, 2012, at 12:05 , Staffan Larsen wrot
Changeset: af209a223b6b
Author:sherman
Date: 2012-05-08 10:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af209a223b6b
7014640: To add a metachar \R for line ending and character classes for
vertical/horizontal ws \v \V \h \H
Summary: added propsoed constructs
Reviewed-by
Nils Loodin wrote:
Can I get a Reviewer to look at this? Does no reviewer care about SA? :)
We do care about SA :) Changes looks good.
Vladimir
Regards
Nils Loodin
On May 4, 2012, at 13:01 , Nils Loodin wrote:
Built it and connected to a running java process and ran some commands.
I see
Right you are. Playing with core files can bite you. While this code enables
you to look at core files on a different platform, it does not require it.
There is support in SA for moving library files from a different system (via
the SA_ALT_ROOT environment variable).
/Staffan
On 8 maj 2012, at
Good one - I wasn't aware of the ErrorHandlerTest. I agree that duplication of
code is not good and perhaps the whitebox API is overkill for the job at hand.
I see other tests uses sun.misc.Unsafe to cause crashes which may make more
sense than reusing the ErrorHandlerTest since I want Java fram
Here are some late breaking additions that Kevin sent me. These are only
changes to the kjdb core.
Full webrev: http://cr.openjdk.java.net/~sla/kjdb/webrev.02/
Difference from the last webrev:
http://cr.openjdk.java.net/~sla/kjdb/webrev.02-delta/
And I should add credit where credit is due. The
Thanks, Dan ^_^
- Kris
On Tue, May 8, 2012 at 11:59 PM, Daniel D. Daugherty <
daniel.daughe...@oracle.com> wrote:
> **
> Thumbs up!
>
> Thanks for including a sample failure and a sample success.
>
> agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFrame.java
> No comments.
>
> D
Thumbs up!
Thanks for including a sample failure and a sample success.
agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFrame.java
No comments.
Dan
On 4/23/12 9:05 PM, Krystal Mok wrote:
Hi all,
Could I get a review for this patch, please?
Regards,
Kris
On Thu, Apr 19, 201
On May 8, 2012, at 4:11 AM, Staffan Larsen wrote:
> The Serviceability Agent currently has an outage on Mac OS X compared to
> other platforms in that we cannot read core files. We plan to address this
> for 7u6 by incorporating code from a separate tool called "kjdb" developed at
> Oracle. Kj
Staffan,
I looked through test makefile changes and the white box test, the
changes seem alright but I'm not convinced that using a white box test
for this is the best approach.
There are some existing tests for the error handler and hs_err creation
in test_error_handler in debug.cpp (look for
Hey David!
On May 8, 2012, at 10:18 , David Holmes wrote:
> Changes to x86_64 seem okay though it seems a little odd to accept amd64 but
> report the only valid values are x86/x86_64.
I guess you mean that I've changed the exception output like this:
-throw new DebuggerException("Bsd
On May 8, 2012, at 15:00 , Coleen Phillimore wrote:
> Actually, I reviewed this and why do you have an extra set of parenthesis
> around the second clause? I don't think they help anything and look kind of
> odd.
>
> +} else if (cpu.equals("amd64") || (cpu.equals("x86_64"))) {
>
> m
Looks good to me. Do you want me to push it for you?
/Staffan
On 8 maj 2012, at 15:13, Jonathan Lu wrote:
> Hi serviceability-dev,
>
> is it OK to push this change?
>
> Thanks!
>
> On 05/03/2012 10:00 AM, Jonathan Lu wrote:
>> Thanks a lot, Alan.
>>
>> I'll go to serviceability-dev list for
Hi serviceability-dev,
is it OK to push this change?
Thanks!
On 05/03/2012 10:00 AM, Jonathan Lu wrote:
Thanks a lot, Alan.
I'll go to serviceability-dev list for further discussion.
Best regards!
- Jonathan Lu
On 05/02/2012 04:36 PM, Alan Bateman wrote:
On 02/05/2012 09:27, Jonathan Lu w
Hi -
Just a note that I'd like to contribute a cleaner way for the Debugger
and Process classes here to load a core file, which I hadn't yet handed
over. I'll have that ready shortly...
Thanks
Kevin
On 08/05/12 12:11, Staffan Larsen wrote:
The Serviceability Agent currently has an outage o
The Serviceability Agent currently has an outage on Mac OS X compared to other
platforms in that we cannot read core files. We plan to address this for 7u6 by
incorporating code from a separate tool called "kjdb" developed at Oracle. Kjdb
is a cross-platform core-file debugger written completely
Hi all,
I'm a little bit late, but I just have seen:
(1) some indentations in the patch are broken
(2) following code snipped is repeated many times:
+ ClassLoader cl = tclass.getClassLoader();
+ ClassLoader ccl = caller.getClassLoader();
+ if ((ccl != null) && (ccl != cl) &&
+
On 8/05/2012 6:03 PM, Nils Loodin wrote:
Hrm, sorry about that people, The webrev number should have been bumped from 00
to 01. :)
http://cr.openjdk.java.net/~nloodin/7165755/webrev.01/
Why are all the os_XXX.cpp files now explicitly #including their
os_XXX.hpp counterpart? Was this somethin
On 8/05/2012 5:48 PM, Nils Loodin wrote:
Can I get a Reviewer to look at this? Does no reviewer care about SA? :)
Don't have a Mac or know inner details of BSD/OSX ;-)
Changes to x86_64 seem okay though it seems a little odd to accept amd64
but report the only valid values are x86/x86_64.
A
Hrm, sorry about that people, The webrev number should have been bumped from 00
to 01. :)
http://cr.openjdk.java.net/~nloodin/7165755/webrev.01/
Nisse
On May 8, 2012, at 07:37 , David Holmes wrote:
> On 4/05/2012 6:26 PM, Nils Loodin wrote:
>> Updated this with pulling out some shared code to
Can I get a Reviewer to look at this? Does no reviewer care about SA? :)
Regards
Nils Loodin
On May 4, 2012, at 13:01 , Nils Loodin wrote:
> Built it and connected to a running java process and ran some commands.
> I see other issues, but the connecting part actually works now.
>
> This will p
Changeset: 48513d156965
Author:dholmes
Date: 2012-05-08 02:59 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48513d156965
7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is
installed
Summary: Perform class.getField inside a doPrivileged block
Reviewed-b
30 matches
Mail list logo
