On 6/19/12 10:36 PM, David Holmes wrote:
On 20/06/2012 2:32 PM, Daniel D. Daugherty wrote:
That all said, it still seems to me that the logic for GENERATED is
not correct if you have done a cd into the 64 subdirectory.
Exactly the opposite is true. Without the TOPDIR/GENERATED combo,
when you
On 20/06/2012 2:32 PM, Daniel D. Daugherty wrote:
That all said, it still seems to me that the logic for GENERATED is
not correct if you have done a cd into the 64 subdirectory.
Exactly the opposite is true. Without the TOPDIR/GENERATED combo,
when you "cd 64", the "../generated" that the GENER
On 6/19/12 9:37 PM, David Holmes wrote:
On 20/06/2012 1:23 PM, Daniel D. Daugherty wrote:
Thanks for the quick review!
You said it was urgent ;-)
Yes, but sometimes that still doesn't get me timely reviews. :-)
However, you have to be crazy to change HotSpot Makefiles so...
can you really bl
On 20/06/2012 1:23 PM, Daniel D. Daugherty wrote:
Thanks for the quick review!
You said it was urgent ;-)
On 6/19/12 8:06 PM, David Holmes wrote:
It would be nice if the cd into the 64 directory could be handled
internally to the link logic rather than occurring at the top-level (I
say this
TOPDIR is also used in other HotSpot Makefiles so my usage here
is consistent.
Dan
On 6/19/12 8:51 PM, Kelly O'Hair wrote:
And TOPDIR might be a variable used in the top level JDK Makefiles, referring
to the top of the forest. :^(
So the TOPDIR name needs to be more unique I think.
-kto
On
Thanks for the quick review!
On 6/19/12 8:06 PM, David Holmes wrote:
Hi Dan,
It would be nice if the cd into the 64 directory could be handled
internally to the link logic rather than occurring at the top-level (I
say this as someone who will need to hand merge this into another
workspace ;
Thanks for the quick review!
On 6/19/12 7:58 PM, Kelly O'Hair wrote:
130 ( set -e ; \
131 cd 64 ; \
132 $(QUIETLY) $(ADD_GNU_DEBUGLINK) \
133 $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \
134 )
Would be better as:
130 ( cd 64&& $(AD
And TOPDIR might be a variable used in the top level JDK Makefiles, referring
to the top of the forest. :^(
So the TOPDIR name needs to be more unique I think.
-kto
On Jun 19, 2012, at 7:06 PM, David Holmes wrote:
> Hi Dan,
>
> It would be nice if the cd into the 64 directory could be handled
Hi Dan,
It would be nice if the cd into the 64 directory could be handled
internally to the link logic rather than occurring at the top-level (I
say this as someone who will need to hand merge this into another
workspace ;-) ).
Also in make/solaris/makefiles/add_gnu_debuglink.make I don't un
130 ( set -e ; \
131 cd 64 ; \
132 $(QUIETLY) $(ADD_GNU_DEBUGLINK) \
133 $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \
134 )
Would be better as:
130 ( cd 64 && $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO)
$(LIBJVM_DB) )
And making GENERATED
Greetings,
This is an URGENT code review request for a Solaris specific Full Debug
Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol
files and related '_g' symlinks are created in the wrong sub-directory
for a couple of the dtrace libraries. The incorrect paths have a double
Changeset: cdcbd22cfb9d
Author:xuelei
Date: 2012-06-19 17:28 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdcbd22cfb9d
7166487: checkSequenceNumber method never called within readRecord of
SSLEngineImpl
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/SSLEngineImp
Posted: http://openjdk.java.net/jeps/158
- Mark
Changeset: 34e254ffd0e7
Author:mcimadamore
Date: 2012-06-19 13:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/34e254ffd0e7
7177701: error: Filling jar message during
javax/imageio/metadata/IIOMetadataFormatImpl compilation
Summary: Recent JDK hash changes affected o
Changeset: efc2791d7c5d
Author:chegar
Date: 2012-06-19 10:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/efc2791d7c5d
6901992: InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()
Reviewed-by: chegar
Contributed-by: dbel...@gmail.com
! src/share/classes/sun/mi
Changeset: 4419c8f0b2f2
Author:okutsu
Date: 2012-06-19 16:21 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4419c8f0b2f2
6380549: (rb) ResourceBundle.Control global binding support
Reviewed-by: naoto
! make/java/java/FILES_java.gmk
! src/share/classes/java/util/ResourceBundl
16 matches
Mail list logo
