I was thinking about the same.
But a CCC request is needed for such a change in public API.
It can be done separately if any other API changes are necessary.
Thanks,
Serguei
On 8/23/12 6:27 PM, David Holmes wrote:
Hi Mandy,
While I understand what you are doing and that it "works" it is far
Changeset: 9cf72631baf5
Author:katleman
Date: 2012-08-23 12:27 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/9cf72631baf5
Added tag jdk8-b53 for changeset d3d0b9cd76e0
! .hgtags
Changeset: 156ab3c38556
Author:katleman
Date: 2012-08-23 12:27 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/156ab3c38556
Added tag jdk8-b53 for changeset 2c6933c5106b
! .hgtags
Changeset: 91970935926a
Author:katleman
Date: 2012-08-23 12:27 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/91970935926a
Added tag jdk8-b53 for changeset 8a35fd644d3c
! .hgtags
Changeset: 7dd81ccb7c11
Author:katleman
Date: 2012-08-23 12:27 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/7dd81ccb7c11
Added tag jdk8-b53 for changeset 2c566f25c39f
! .hgtags
Changeset: 16c82fc74695
Author:katleman
Date: 2012-08-23 12:27 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/16c82fc74695
Added tag jdk8-b53 for changeset 63aeb7a2472f
! .hgtags
Changeset: c1a277c6022a
Author:katleman
Date: 2012-08-23 12:27 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c1a277c6022a
Added tag jdk8-b53 for changeset febd7ff52800
! .hgtags
Hi Mandy,
While I understand what you are doing and that it "works" it is far from
obvious upon code inspection that where you replace null with
Foo.class.getClassLoader(), that the result would always be null.
Another way to simplify this would be to add a new overload of
Class.forName():
On 8/23/2012 2:26 PM, Dmitry Samersoff wrote:
Mandy,
1. You replace null with getClassLoader() calls in couple of places.
getClassLoader requires special permissions -
RuntimePermission("getClassLoader")
so probably you need to use doPrivileget() there.
No, the caller's class load
Looks good.
Thanks,
Serguei
On 8/23/12 12:33 PM, Mandy Chung wrote:
On 8/23/2012 11:58 AM, Alan Bateman wrote:
On 23/08/2012 18:43, Mandy Chung wrote:
This change is to bring the jdk modularization changes from jigsaw
repo [1]
to jdk8. This allows the jdk modularization changes to be expos
Mandy,
1. You replace null with getClassLoader() calls in couple of places.
getClassLoader requires special permissions -
RuntimePermission("getClassLoader")
so probably you need to use doPrivileget() there.
Did you test your changes with SecurityManager/No permissions
for the tes
On 23/08/2012 20:33, Mandy Chung wrote:
:
Done. This is a good cleanup I considered to do too but missed in the
previous webrev.
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7193339/webrev.01/
Thanks for the review.
Mandy
That looks much better, so looks good to me.
-Alan
On 8/23/2012 12:48 PM, serguei.spit...@oracle.com wrote:
Mandy,
It looks good.
Thanks.
Just a question below.
|| *src/share/classes/java/lang/management/ManagementFactory.java*
596 String intfName = mxbeanInterface.getName();
599 " is not an instance of " + m
Mandy,
It looks good.
Just a question below.
|| *src/share/classes/java/lang/management/ManagementFactory.java*
596 String intfName = mxbeanInterface.getName();
599 " is not an instance of " + mxbeanInterface);
Did you want this?:
596 String intfName
On 8/23/2012 11:58 AM, Alan Bateman wrote:
On 23/08/2012 18:43, Mandy Chung wrote:
This change is to bring the jdk modularization changes from jigsaw
repo [1]
to jdk8. This allows the jdk modularization changes to be exposed for
testing as early as possible and minimize the amount of changes c
On 23/08/2012 18:43, Mandy Chung wrote:
This change is to bring the jdk modularization changes from jigsaw
repo [1]
to jdk8. This allows the jdk modularization changes to be exposed for
testing as early as possible and minimize the amount of changes carried
in the jigsaw repo that helps sync up
This change is to bring the jdk modularization changes from jigsaw repo [1]
to jdk8. This allows the jdk modularization changes to be exposed for
testing as early as possible and minimize the amount of changes carried
in the jigsaw repo that helps sync up jigsaw with jdk8/jdk9.
Webrev at:
http
Changeset: de5a85353f4d
Author:alanb
Date: 2012-08-23 13:07 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de5a85353f4d
7191587: (se) SelectionKey.interestOps does not defer changing the interest set
to the next select [macosx]
Reviewed-by: alanb
Contributed-by: Jason T Gree
Changeset: e7b53fe85540
Author:dingxmin
Date: 2012-08-23 16:28 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7b53fe85540
7193463: Improve registering signal handlers in java.lang.Terminator.setup()
Reviewed-by: dholmes, alanb
! src/solaris/classes/java/lang/Terminator.java
19 matches
Mail list logo
