hg: jdk8/tl/jdk: 7193339: Prepare system classes be defined by a non-null module loader

2012-08-24 Thread mandy . chung
Changeset: d52081a08d11 Author:mchung Date: 2012-08-24 22:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d52081a08d11 7193339: Prepare system classes be defined by a non-null module loader Reviewed-by: alanb, dholmes, dsamersoff, sspitsyn, psandoz ! src/share/classes/com/

[PATCH FOR REVIEW] 7194035: update tests for upcoming changes for jtreg

2012-08-24 Thread Jonathan Gibbons
Currently, jtreg incorrectly confuses the concept of the /directory/ in which the test's class will be written with the /classpath/ used to locate all of the test's classes, including any library classes. It provides env variable TESTCLASSES and system property test.classes, and tests use these

Re: Review Request: 7193339 Prepare system classes be defined by a non-null module loader

2012-08-24 Thread Mandy Chung
On 8/24/2012 3:44 PM, David Holmes wrote: My other query with these changes is whether we are certain that using the specified loader rather than the boot loader will always be correct. Yes I'm to my best knowledge but I'm looking to the reviewers to tell me otherwise :) The class being loa

Re: Review Request: 7193339 Prepare system classes be defined by a non-null module loader

2012-08-24 Thread David Holmes
On 25/08/2012 1:53 AM, Mandy Chung wrote: On 8/23/2012 6:27 PM, David Holmes wrote: Another way to simplify this would be to add a new overload of Class.forName(): public static Class forName(String name, boolean initialize) That way the loader argument could be dropped completely from a numb

hg: jdk8/tl/jdk: 7168172: (fs) Files.isReadable slow on Windows

2012-08-24 Thread kurchi . subhra . hazra
Changeset: bd91a601265c Author:khazra Date: 2012-08-24 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c 7168172: (fs) Files.isReadable slow on Windows Summary: Remove DACL checking for read access, also reviewed by ulf.zi...@cosoco.de, zhong.j...@gmail.com R

hg: jdk8/tl/jdk: 7193933: More ProblemList.txt updates (8/2012)

2012-08-24 Thread alan . bateman
Changeset: a7cdfd16e36e Author:alanb Date: 2012-08-24 19:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7cdfd16e36e 7193933: More ProblemList.txt updates (8/2012) Reviewed-by: darcy, chegar ! test/ProblemList.txt

hg: jdk8/tl/jdk: 7193601: Build breakage with the fix to 6336885 (build-infra build)

2012-08-24 Thread naoto . sato
Changeset: faf4528aea4e Author:naoto Date: 2012-08-24 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/faf4528aea4e 7193601: Build breakage with the fix to 6336885 (build-infra build) Reviewed-by: mduigou ! makefiles/CompileJavaClasses.gmk

Re: Review request for: 7191786 retransformClasses() does not pass in LocalVariableTypeTable of a method

2012-08-24 Thread serguei.spit...@oracle.com
Thanks, Rickard! Serguei On 8/24/12 4:22 AM, Rickard Bäckman wrote: Serguei, looks good! /R On Aug 22, 2012, at 8:34 PM, serguei.spit...@oracle.com wrote: Dmitry, Thank you for the review! Please, find new webrev version here: http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7191786-JVM

Re: Review Request: 7193339 Prepare system classes be defined by a non-null module loader

2012-08-24 Thread Mandy Chung
On 8/23/2012 6:27 PM, David Holmes wrote: Another way to simplify this would be to add a new overload of Class.forName(): public static Class forName(String name, boolean initialize) That way the loader argument could be dropped completely from a number of the use-cases. Paul and Remi als

Re: Review request for: 7191786 retransformClasses() does not pass in LocalVariableTypeTable of a method

2012-08-24 Thread Rickard Bäckman
Serguei, looks good! /R On Aug 22, 2012, at 8:34 PM, serguei.spit...@oracle.com wrote: > Dmitry, > > Thank you for the review! > > Please, find new webrev version here: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7191786-JVMTI-LVTT.1/ > > I also changed the line: > 196 if (elem[idx]