Serguei,
looks good!
/R
On Aug 22, 2012, at 8:34 PM, serguei.spit...@oracle.com wrote:
Dmitry,
Thank you for the review!
Please, find new webrev version here:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7191786-JVMTI-LVTT.1/
I also changed the line:
196 if
On 8/23/2012 6:27 PM, David Holmes wrote:
Another way to simplify this would be to add a new overload of
Class.forName():
public static Class? forName(String name, boolean initialize)
That way the loader argument could be dropped completely from a number
of the use-cases.
Paul and Remi
Thanks, Rickard!
Serguei
On 8/24/12 4:22 AM, Rickard Bäckman wrote:
Serguei,
looks good!
/R
On Aug 22, 2012, at 8:34 PM, serguei.spit...@oracle.com wrote:
Dmitry,
Thank you for the review!
Please, find new webrev version here:
Changeset: faf4528aea4e
Author:naoto
Date: 2012-08-24 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/faf4528aea4e
7193601: Build breakage with the fix to 6336885 (build-infra build)
Reviewed-by: mduigou
! makefiles/CompileJavaClasses.gmk
Changeset: a7cdfd16e36e
Author:alanb
Date: 2012-08-24 19:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7cdfd16e36e
7193933: More ProblemList.txt updates (8/2012)
Reviewed-by: darcy, chegar
! test/ProblemList.txt
Changeset: bd91a601265c
Author:khazra
Date: 2012-08-24 11:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c
7168172: (fs) Files.isReadable slow on Windows
Summary: Remove DACL checking for read access, also reviewed by
ulf.zi...@cosoco.de, zhong.j...@gmail.com
On 25/08/2012 1:53 AM, Mandy Chung wrote:
On 8/23/2012 6:27 PM, David Holmes wrote:
Another way to simplify this would be to add a new overload of
Class.forName():
public static Class? forName(String name, boolean initialize)
That way the loader argument could be dropped completely from a
On 8/24/2012 3:44 PM, David Holmes wrote:
My other query with these changes is whether we are certain that using
the specified loader rather than the boot loader will always be correct.
Yes I'm to my best knowledge but I'm looking to the reviewers to tell me
otherwise :)
The class being
