Review request: 7193302 Remove ConstructorProperties annotation from java.lang.management.LockInfo

2012-09-11 Thread Mandy Chung
The @java.beans.ConstructorProperties annotation on j.l.m.LockInfo causes an undesirable dependency on java.beans at compile time and runtime. As java.beans is tightly coupled with the client API (awt, swing, java2d, etc), anyone using java.lang.management (management module) would cause all the

hg: jdk8/tl/jdk: 7193406: Clean-up JDK Build Warnings in java.util, java.io

2012-09-11 Thread stuart . marks
Changeset: 1f7c783e4f13 Author:dxu Date: 2012-08-31 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f7c783e4f13 7193406: Clean-up JDK Build Warnings in java.util, java.io Summary: Clean-up JDK Build Warnings in java.util, java.io Packages Reviewed-by: smarks, darcy, kha

Re: RR, M, 02 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh

2012-09-11 Thread serguei.spit...@oracle.com
Wow, many changes there. Reviewing ... Thanks, Serguei On 9/11/12 9:14 AM, Dmitry Samersoff wrote: Still looking for reviewers ... On 2012-08-29 14:28, Dmitry Samersoff wrote: Hi Everybody, Second version - busy code rewritten. http://cr.openjdk.java.net/~dsamersoff/7186723/webrev.02/ -Dm

Re: RR, M, 02 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh

2012-09-11 Thread Dmitry Samersoff
Still looking for reviewers ... On 2012-08-29 14:28, Dmitry Samersoff wrote: > Hi Everybody, > > Second version - busy code rewritten. > > http://cr.openjdk.java.net/~dsamersoff/7186723/webrev.02/ > > -Dmitry > > On 2012-08-25 19:18, Dmitry Samersoff wrote: >> Hi Everybody, >> >> Test was cha

hg: jdk8/tl/jdk: 7194597: Typeo in com.sun.management.VMOption.toString()

2012-09-11 Thread dmitry . samersoff
Changeset: 2598dad9 Author:dsamersoff Date: 2012-09-11 19:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2598dad9 7194597: Typeo in com.sun.management.VMOption.toString() Summary: VMOption.toString() returns "...(read-only)" if writable "...(read-write)" otherwise

Re: Review request: 7197350: NPG: jvmtiHeapReferenceCallback receives incorrect reference_kind for system class roots

2012-09-11 Thread Rickard Bäckman
Looks good. /R On Sep 10, 2012, at 6:39 PM, Stefan Karlsson wrote: > http://cr.openjdk.java.net/~stefank/7197350/webrev/ > > 7197350: NPG: jvmtiHeapReferenceCallback receives incorrect reference_kind > for system class roots > Summary: Fix the iteration over the system classes and report the c

Re: Review request: 7197350: NPG: jvmtiHeapReferenceCallback receives incorrect reference_kind for system class roots

2012-09-11 Thread Coleen Phillmore
This looks good. Coleen On 9/10/2012 12:39 PM, Stefan Karlsson wrote: http://cr.openjdk.java.net/~stefank/7197350/webrev/ 7197350 : NPG: jvmtiHeapReferenceCallback receives incorrect reference_kind for system class roots Summary: Fi