Re: Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-13 Thread Mandy Chung
On 9/13/2012 2:59 PM, Eamonn McManus wrote: If at all possible, it would be better to split out ConstructorProperties into a separable dependency so that JMX could depend on just that. The idea that a profile with JMX but not JavaBeans is almost but not quite exactly like a profile with both se

Re: Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-13 Thread Eamonn McManus
>> If at all possible, it would be better to split out >> ConstructorProperties into a separable dependency so that JMX could >> depend on just that. The idea that a profile with JMX but not >> JavaBeans is almost but not quite exactly like a profile with both >> seems rather user-hostile. > The cu

Re: Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-13 Thread Mandy Chung
Hi Eamonn, Thanks for the review and the information. On 9/13/2012 9:48 AM, Eamonn McManus wrote: If at all possible, it would be better to split out ConstructorProperties into a separable dependency so that JMX could depend on just that. The idea that a profile with JMX but not JavaBeans is al

hg: jdk8/tl/langtools: 7177970: fix issues in langtools doc comments

2012-09-13 Thread jonathan . gibbons
Changeset: 30c36e23f154 Author:jjg Date: 2012-09-13 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/30c36e23f154 7177970: fix issues in langtools doc comments Reviewed-by: mcimadamore ! src/share/classes/com/sun/javadoc/Doc.java ! src/share/classes/com/sun/javadoc

Re: review request - 7198162: exclude test MemoryMXBean/LowMemoryTest2.sh

2012-09-13 Thread John Coomes
serguei.spit...@oracle.com (serguei.spit...@oracle.com) wrote: > Looks good. Many thanks Dmitry, Alan, and Sergeui. -John > On 9/13/12 9:15 AM, John Coomes wrote: > > Hi all, > > > > I'd appreciate reviews of a small fix to add LowMemoryTest2.sh to > > ProblemList.txt. It times out with the pen

Re: Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-13 Thread Eamonn McManus
If at all possible, it would be better to split out ConstructorProperties into a separable dependency so that JMX could depend on just that. The idea that a profile with JMX but not JavaBeans is almost but not quite exactly like a profile with both seems rather user-hostile. If it is not possible

Re: review request - 7198162: exclude test MemoryMXBean/LowMemoryTest2.sh

2012-09-13 Thread serguei.spit...@oracle.com
Looks good. Thanks, Serguei On 9/13/12 9:15 AM, John Coomes wrote: Hi all, I'd appreciate reviews of a small fix to add LowMemoryTest2.sh to ProblemList.txt. It times out with the pending hotspot changes that remove the permanent generation. http://cr.openjdk.java.net/~jcoomes/7198162-exclud

Re: review request - 7198162: exclude test MemoryMXBean/LowMemoryTest2.sh

2012-09-13 Thread Alan Bateman
On 13/09/2012 17:15, John Coomes wrote: Hi all, I'd appreciate reviews of a small fix to add LowMemoryTest2.sh to ProblemList.txt. It times out with the pending hotspot changes that remove the permanent generation. http://cr.openjdk.java.net/~jcoomes/7198162-exclude-lmt2/ -John Looks fine to

Re: review request - 7198162: exclude test MemoryMXBean/LowMemoryTest2.sh

2012-09-13 Thread Dmitry Samersoff
Looks good for me. On 2012-09-13 20:15, John Coomes wrote: > Hi all, > > I'd appreciate reviews of a small fix to add LowMemoryTest2.sh to > ProblemList.txt. It times out with the pending hotspot changes that > remove the permanent generation. > > http://cr.openjdk.java.net/~jcoomes/7198162-exc

review request - 7198162: exclude test MemoryMXBean/LowMemoryTest2.sh

2012-09-13 Thread John Coomes
Hi all, I'd appreciate reviews of a small fix to add LowMemoryTest2.sh to ProblemList.txt. It times out with the pending hotspot changes that remove the permanent generation. http://cr.openjdk.java.net/~jcoomes/7198162-exclude-lmt2/ -John

Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-13 Thread Mandy Chung
This is to eliminate the static dependency from JMX to java.beans.ConstructorProperties. Similar work has been done in the past [1] and this fix will allow JMX to be used without the presence of java.beans. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7198070/webrev.00/ All test

hg: jdk8/tl/jdk: 7197637: (ch) sun.nio.ch.Default* cause providers for other platforms to be included in rt.jar

2012-09-13 Thread alan . bateman
Changeset: e8a3807de977 Author:alanb Date: 2012-09-13 15:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8a3807de977 7197637: (ch) sun.nio.ch.Default* cause providers for other platforms to be included in rt.jar Reviewed-by: mchung ! src/solaris/classes/sun/nio/ch/Defaul

hg: jdk8/tl/jdk: 7197203: sun/misc/URLClassPath/ClassnameCharTest.sh failed, compile error

2012-09-13 Thread chris . hegarty
Changeset: e095be3820ee Author:chegar Date: 2012-09-13 11:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e095be3820ee 7197203: sun/misc/URLClassPath/ClassnameCharTest.sh failed, compile error Reviewed-by: alanb ! test/sun/misc/URLClassPath/ClassnameCharTest.java - test/su

Re: RR, M, 02 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh

2012-09-13 Thread serguei.spit...@oracle.com
Ok, thanks! Serguei On 9/13/12 1:44 AM, Dmitry Samersoff wrote: Serguei, Thank you for review! My test "framework" contains set of tests each of them starts the server application with different parameters. So the fact the server app doesn't start in one test is not necessary imply that it

Re: Review request: 7193302 Remove ConstructorProperties annotation from java.lang.management.LockInfo

2012-09-13 Thread Alan Bateman
On 12/09/2012 21:43, Mandy Chung wrote: : Thanks for catching that. I should have caught them myself :) Updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7193302/webrev.01/ FYI. I have filed a CR for the JMX com.sun.jmx.DefaultMXBeanMappingFactory change: 7198070: Elimin

Re: RR, M, 02 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh

2012-09-13 Thread Dmitry Samersoff
Serguei, Thank you for review! My test "framework" contains set of tests each of them starts the server application with different parameters. So the fact the server app doesn't start in one test is not necessary imply that it wouldn't start in other tests. Typical problem - busy port. But in