Re: RFR: 7194254 jstack reports wrong thread priorities

2012-09-16 Thread David Holmes
I've updated the fix to include the missing/extra newlines in the thread listing that was reported. Seems to be okay now for: - G1 - CMS - ParNew - Serial (trivially so as there is no output :) ) New Webrev at: http://cr.openjdk.java.net/~dholmes/7194254/webrev/ (Sorry I messed up the versioni

Re: Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-16 Thread Eamonn McManus
OK, well if you've managed to align modules on package boundaries everywhere else then congratulations, because that can't have been easy! Certainly a relatively minor feature like ConstructorProperties shouldn't be the only obstacle to completing that split. If we had known that this question woul

Re: Need reviewer for warning error fix on hprof_init.c

2012-09-16 Thread David Holmes
On 16/09/2012 2:33 AM, Dmitry Samersoff wrote: Kelly, Sorry for being later in a party. Function receiving port number as an argument should use *in_port_t* - rather than unsigned short - it expands to uint16_t or to uint32_t depending to OS. But that change in itself may not fix the problem

Re: Need reviewer for warning error fix on hprof_init.c

2012-09-16 Thread David Holmes
On 16/09/2012 1:58 AM, Kelly O'Hair wrote: On Sep 15, 2012, at 4:10 AM, David Holmes wrote: On 15/09/2012 11:52 AM, Kelly O'Hair wrote: 7198327: Fix mac warning error in hprof_init.c http://cr.openjdk.java.net/~ohair/openjdk8/repo-jdk/webrev/src/share/demo/jvmti/hprof/hprof_init.c.sdiff.htm

hg: jdk8/tl/jdk: 7195409: CertPath/CertPathValidatorTest/KeyParamsInheritanceTest fails with NullPointerException

2012-09-16 Thread sean . mullan
Changeset: 17881ebf811c Author:mullan Date: 2012-09-16 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17881ebf811c 7195409: CertPath/CertPathValidatorTest/KeyParamsInheritanceTest fails with NullPointerException Reviewed-by: xuelei ! src/share/classes/sun/security/pro