Re: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval

2012-10-11 Thread Rickard Bäckman
Thank you Markus. /R On Oct 12, 2012, at 7:29 AM, Markus Grönlund wrote: > I am ok with this change Rickard. > > Thanks also to David Holmes for his great feedback and help on this one. > > /Markus > > Sent from my iPhone > > On 12 okt 2012, at 07:06, Rickard Bäckman wrote: > >> People, >>

Re: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval

2012-10-11 Thread Markus Grönlund
I am ok with this change Rickard. Thanks also to David Holmes for his great feedback and help on this one. /Markus Sent from my iPhone On 12 okt 2012, at 07:06, Rickard Bäckman wrote: > People, > > I need at least one more reviewer, thanks! > > /R > > On Oct 9, 2012, at 3:00 PM, Rickard Bä

Re: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval

2012-10-11 Thread Rickard Bäckman
People, I need at least one more reviewer, thanks! /R On Oct 9, 2012, at 3:00 PM, Rickard Bäckman wrote: > David, > > thanks for your review! > > /R > > On Oct 9, 2012, at 2:01 PM, David Holmes wrote: > >> On 9/10/2012 9:42 PM, Rickard Bäckman wrote: >>> David, >>> see inline. >>> >>> On O

Re: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer

2012-10-11 Thread David Holmes
Hi Jaroslav, On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: Dmitry has put the webrev on the public CR - http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ Thanks! -JB- On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: I am looking for a review and a sponsor. The

hg: hsx/hotspot-rt/hotspot: 7054345: Support version 52.0 class file in HotSpot

2012-10-11 Thread keith . mcguigan
Changeset: 48a75d2640a5 Author:kamg Date: 2012-10-11 14:27 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/48a75d2640a5 7054345: Support version 52.0 class file in HotSpot Summary: Accept classfiles with major version 52 Reviewed-by: coleenp, acorn ! src/share/vm/c

hg: hsx/hotspot-rt/langtools: 12 new changesets

2012-10-11 Thread john . coomes
Changeset: 489905e5018e Author:jjg Date: 2012-09-07 11:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/489905e5018e 7186925: JavapTask passes null to java.io.Writer Reviewed-by: jjh ! src/share/classes/com/sun/tools/javap/JavapTask.java + test/tools/javap/T718

hg: hsx/hotspot-rt/jdk: 64 new changesets

2012-10-11 Thread john . coomes
Changeset: 8a64eeca4450 Author:jgodinez Date: 2012-09-10 10:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8a64eeca4450 7183516: [macosx]Can't print-out the defined fonts for PrintFont_2D and AntialiasTableTest. Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CT

hg: hsx/hotspot-rt/jaxp: 2 new changesets

2012-10-11 Thread john . coomes
Changeset: af9e8b0f1900 Author:katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/af9e8b0f1900 Added tag jdk8-b58 for changeset 1cb19abb3f7b ! .hgtags Changeset: 2d1dff5310da Author:katleman Date: 2012-10-04 14:35 -0700 URL:

hg: hsx/hotspot-rt/corba: 2 new changesets

2012-10-11 Thread john . coomes
Changeset: d54dc53e223e Author:katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/d54dc53e223e Added tag jdk8-b58 for changeset 18462a19f7bd ! .hgtags Changeset: 207ef43ba69e Author:katleman Date: 2012-10-04 14:34 -0700 URL:

hg: hsx/hotspot-rt/jaxws: 2 new changesets

2012-10-11 Thread john . coomes
Changeset: ae107401be11 Author:katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/ae107401be11 Added tag jdk8-b58 for changeset cac4c3937063 ! .hgtags Changeset: 5c5a65ad5291 Author:katleman Date: 2012-10-04 14:35 -0700 URL:

hg: hsx/hotspot-rt: 4 new changesets

2012-10-11 Thread john . coomes
Changeset: dae9821589cc Author:katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/dae9821589cc Added tag jdk8-b58 for changeset 936702480487 ! .hgtags Changeset: b9d574659206 Author:katleman Date: 2012-10-04 14:34 -0700 URL: htt

Re: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject

2012-10-11 Thread Eamonn McManus
Looks good. A couple of minor nits about the test: there is a stray IDE template comment on line 74, and the copyright date is wrong. Éamonn 2012/10/11 Jaroslav Bachorik : > Just to keep it clear - here is the webrev hosted at CR - > http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/J

hg: jdk8/tl/jdk: 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol]

2012-10-11 Thread rob . mckenna
Changeset: 7c2f5e52863c Author:robm Date: 2012-10-11 18:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c2f5e52863c 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol] Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Bas

Re: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject

2012-10-11 Thread Jaroslav Bachorik
Just to keep it clear - here is the webrev hosted at CR - http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6783290-v1/ -JB- On Wed 10 Oct 2012 08:46:04 PM CEST, Jaroslav Bachorik wrote: > Hi, > > On Wed 10 Oct 2012 05:49:11 PM CEST, Eamonn McManus wrote: >> Hi Jaroslav, >> >> The

Re: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer

2012-10-11 Thread Jaroslav Bachorik
Dmitry has put the webrev on the public CR - http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ Thanks! -JB- On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: > I am looking for a review and a sponsor. > > The issue is about some javax.management.timer.Timer notificatio