Re: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal

2012-10-16 Thread David Holmes
Hi Yumin, Not really a review as I don't understand this part of the code. On 17/10/2012 2:51 PM, Yumin Qi wrote: Hi, all May I have your codereview on http://cr.openjdk.java.net/~minqi/8000818/ 8000818: SA constant pool need to reference to ref

RFR: 8000818: SA constant pool need to reference to reference map after permgen removal

2012-10-16 Thread Yumin Qi
Hi, all May I have your codereview on http://cr.openjdk.java.net/~minqi/8000818/ 8000818: SA constant pool need to reference to reference map after permgen removal Summary: After permgen removal, constant pool changed to put _ldc and _ldc_w (

hg: jdk8/tl/langtools: 8000673: remove dead code from HtmlWriter and subtypes

2012-10-16 Thread jonathan . gibbons
Changeset: 2013982bee34 Author:jjg Date: 2012-10-16 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2013982bee34 8000673: remove dead code from HtmlWriter and subtypes Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.

hg: jdk8/tl/jdk: 7198073: (prefs) user prefs not saved [macosx]

2012-10-16 Thread kurchi . subhra . hazra
Changeset: 3a6b76a468bd Author:khazra Date: 2012-10-16 15:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a6b76a468bd 7198073: (prefs) user prefs not saved [macosx] Summary: Using class member field to get node instead of argument Reviewed-by: alanb ! src/macosx/classes/j

hg: jdk8/tl/jdk: 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition) doesn't work as expected with custom extensions; ...

2012-10-16 Thread naoto . sato
Changeset: 32452042b781 Author:naoto Date: 2012-10-16 10:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/32452042b781 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition) doesn't work as expected with custom extensions 8000273: java.util.Locale.getDisplayVar