Re: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure

2012-10-25 Thread Jaroslav Bachorik
Thanks, addressing the comments ... On 10/24/2012 05:43 PM, Eamonn McManus wrote: The fix looks good, but I would adjust a couple of small things. First, you can improve the existing and new code with multi-catch. Second, the message in the if (notFoundCount 0) block should be adjusted to

Re: jmx-dev [PATCH] JDK-6705499: Bad JMXConnectorProvider class name prevents all connections - even with standard RMI connector

2012-10-25 Thread Jaroslav Bachorik
On 10/24/2012 04:28 PM, Alan Bateman wrote: On 24/10/2012 15:15, Jaroslav Bachorik wrote: I am looking for review and a sponsor. Webrev is available at http://cr.openjdk.java.net/~jbachorik/JDK-6705499/webrev.00/ The issue is caused by the way the java.util.ServiceLoader treats the service

Re: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure

2012-10-25 Thread Eamonn McManus
Looks good. Reviewed-by: emcmanus Éamonn 2012/10/25 Jaroslav Bachorik jaroslav.bacho...@oracle.com Thanks, addressing the comments ... On 10/24/2012 05:43 PM, Eamonn McManus wrote: The fix looks good, but I would adjust a couple of small things. First, you can improve the existing and

Re: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure

2012-10-25 Thread Eamonn McManus
Looks good. Reviewed-by: emcmanus Éamonn 2012/10/25 Jaroslav Bachorik jaroslav.bacho...@oracle.com Thanks, addressing the comments ... On 10/24/2012 05:43 PM, Eamonn McManus wrote: The fix looks good, but I would adjust a couple of small things. First, you can improve the existing and

hg: jdk8/tl/langtools: 7200915: convert TypeTags from a series of small ints to an enum

2012-10-25 Thread jonathan . gibbons
Changeset: c002fdee76fd Author:jjg Date: 2012-10-25 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c002fdee76fd 7200915: convert TypeTags from a series of small ints to an enum Reviewed-by: jjg, mcimadamore Contributed-by: vicente.rom...@oracle.com !

Re: RFR: 8000489: older builds of hsdis don't work anymore after 6879063

2012-10-25 Thread Yumin Qi
John, and all I updated the webrev. I also made changes to make 'nice new line to be a argument of decode_instructions_virtual so it can be changed instead of hard coded as 'false'. To John's question, it doesn't require changes to disassembler.cpp: new version ---

hg: jdk8/tl/langtools: 6725230: Java Compilation with Jsr199 ignores Class-Path in manifest

2012-10-25 Thread jonathan . gibbons
Changeset: ea2616a6bd01 Author:jjg Date: 2012-10-25 13:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea2616a6bd01 6725230: Java Compilation with Jsr199 ignores Class-Path in manifest Reviewed-by: jjg, mcimadamore Contributed-by: vicente.rom...@oracle.com !

hg: jdk8/tl/jdk: 8000806: Implement runtime lambda metafactory

2012-10-25 Thread robert . field
Changeset: 6302932b7380 Author:rfield Date: 2012-10-25 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6302932b7380 8000806: Implement runtime lambda metafactory Summary: Implement lambda invokedynamic bootstrap by generating at runtime an inner class that implements

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-10-25 Thread coleen . phillimore
Changeset: 5ec0c42da025 Author:coleenp Date: 2012-10-25 16:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ec0c42da025 7188234: Deprecate VM command line options Summary: Remove support for the UseVectoredExceptions flag Reviewed-by: jcoomes, kamg

hg: hsx/hotspot-rt: 3 new changesets

2012-10-25 Thread john . coomes
Changeset: c12e759ac4e8 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c12e759ac4e8 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by:

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b62 for changeset 5d0fa0108d02

2012-10-25 Thread john . coomes
Changeset: a96e34e038f5 Author:katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/a96e34e038f5 Added tag jdk8-b62 for changeset 5d0fa0108d02 ! .hgtags

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b62 for changeset d265b9b4c0f5

2012-10-25 Thread john . coomes
Changeset: c27ea8d489e8 Author:katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/c27ea8d489e8 Added tag jdk8-b62 for changeset d265b9b4c0f5 ! .hgtags

hg: hsx/hotspot-rt/langtools: Added tag jdk8-b62 for changeset b47bb81ba962

2012-10-25 Thread john . coomes
Changeset: 16498acd21b5 Author:katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/16498acd21b5 Added tag jdk8-b62 for changeset b47bb81ba962 ! .hgtags

hg: hsx/hotspot-rt/corba: 3 new changesets

2012-10-25 Thread john . coomes
Changeset: 0a5931be9176 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/0a5931be9176 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7