Re: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge

2012-10-30 Thread serguei.spit...@oracle.com
Ok, it seems there are some suspicious fragments in the interpreter code. Christian, could you, please, check and comment the fragments below? This is how the Method::max_stack() is defined: *src/share/vm/oops/method.hpp*: int verifier_max_stack() const{ return _max_stack; }

Re: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge

2012-10-30 Thread serguei.spit...@oracle.com
On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: Thumbs up. Thanks, Dan! Serguei Is someone going to do an audit for similar missing changes from max_stack() (not max_size()) to verifier_max_stack()? Dan On 10/30/12 1:30 PM, serguei.spit...@oracle.com wrote: Hello, Please, review the

Re: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge

2012-10-30 Thread serguei.spit...@oracle.com
I have a plan to look at it, at least for other serviceablity code. It'd be good if someone from the runtime or compiler team checked it too. Thanks, Serguei On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: Thumbs up. Is someone going to do an audit for similar missing changes from max_stack(

Re: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge

2012-10-30 Thread Daniel D. Daugherty
Thumbs up. Is someone going to do an audit for similar missing changes from max_stack() (not max_size()) to verifier_max_stack()? Dan On 10/30/12 1:30 PM, serguei.spit...@oracle.com wrote: Hello, Please, review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 CR i

1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge

2012-10-30 Thread serguei.spit...@oracle.com
Hello, Please, review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 CR in JIRA: https://jbs.oracle.com/bugs/browse/JDK-7194607 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size Summary: This issue is caused by the changes

hg: jdk8/tl/langtools: 8001929: fix doclint errors in langtools doc comments

2012-10-30 Thread jonathan . gibbons
Changeset: 23fe1a96bc0f Author:jjg Date: 2012-10-30 10:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/23fe1a96bc0f 8001929: fix doclint errors in langtools doc comments Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java !

Re: [PATCH] JDK-7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently

2012-10-30 Thread Eamonn McManus
This area has historically caused a lot of problems and I am not surprised to see that there are more. While I don't know what the best way to fix the issue at hand is, I don't think this proposed change is it. The reason is that the checkConnection and gotIOException methods do blocking operations