On 2012-11-22 19:04, David Holmes wrote:
On 22/11/2012 2:17 PM, David Holmes wrote:
I have a few comments on this part:
- Array indices should be int's not size_t (ie signed not unsigned)
I humbly withdraw that comment. It is required to be an "integer type"
which includes both signed and un
On 22/11/2012 2:17 PM, David Holmes wrote:
I have a few comments on this part:
- Array indices should be int's not size_t (ie signed not unsigned)
I humbly withdraw that comment. It is required to be an "integer type"
which includes both signed and unsigned and various sizes.
I certainly pr
On 2012-11-22 16:35, David Holmes wrote:
Hi Mikael,
I prefer this as an internal test too. Though I don't understand why
execute_internal_vm_tests is in jni.cpp rather than jvm.cpp - this is
an enhancement to the VM interface not the JNI interface isn't it?
(Separate issue of course).
I th
Hi Mikael,
I prefer this as an internal test too. Though I don't understand why
execute_internal_vm_tests is in jni.cpp rather than jvm.cpp - this is an
enhancement to the VM interface not the JNI interface isn't it?
(Separate issue of course).
BTW the weird indentation makes more sense view
I gave it some more thought and decided to try what it would look like
having the test be part of the ExecuteInternalVMTests family instead. I
like this one better personally, but comments are appreciated!
http://cr.openjdk.java.net/~mikael/8003879/webrev.02
Cheers,
Mikael
On 2012-11-22 14:
New webrev available here:
http://cr.openjdk.java.net/~mikael/8003879/webrev.01
Cheers,
Mikael
On 2012-11-22 14:19, Mikael Vidstedt wrote:
On 2012-11-21 20:17, David Holmes wrote:
Hi Mikael,
On 22/11/2012 11:42 AM, Mikael Vidstedt wrote:
Please review the below change.
The change for 704
On 2012-11-21 20:17, David Holmes wrote:
Hi Mikael,
On 22/11/2012 11:42 AM, Mikael Vidstedt wrote:
Please review the below change.
The change for 7045397 introduced a couple of duplicate entries in the
vmStructs::localHotSpotVMTypes array. This shows up when using the jmap
tool in a rather ug
Bill,
Looks good for me.
-Dmitry
On 2012-11-21 23:31, BILL PITTORE wrote:
> Hi Dmitry,
>
> On 11/21/2012 4:56 AM, Dmitry Samersoff wrote:
>> Bill,
>>
>>
>> Few nits:
>>
>> 1.
>>
>> dll_build_name is exactly the same for all locations could we place it
>> to some common place?
> It looked somewh
