Changeset: a02212de8db6
Author:uta
Date: 2012-12-17 14:34 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a02212de8db6
8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem
Summary: the tests were refactored to drop AWT dependence where it was possible.
Hi,
Please review the following change for CR 8004095.
This changeset is the JDK side of two parts project.
The goal of this feature is to allow remote invocations of
Diagnostic Commands via JMX.
Diagnostic Commands are actually invoked from the jcmd
tool, which is a local tool using the atta
Hi,
Please review the following change for CR 7150256.
This changeset is the JDK side of two parts project.
The goal of this feature is to allow remote invocations of
Diagnostic Commands via JMX.
Diagnostic Commands are actually invoked from the jcmd
tool, which is a local tool using the attac
Frederic,
Looks good! Just a few small comments below.
diagnosticCommand.cpp:255: When DisableExplicitGC is set, it would be great if
the SystemGC command printed on error message so that the caller knows that the
GC didn't happen as intended. I also think we should add an entry to GCCause
for
Hi Frederic,
I've found the following issues when inspecting the changes in the Java
code:
JB1: src/share/classes/sun/management/VMManagementImpl.java
getDiagnosticCommands(), getDiagnosticCommandInfo() and
executeDiagnosticCommand() are all publicly accessible native methods
accepting the user i
Thank you for this feedback, my comments are in-lined below.
The updated webrev is here:
http://cr.openjdk.java.net/~fparain/7150256/webrev.01/
On 12/17/12 02:12 PM, Jaroslav Bachorik wrote:
Hi Frederic,
I've found the following issues when inspecting the changes in the Java
code:
JB1: src/sh
Changeset: 02a18f209ab3
Author:vromero
Date: 2012-12-17 14:54 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/02a18f209ab3
8004814: javadoc should be able to detect default methods
Reviewed-by: jjg
Contributed-by: maurizio.cimadam...@oracle.com
! src/share/classes/com/s
Staffan,
Thank you for the review, I've fixed the code to address all
the issue you reported. The new webrev is here:
http://cr.openjdk.java.net/~fparain/8004095/webrev.01/
Regards,
Fred
On 12/17/12 01:27 PM, Staffan Larsen wrote:
Frederic,
Looks good! Just a few small comments below.
diag
diagnosticCommand.cpp:259: nit: wrong indentation
Otherwise: Looks good to me!
Thanks,
/Staffan
On 17 dec 2012, at 16:01, Frederic Parain wrote:
> Staffan,
>
> Thank you for the review, I've fixed the code to address all
> the issue you reported. The new webrev is here:
>
> http://cr.openjdk
Changeset: 75ab654b5cd5
Author:jjg
Date: 2012-12-17 07:47 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75ab654b5cd5
8004832: Add new doclint package
Reviewed-by: mcimadamore
! make/build.properties
! src/share/classes/com/sun/source/util/DocTrees.java
! src/share/cla
Changeset: bcf79e6f52a0
Author:chegar
Date: 2012-12-17 16:27 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf79e6f52a0
8005081: java/util/prefs/PrefsSpi.sh fails on macos-x
Reviewed-by: alanb
! test/java/util/prefs/PrefsSpi.sh
Changeset: f20568328a57
Author:mcimadamore
Date: 2012-12-17 16:13 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f20568328a57
8004099: Bad compiler diagnostic generated when poly expression is passed to
non-existent method
Summary: Some code paths in resolve do not use
Changeset: a0779b1e9a4d
Author:jjg
Date: 2012-12-17 08:34 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/a0779b1e9a4d
8005090: Include com.sun.source.doctree in Tree API docs
Reviewed-by: erikj
! common/makefiles/javadoc/NON_CORE_PKGS.gmk
Changeset: 9f1b516cd9cb
Author:jjg
Date: 2012-12-17 08:34 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f1b516cd9cb
8005090: Include com.sun.source.doctree in Tree API docs
Reviewed-by: erikj
! make/docs/NON_CORE_PKGS.gmk
On 12/17/2012 03:58 PM, Frederic Parain wrote:
> Thank you for this feedback, my comments are in-lined below.
>
> The updated webrev is here:
> http://cr.openjdk.java.net/~fparain/7150256/webrev.01/
>
> On 12/17/12 02:12 PM, Jaroslav Bachorik wrote:
>> Hi Frederic,
>>
>> I've found the following
Changeset: bac477d67867
Author:jjg
Date: 2012-12-17 10:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bac477d67867
8004832: Add new doclint package
Reviewed-by: erikj, ohair
! make/common/Release.gmk
! make/common/internal/Defs-langtools.gmk
! makefiles/CreateJars.gmk
Changeset: 064e372f273d
Author:jjg
Date: 2012-12-17 10:55 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/064e372f273d
8004961: rename Plugin.call to Plugin.init
Reviewed-by: mcimadamore
! src/share/classes/com/sun/source/util/Plugin.java
! src/share/classes/com/sun/too
Changeset: 3f84e17b6bca
Author:zgu
Date: 2012-12-17 13:14 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3f84e17b6bca
8004802: jcmd VM.native_memory baseline=false crashes VM
Summary: NMT has to check option's value also to determine which command to
execute
Revie
Changeset: ef537bcc825a
Author:mchung
Date: 2012-12-17 15:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef537bcc825a
8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init
Reviewed-by: darcy, jjh
! src/share/classes/com/sun/tools/doclint/DocLint.j
19 matches
Mail list logo
