Changeset: 15b32367b23c
Author:joehw
Date: 2012-12-18 21:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/15b32367b23c
8003261: static field is public but not final
Summary: add final to fVersion field, and make it a non-compile time constant.
Reviewed-by: hawtin, lancea, d
Changeset: e8b54ae97344
Author:jviswana
Date: 2012-12-12 13:28 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8b54ae97344
8004316: Printer - tempfile having incorrect extension
Reviewed-by: bae, jgodinez
! src/solaris/classes/sun/print/UnixPrintJob.java
Changeset: fd9e6b4c
Changeset: d7360bf35ee1
Author:lana
Date: 2012-12-14 13:15 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7360bf35ee1
Merge
Changeset: 573b38691a74
Author:lana
Date: 2012-12-18 18:15 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/573b38691
Thanks for the quick reviews by all.
I will agree with Dan on this one, sprint will stay.
Ron
From: Daniel D. Daugherty
Sent: Tuesday, December 18, 2012 4:03 PM
To: hotspot-runtime-...@openjdk.java.net; build-dev;
serviceability-dev@openjdk.java.net
Subject: Re: Code Review fix for 80
Sorry, I lost my manners somewhere... :-(
Thanks for the fast review!
Dan
On 12/18/12 3:57 PM, Daniel D. Daugherty wrote:
Adding back in the other aliases...
Harold,
The equivalentof:
snprintf(buf, n, str);
is:
strncpy(buf, str, n - 1);
buf[n - 1] = '\0';
because snprintf()
Adding back in the other aliases...
Harold,
The equivalentof:
snprintf(buf, n, str);
is:
strncpy(buf, str, n - 1);
buf[n - 1] = '\0';
because snprintf() will only write out (n-1) bytes from
'str' to 'buf'and then write a NUL in the lastslot.
strncpy() copies up to 'n' bytes from'
Changeset: 6d977f61af5e
Author:darcy
Date: 2012-12-18 14:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d977f61af5e
8004699: Add type annotation storage to Constructor, Field and Method
Reviewed-by: darcy, dholmes
Contributed-by: joel.fra...@oracle.com
! src/share/classe
Changeset: 0a1398021c7c
Author:darcy
Date: 2012-12-18 14:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1398021c7c
8005042: Add Method.isDefault to core reflection
Reviewed-by: alanb, forax, mduigou, jgish, mchung
! src/share/classes/java/lang/reflect/Method.java
+ test
Adding back in the other aliases...
Coleen, thanks for the fast review!
Dan
On 12/18/12 2:29 PM, Coleen Phillimore wrote:
This looks good. Thank you for doing this.
Coleen
On 12/18/2012 03:46 PM, Daniel D. Daugherty wrote:
Greetings,
I'm sponsoring this code review request from Ron Durb
Ahhh... now I understand...
The review threads for:
7153050 remove crufty '_g' support from HotSpot repo
made mention of the need for fixes in the Runtime src/... files
so I included all the aliases on the 7153050 review as my way
of closing the loop.
Ron, if you end up tackling the other
Changeset: 250f0acf880c
Author:mcimadamore
Date: 2012-12-18 22:16 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/250f0acf880c
8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails
Summary: Bad golden file in negative test
Reviewed-by: jjh
! tes
I suspected that, but you sent it to build-dev and I was expecting makefile
changes.
So good to go from build-dev
-kto
On Dec 18, 2012, at 1:18 PM, Ron Durbin wrote:
>
> Dan is correct.
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Tuesday, December 18, 2012 2:14 PM
> To:
Dan is correct.
-Original Message-
From: Daniel D. Daugherty
Sent: Tuesday, December 18, 2012 2:14 PM
To: Kelly O'Hair
Cc: serviceability-dev@openjdk.java.net; build-dev;
hotspot-runtime-...@openjdk.java.net
Subject: Re: Code Review fix for 8005044 remove crufty '_g' support from HS
run
Kelly,
The Makefile changes were reviewed under 7153050 last week and
pushed to RT_Baseline.
See the attached notification.
Dan
On 12/18/12 2:06 PM, Kelly O'Hair wrote:
I don't see any makefile changes.
-kto
On Dec 18, 2012, at 12:46 PM, Daniel D. Daugherty wrote:
Greetings,
I'm sponso
Just for the record: I have reviewed all of Ron's changes
and I approve them.
One thing I noticed of interest to launcher folks that
is not due to any changes that Ron made:
src/os/windows/vm/os_windows.cpp:
1718 // Find the full path to the current module, jvm.dll
1719 void os::jvm_path(char *
I don't see any makefile changes.
-kto
On Dec 18, 2012, at 12:46 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> I'm sponsoring this code review request from Ron Durbin. This change
> is targeted at JDK8/HSX-25 in the RT_Baseline repo.
>
> Dan
>
> Sending again with correct subject line, bug
Greetings,
I'm sponsoring this code review request from Ron Durbin. This change
is targeted at JDK8/HSX-25 in the RT_Baseline repo.
Dan
Sending again with correct subject line, bug URLs and webrev URL.
Intro:
This set of changes removes the runtimesupport for generation of debug
versions th
Intro:
This set of changes removes the runtime support for generation of debug
versions that follow _g semantics.
Defect:
JDK-8005044 remove crufty '_g' support from HS runtime code
Webrev
/u/rdurbin/8005044_exp/webrev/index.html
Details:
Files have been modified to remove al
It is good to call
gotIOException((IOException)e);
but no need to call in next
restart((IOException)e);
the method "gotIOException" should call "restart" if necessary,
otherwise "restart" may be called 2 times and generated 2 times
"Reconnection notification".
Shanliang
Jaroslav Ba
Changeset: 0fabdf676395
Author:martin
Date: 2012-12-17 18:39 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0fabdf676395
8004863: Infinite Loop in KeepAliveStream
Reviewed-by: chegar
! src/share/classes/sun/net/www/http/KeepAliveStream.java
+ test/sun/net/www/http/KeepAliveS
I've updated the webrev - no additional synchronisation is required.
Please, review: http://cr.openjdk.java.net/~jbachorik/JDK-7146162/webrev.04
-JB-
On 10/31/2012 01:59 PM, Jaroslav Bachorik wrote:
> On 10/30/2012 05:10 PM, Eamonn McManus wrote:
>> This area has historically caused a lot of prob
Changeset: 92fcf299cd09
Author:ohrstrom
Date: 2012-12-18 10:23 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/92fcf299cd09
8004657: Add hooks to javac to enable reporting dependency information.
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/tools/javac/api/
Changeset: bc74006c2d8d
Author:darcy
Date: 2012-12-18 00:24 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bc74006c2d8d
8005046: Provide checking for a default method in javax.lang.model
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/sh
23 matches
Mail list logo
