Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-01-10 Thread Stuart Marks
On 1/7/13 3:23 AM, Jaroslav Bachorik wrote: On 01/04/2013 11:37 PM, Kelly O'Hair wrote: I suspect it is not hanging because it does not exist, but that some other windows process has it's hands on it. This is the stdout file from the server being started up right? Could the server from a previo

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread Jaroslav Bachorik
On 01/09/2013 03:25 PM, shanliang wrote: > Jaroslav Bachorik wrote: >> On 01/09/2013 02:44 PM, shanliang wrote: >> >>> Let's forget the JMX implementation at first. If an MBean is >>> unregistered, a user at client side calls "removeNotificationListener" >>> on the MBean, what should happen? if t

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread shanliang
Jaroslav Bachorik wrote: On 01/09/2013 03:25 PM, shanliang wrote: Jaroslav Bachorik wrote: On 01/09/2013 02:44 PM, shanliang wrote: Let's forget the JMX implementation at first. If an MBean is unregistered, a user at client side calls "removeNotificationListener" on the MBean,

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-01-10 Thread Stuart Marks
On 1/10/13 12:52 AM, Stuart Marks wrote: The exit status of some of the critical commands (such as the compilations) isn't checked, so if javac fails for some reason, the test might not report failure. Instead, some weird error might or might not be reported later (though one will still see the j

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread Jaroslav Bachorik
On 01/10/2013 10:05 AM, shanliang wrote: > Jaroslav Bachorik wrote: >> On 01/09/2013 03:25 PM, shanliang wrote: >> >>> Jaroslav Bachorik wrote: >>> On 01/09/2013 02:44 PM, shanliang wrote: > Let's forget the JMX implementation at first. If an MBean is > unregist

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread Jaroslav Bachorik
On 01/10/2013 10:05 AM, shanliang wrote: > Jaroslav Bachorik wrote: >> On 01/09/2013 03:25 PM, shanliang wrote: >> >>> Jaroslav Bachorik wrote: >>> On 01/09/2013 02:44 PM, shanliang wrote: > Let's forget the JMX implementation at first. If an MBean is > unregist

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread shanliang
Instead to wait GC, you can also to wait the MBeanServerNotification.UNREGISTRATION_NOTIFICATION, when you receive it, then your listener must be removed too. Of course this solution is implementation dependent, but the test is already implementation dependent. Shanliang Jaroslav Bachorik wr

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread Jaroslav Bachorik
On 01/10/2013 12:53 PM, shanliang wrote: > Instead to wait GC, you can also to wait the > MBeanServerNotification.UNREGISTRATION_NOTIFICATION, when you receive > it, then your listener must be removed too. Of course this solution is The problem is that the *NotificationForwarder implementations sw

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread Jaroslav Bachorik
On 01/10/2013 01:09 PM, Jaroslav Bachorik wrote: > On 01/10/2013 12:53 PM, shanliang wrote: >> Instead to wait GC, you can also to wait the >> MBeanServerNotification.UNREGISTRATION_NOTIFICATION, when you receive >> it, then your listener must be removed too. Of course this solution is > > The pro

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread shanliang
The weakListener is unnecessary, the test does already the same verification: 171 Set setForUnreg = listenerMap.get(name); 172 assertTrue("No trace of unregistered MBean: " + setForUnreg, setForUnreg == null); All other are OK for me. Shanliang Jaroslav Bachorik wrote: On 0

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread Jaroslav Bachorik
On 01/10/2013 02:18 PM, shanliang wrote: > The weakListener is unnecessary, the test does already the same > verification: > 171 Set setForUnreg = listenerMap.get(name); > 172 assertTrue("No trace of unregistered MBean: " + setForUnreg, > setForUnreg == null); Addressed. > > All

Re: jmx-dev [PATCH] JDK-7170447: Intermittent DeadListenerTest.java failure

2013-01-10 Thread shanliang
It is OK for me, thanks for fixing the bug! Shanliang Jaroslav Bachorik wrote: On 01/10/2013 02:18 PM, shanliang wrote: The weakListener is unnecessary, the test does already the same verification: 171 Set setForUnreg = listenerMap.get(name); 172 assertTrue("No trace of unre

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-01-10 Thread Jaroslav Bachorik
Update: http://cr.openjdk.java.net/~jbachorik/8005472/webrev.04 On 01/10/2013 09:52 AM, Stuart Marks wrote: > On 1/7/13 3:23 AM, Jaroslav Bachorik wrote: >> On 01/04/2013 11:37 PM, Kelly O'Hair wrote: >>> I suspect it is not hanging because it does not exist, but that some >>> other windows proces

hg: jdk8/tl/jdk: 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments

2013-01-10 Thread naoto . sato
Changeset: c622df692bfb Author:bchristi Date: 2013-01-10 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c622df692bfb 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments Summary: Test script now sets LC_ALL, other small changes, reloc

Re: RFR: 8004095: Add support for JMX interface to Diagnostic Framework and Commands,

2013-01-10 Thread Karen Kinnear
Frederic, Finally getting to a code review. I like the design and the code looks very clean. I had a couple of questions please: 1. in the EFP and diagnosticCommand.hpp, why do GC.run and GC. run_finalization not need any special Java permissions? Is this backward compatibility with existing w

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-01-10 Thread Stuart Marks
On 1/10/13 7:20 AM, Jaroslav Bachorik wrote: Update: http://cr.openjdk.java.net/~jbachorik/8005472/webrev.04 Thanks for the update. Note, argv[0] is used before argv.length is checked, so if no args are passed this gives index out of bounds instead of the usage message. I see you take pains

hg: jdk8/tl/jdk: 8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures

2013-01-10 Thread stuart . marks
Changeset: 13ff1089e625 Author:jgish Date: 2013-01-10 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13ff1089e625 8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures Summary: Remove file-deletion code at cleanup which conflicts with jtreg cleanup

hg: jdk8/tl/langtools: 8006037: extra space in javac -help for -J and @ options

2013-01-10 Thread jonathan . gibbons
Changeset: d462da465da6 Author:jjg Date: 2013-01-10 14:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d462da465da6 8006037: extra space in javac -help for -J and @ options Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java + test/tools/javac

hg: jdk8/tl/langtools: 8006033: bug in Pretty.toSimpleString

2013-01-10 Thread jonathan . gibbons
Changeset: 7d2f628f04f1 Author:jjg Date: 2013-01-10 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d2f628f04f1 8006033: bug in Pretty.toSimpleString Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/PrettySimpleS

hg: hsx/hotspot-rt/hotspot: 7199207: NPG: Crash in PlaceholderTable::verify after StackOverflow

2013-01-10 Thread karen . kinnear
Changeset: aefb345d3f5e Author:acorn Date: 2013-01-10 17:38 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aefb345d3f5e 7199207: NPG: Crash in PlaceholderTable::verify after StackOverflow Summary: Reduce scope of placeholder table entries to improve cleanup Reviewe

hg: jdk8/tl/langtools: 8004834: Add doclint support into javadoc

2013-01-10 Thread jonathan . gibbons
Changeset: fc4cb1577ad6 Author:jjg Date: 2013-01-10 19:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fc4cb1577ad6 8004834: Add doclint support into javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/

hg: jdk8/tl/jdk: 2 new changesets

2013-01-10 Thread jonathan . gibbons
Changeset: c6e8a518c3cd Author:jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6e8a518c3cd 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! make/docs/Makefile Changeset: c9308137ad9e Author:jjg Date: 2013-01-10 19:37

hg: jdk8/tl: 8004834: Add doclint support into javadoc

2013-01-10 Thread jonathan . gibbons
Changeset: 1129fb75f611 Author:jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1129fb75f611 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! common/makefiles/javadoc/Javadoc.gmk

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b72 for changeset bdf2af722a6b

2013-01-10 Thread john . coomes
Changeset: 84946404d1e1 Author:katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/84946404d1e1 Added tag jdk8-b72 for changeset bdf2af722a6b ! .hgtags

hg: hsx/hotspot-rt/corba: Added tag jdk8-b72 for changeset cb40427f4714

2013-01-10 Thread john . coomes
Changeset: 191afde59e7b Author:katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/191afde59e7b Added tag jdk8-b72 for changeset cb40427f4714 ! .hgtags

hg: hsx/hotspot-rt: Added tag jdk8-b72 for changeset c1be681d80a1

2013-01-10 Thread john . coomes
Changeset: f03f90a4308d Author:katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/f03f90a4308d Added tag jdk8-b72 for changeset c1be681d80a1 ! .hgtags

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b72 for changeset d9707230294d

2013-01-10 Thread john . coomes
Changeset: c606f644a5d9 Author:katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/c606f644a5d9 Added tag jdk8-b72 for changeset d9707230294d ! .hgtags

hg: hsx/hotspot-rt/jdk: Added tag jdk8-b72 for changeset 32a57e645e01

2013-01-10 Thread john . coomes
Changeset: c9a914b11436 Author:katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c9a914b11436 Added tag jdk8-b72 for changeset 32a57e645e01 ! .hgtags

hg: hsx/hotspot-rt/langtools: Added tag jdk8-b72 for changeset 6f0986ed9b7e

2013-01-10 Thread john . coomes
Changeset: 45fed5cfd1c3 Author:katleman Date: 2013-01-10 09:56 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/45fed5cfd1c3 Added tag jdk8-b72 for changeset 6f0986ed9b7e ! .hgtags

hg: jdk8/tl/jaxp: 8003147: port fix for BCEL bug 39695

2013-01-10 Thread vikram . aroskar
Changeset: 47738fa4d411 Author:dbuck Date: 2013-01-10 20:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/47738fa4d411 8003147: port fix for BCEL bug 39695 Summary: Added support for Local Variable Type Table so that BCEL library can be used to modify methods with generics

hg: jdk8/tl/jdk: 8006062: Add @Repeatable to repeating annotations regression tests in JDK repo

2013-01-10 Thread joe . darcy
Changeset: 86c563dc70ca Author:darcy Date: 2013-01-10 21:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86c563dc70ca 8006062: Add @Repeatable to repeating annotations regression tests in JDK repo Reviewed-by: jjg ! test/java/lang/annotation/repeatingAnnotations/subpackage