Also check out:
http://openjdk.java.net/guide/producingChangeset.html#create
I prefer the full form:
Contributed-by: Ben Bitdiddle
David
On 25/01/2013 12:26 PM, Tao Mao wrote:
Check out jcheck.py code
http://hg.openjdk.java.net/code-tools/jcheck/dist/raw-file/tip/jcheck.py
con_check = re.c
Changeset: 5daaddd917a1
Author:coleenp
Date: 2013-01-23 10:34 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5daaddd917a1
8006040: NPG: on_stack processing wastes space in ConstantPool
Summary: Added on_stack bit to flags. Also MetadataMarkOnStack is used for
mor
may be it can't parse two email addresses. Probably expecting a single
email address in contributed by line?
-- ramki
On Thu, Jan 24, 2013 at 5:28 PM, Yumin Qi wrote:
> When I add
> yunda@taobao.com
> in following comment:
>
> 8005278: Serviceability Agent: jmap -heap and jstack -m fail
> S
Check out jcheck.py code
http://hg.openjdk.java.net/code-tools/jcheck/dist/raw-file/tip/jcheck.py
con_check = re.compile("Contributed-by: ((" + addr_pat + ")(, (" +
addr_pat + "))*)$")
jcheck can take multiple contributors (N >= 1) as long as you comply
with the format.
It's a good thing t
Yes, no more than one leading space needed, also, the space between ','
and following email address is a must too. Very confusing. jcheck should
ignore extra spaces.
Thanks
Yumin
On 1/24/2013 5:44 PM, mark.reinh...@oracle.com wrote:
2013/1/24 17:31 -0800, ysr1...@gmail.com:
may be it can't p
2013/1/24 17:31 -0800, ysr1...@gmail.com:
> may be it can't parse two email addresses. Probably expecting a single email
> address in contributed by line?
It can handle multiple addresses. Try removing the extra space before
the first address, i.e., make it:
Contributed-by: yunda@taobao.com,
removed my email. Still same:
[jcheck ce5e03ccbf6b 2013-01-23 16:29:50 -0800]
> Changeset: 4039:49f643e94319
> Author:minqi
> Date: 2013-01-24 17:43
>
> 8005278: Serviceability Agent: jmap -heap and jstack -m fail
> Summary: BinaryTreeDictionary is typedef'ed as
AFLBinaryTreeDictionary
When I add
yunda@taobao.com
in following comment:
8005278: Serviceability Agent: jmap -heap and jstack -m fail
Summary: BinaryTreeDictionary is typedef'ed as AFLBinaryTreeDictionary
in vmStructs and in SA we still use old name for that. FreeList now is a
template based class which is not re
Hi Coleen,
Thank you a lot for the review!
On 1/24/13 3:55 PM, Coleen Phillimore wrote:
Hi Serguei,
Putting functions in alphabetical order seems silly, it's better to
have utility functions directly above (or below) the function that
calls them. I'd take out the comment.
I have started
Changeset: 4d3c05cc21d5
Author:darcy
Date: 2013-01-24 16:54 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d3c05cc21d5
8006895: Clarify that FunctionalInferface is only informative
Reviewed-by: briangoetz
! src/share/classes/java/lang/FunctionalInterface.java
Hi Serguei,
Putting functions in alphabetical order seems silly, it's better to have
utility functions directly above (or below) the function that calls
them. I'd take out the comment.
I have started looking at this code a bit. This function
find_or_append_indirect_entry() should be used
Christian,
Thank you a lot for the review!
Nice catch with the ordering.
In fact, I tried to follow the order but missed that the find_new_index
should go first. :)
Thanks,
Serguei
On 1/24/13 2:14 PM, Christian Thalinger wrote:
On Jan 22, 2013, at 4:07 PM, serguei.spit...@oracle.com wrot
On Jan 22, 2013, at 4:07 PM, serguei.spit...@oracle.com wrote:
>
> Please, review the fix for:
> https://jbs.oracle.com/bugs/browse/JDK-8006542
>
>
> Open webrev:
>
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8006542-JVMTI-JSR292.1/
src/share/vm/prims/jvmtiRedefineClasses.h
I know everyone is overloaded this days, but...
May I get a couple of reviews, please?
Thanks,
Serguei
On 1/22/13 4:07 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://jbs.oracle.com/bugs/browse/JDK-8006542
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/
Changeset: b3f0e0c79bcc
Author:vinnie
Date: 2013-01-24 18:21 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3f0e0c79bcc
8006863: javadoc cleanup for 8005408
Reviewed-by: alanb
! src/share/classes/java/security/PKCS12Attribute.java
Changeset: 1fd613016ad9
Author:ksrini
Date: 2013-01-24 09:34 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fd613016ad9
8006850: [pack200] disable pack200 tests until JSR-308 is implemented
Reviewed-by: alanb
! test/ProblemList.txt
Hi Staffan,
thanks for reviewing this!
On 01/24/2013 01:27 PM, Staffan Larsen wrote:
The JDK changes look good, but I think there is change needed in
test/sun/tools/jstatd/jstatGcutilOutput1.awk as well.
Yes, you are right. Please see an updated webrev at:
http://cr.openjdk.java.net/~ehelin/
I haven't seen this fix so will remove it from my diff.
I cloned from hotspot-gc which has not had this fix yet. So I will send
out another webrev based on hotspot-rt.
Thanks
Yumin
On 1/23/2013 10:33 PM, Krystal Mo wrote:
Yumin,
The FIELDINFO_TAG_MASK part in InstanceKlass is already fixed
The JDK changes look good, but I think there is change needed in
test/sun/tools/jstatd/jstatGcutilOutput1.awk as well.
Thanks,
/Staffan
On 24 jan 2013, at 11:51, Erik Helin wrote:
> Hi all,
>
> here are the JDK changes for fixing JDK-8004172. This change updates the
> jstat resource file to
Hi all,
here are the JDK changes for fixing JDK-8004172. This change updates the
jstat resource file to use the new metaspace performance counters and
also updates the tests.
Note that the fixed tests will continue to fail until the HotSpot part
of the change finds it way into the tl forest.
Changeset: b68ac92d0b2a
Author:alanb
Date: 2013-01-24 09:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b68ac92d0b2a
8006524: JSR-3: Allows java.beans to be optional
Reviewed-by: dfuchs, mchung
! src/share/classes/javax/management/MXBean.java
! src/share/classes/javax/man
21 matches
Mail list logo
