Ah, was just about to take a look a this too!
Looks good and equal to what I had in my workspace :)
/Nisse
On Jan 31, 2013, at 8:16 , Yumin Qi yumin...@oracle.com wrote:
Please have your comments on:
http://cr.openjdk.java.net/~minqi/8000973/
This only affected Windows platform.
Thanks, Nils
Yumin
On 1/31/2013 12:12 AM, Nils Loodin wrote:
Ah, was just about to take a look a this too!
Looks good and equal to what I had in my workspace :)
/Nisse
On Jan 31, 2013, at 8:16 , Yumin Qiyumin...@oracle.com wrote:
Please have your comments on:
Hi Yumin,
Looks good.
A couple of minor comments.
1. All the copyright comments are outdated.
2.
*agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java
***agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/x86/WindbgX86Thread.java
**
37 //The address
Serguei,
Thanks
Yumin
On 1/31/2013 11:10 AM, serguei.spit...@oracle.com wrote:
Hi Yumin,
Looks good.
A couple of minor comments.
1. All the copyright comments are outdated.
2.
*
agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java
***
Changeset: e5ce312a5b10
Author:sherman
Date: 2013-01-31 13:13 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5ce312a5b10
8007298: Base64.getMimeDecoder().decode() throws IAE for a single non-base64
character
8006526: Base64.Decoder.decode(String) spec contains a copy-paste
Changeset: cff8d7768d72
Author:mduigou
Date: 2013-01-31 13:27 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cff8d7768d72
8006709: Add minimal support of MacOSX platform for NetBeans Projects
Summary: Adds support for MacOSX platform and architecture detection. Other
minor
Changeset: 50307da0149e
Author:jqzuo
Date: 2012-12-31 14:52 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/rev/50307da0149e
8005583: Install build(gnumake all) failed preventing RE from doing JDK8 combo
builds
Reviewed-by: paulk, billyh
! make/install-rules.gmk
Changeset:
Changeset: 69bc57b1ebdd
Author:katleman
Date: 2013-01-24 16:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/69bc57b1ebdd
Added tag jdk8-b74 for changeset 2087e24a4357
! .hgtags
Changeset: ff0b73a6b3f6
Author:lana
Date: 2013-01-26 18:25 -0800
URL:
Changeset: 966bf9f3c41a
Author:katleman
Date: 2013-01-24 16:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/966bf9f3c41a
Added tag jdk8-b74 for changeset 12db3c5a3393
! .hgtags
Changeset: d4e68ce17795
Author:katleman
Date: 2013-01-24 16:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d4e68ce17795
Added tag jdk8-b74 for changeset 2132845cf5f7
! .hgtags
Changeset: 89fc17e8d808
Author:katleman
Date: 2013-01-24 16:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/89fc17e8d808
Added tag jdk8-b74 for changeset 1a3e54283c54
! .hgtags
Changeset: d58b7b43031b
Author:amurillo
Date: 2013-01-11 02:02 -0800
URL:
Changeset: a09a37cff333
Author:mchung
Date: 2013-01-31 14:29 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a09a37cff333
6355704: (fmt) %f formatting of BigDecimals is incorrect
Reviewed-by: darcy
Contributed-by: brian.burkhal...@oracle.com
!
Stefan,
I just read through this test and it looks like a good test to me (but
I'm not an expert and it took a while to figure out how it worked). I
had two questions. Why does the same definition for @interface
ParameterAnnotation {} appear in both
Stefan,
Looks good.
Agreed with Coleen: do_redefine = doRedefine.
I guess, this name was taken from one of old tests. :)
I'm Ok with two definitions of the interface ParameterAnnotation.
Thanks,
Setguei
On 1/31/13 3:15 PM, Coleen Phillimore wrote:
Stefan,
I just read through this test and
Changeset: bec996065c45
Author:darcy
Date: 2013-01-31 18:58 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bec996065c45
8007351: Malformed copyright statements in typeAnnotations test directory
Reviewed-by: jjg
!
Changeset: 3ab64e4293a1
Author:jjg
Date: 2013-01-31 19:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ab64e4293a1
8007329: minor issues in impl class hierarchry for DCTree.* classes
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javac/tree/DCTree.java
Changeset: 3d97a9a7a82b
Author:jjg
Date: 2013-01-31 19:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d97a9a7a82b
8004353: Generated html is wrong for overview.html; content has incorrect css
footer class
Reviewed-by: jjg
Contributed-by: roger.ri...@oracle.com
!
Hi Staffan,
First, please refrain from doing code cleanup (long line reformatting)
alongside a fairly significant change - it makes the true changes harder
to spot. Thanks.
Based on our discussions this all looks good to me.
Thanks,
David
On 18/01/2013 5:48 AM, Staffan Larsen wrote:
This
That was the idea.
However, can I have Ok for checking this into hs24 while waiting?
Thanks
/R
On Jan 21, 2013, at 11:33 PM, David Holmes wrote:
On 22/01/2013 12:09 AM, Rickard Bäckman wrote:
Yes, that code has changed. Checked in to hs24.
Okay but this is a review for hs25 ;-) So I assume
Changeset: 17b643956999
Author:chegar
Date: 2013-02-01 06:51 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17b643956999
8006395: Race in async socket close on Linux
Reviewed-by: alanb, dsamersoff
! src/solaris/native/java/net/linux_close.c
+
On 1/02/2013 4:54 PM, Rickard Bäckman wrote:
That was the idea.
However, can I have Ok for checking this into hs24 while waiting?
Sorry - ignore the hs25 comment - been looking at too many JDK review
requests.
Yes this seems fine for hs24.
David
Thanks
/R
On Jan 21, 2013, at 11:33 PM,
Reviewed but not sponsored (sorry).
David
On 30/01/2013 10:16 PM, Markus Grönlund wrote:
Greetings,
Asking for review and sponsoring of this very simple change:
Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007134
Webrev: http://cr.openjdk.java.net/~mgronlun/8007134/webrev01/
On 2013-02-01 00:15, Coleen Phillimore wrote:
Stefan,
I just read through this test and it looks like a good test to me (but
I'm not an expert and it took a while to figure out how it worked).
I had two questions. Why does the same definition for @interface
ParameterAnnotation {} appear
On 2013-02-01 01:34, serguei.spit...@oracle.com wrote:
Stefan,
Looks good.
Agreed with Coleen: do_redefine = doRedefine.
I guess, this name was taken from one of old tests. :)
I'm Ok with two definitions of the interface ParameterAnnotation.
Thanks for the review,
StefanK
Thanks,
Setguei
24 matches
Mail list logo
