hg: jdk8/tl/jdk: 2 new changesets

2013-02-04 Thread lana . steuck
Changeset: 6ba6353ab42c Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ba6353ab42c Added tag jdk8-b75 for changeset 4a67fdb752b7 ! .hgtags Changeset: fd37f0846653 Author:lana Date: 2013-02-04 22:37 -0800 URL: http://hg.

hg: jdk8/tl/langtools: 2 new changesets

2013-02-04 Thread lana . steuck
Changeset: 716935fec613 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/716935fec613 Added tag jdk8-b75 for changeset c2e11e2ec4a3 ! .hgtags Changeset: 10619513f51a Author:lana Date: 2013-02-04 22:38 -0800 URL: http

hg: jdk8/tl/jaxp: Added tag jdk8-b75 for changeset ff0b73a6b3f6

2013-02-04 Thread lana . steuck
Changeset: 8d65b381880b Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/8d65b381880b Added tag jdk8-b75 for changeset ff0b73a6b3f6 ! .hgtags

hg: jdk8/tl/jaxws: Added tag jdk8-b75 for changeset 966bf9f3c41a

2013-02-04 Thread lana . steuck
Changeset: a63ef2391c20 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a63ef2391c20 Added tag jdk8-b75 for changeset 966bf9f3c41a ! .hgtags

hg: jdk8/tl/hotspot: Added tag jdk8-b75 for changeset 6778d0b16593

2013-02-04 Thread lana . steuck
Changeset: 20b605466ccb Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/20b605466ccb Added tag jdk8-b75 for changeset 6778d0b16593 ! .hgtags

hg: jdk8/tl/corba: Added tag jdk8-b75 for changeset d4e68ce17795

2013-02-04 Thread lana . steuck
Changeset: 4a6be02e66a3 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4a6be02e66a3 Added tag jdk8-b75 for changeset d4e68ce17795 ! .hgtags

hg: jdk8/tl: Added tag jdk8-b75 for changeset 2a713921952c

2013-02-04 Thread lana . steuck
Changeset: 5b19cef637a6 Author:katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5b19cef637a6 Added tag jdk8-b75 for changeset 2a713921952c ! .hgtags

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-02-04 Thread coleen . phillimore
Changeset: 24a91505f9d5 Author:emc Date: 2013-02-04 13:05 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/24a91505f9d5 8006949: Update hotspot for MethodParameters format change 8006907: Hotspot should reject classfiles with multiple MethodParameters attributes Sum

hg: jdk8/tl/langtools: 8007492: DocumentationTool cannot locate standard doclet when invoked from JRE

2013-02-04 Thread jonathan . gibbons
Changeset: 62d91c13dce2 Author:jjg Date: 2013-02-04 18:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/62d91c13dce2 8007492: DocumentationTool cannot locate standard doclet when invoked from JRE Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/Javadoc

hg: jdk8/tl/jdk: 8007113: Upgrade AnnotatedElement.isAnnotionPresent to be a default method

2013-02-04 Thread joe . darcy
Changeset: e04467fa13af Author:darcy Date: 2013-02-04 17:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e04467fa13af 8007113: Upgrade AnnotatedElement.isAnnotionPresent to be a default method Reviewed-by: chegar, jfranck ! src/share/classes/java/lang/Class.java ! src/shar

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
On 2/4/13 4:17 PM, Coleen Phillimore wrote: Hi Dan, I think this version looks good. Thanks! From your other reply: On 2/4/2013 11:40 AM, Daniel D. Daugherty wrote: is present in the HSX-23.6, HSX-24, and HSX-25 versions of is_interesting_method_entry(), but is not used by the original ch

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
Thanks! Dan On 2/4/13 4:17 PM, Coleen Phillimore wrote: Comment looks good! Thanks! Coleen On 2/4/2013 5:09 PM, Daniel D. Daugherty wrote: On 2/4/13 2:48 PM, Coleen Phillimore wrote: Also the file, http://cr.openjdk.java.net/~dcubed/8007420-webrev/0-jdk8-tl/test/java/lang/instrument/R

hg: jdk8/tl/langtools: 8007490: NPE from DocumentationTool.run

2013-02-04 Thread jonathan . gibbons
Changeset: 1690928dc560 Author:jjg Date: 2013-02-04 15:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1690928dc560 8007490: NPE from DocumentationTool.run Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java ! test/tools/javadoc/api/basi

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Coleen Phillimore
Comment looks good! Thanks! Coleen On 2/4/2013 5:09 PM, Daniel D. Daugherty wrote: On 2/4/13 2:48 PM, Coleen Phillimore wrote: Also the file, http://cr.openjdk.java.net/~dcubed/8007420-webrev/0-jdk8-tl/test/java/lang/instrument/RedefineSubclassWithTwoInterfacesImpl_1.java.html Is exac

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Coleen Phillimore
Hi Dan, I think this version looks good. From your other reply: On 2/4/2013 11:40 AM, Daniel D. Daugherty wrote: is present in the HSX-23.6, HSX-24, and HSX-25 versions of is_interesting_method_entry(), but is not used by the original check_no_old_entries() or any of the new check_no_old_or

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread David Holmes
Correct - no JVM/TI and so no redefineClasses in the minimal VM. David On 5/02/2013 8:49 AM, Daniel D. Daugherty wrote: On 2/4/13 9:40 AM, Daniel D. Daugherty wrote: On 2/4/13 8:19 AM, Karen Kinnear wrote: Is redefineclasses supported in the MinimalVM? I don't know the answer to that. I ha

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
On 2/4/13 9:40 AM, Daniel D. Daugherty wrote: On 2/4/13 8:19 AM, Karen Kinnear wrote: Is redefineclasses supported in the MinimalVM? I don't know the answer to that. I have not been tracking the MinimalVM work. I'll investigate and get back to you. Karen, These two Makefiles: make/bsd

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
Thanks for the second review! Dan On 2/4/13 3:25 PM, serguei.spit...@oracle.com wrote: It looks good to me. I remember the test fix needs a review as well. Thanks, Serguei On 2/4/13 1:08 PM, Daniel D. Daugherty wrote: Greetings, I've updated the fix due to comments in Code Review Round 0

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread serguei.spit...@oracle.com
It looks good to me. I remember the test fix needs a review as well. Thanks, Serguei On 2/4/13 1:08 PM, Daniel D. Daugherty wrote: Greetings, I've updated the fix due to comments in Code Review Round 0. Here is a summary of changes made to the various files: src/share/vm/oops/cpCacheOop.cp

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
On 2/4/13 2:48 PM, Coleen Phillimore wrote: Also the file, http://cr.openjdk.java.net/~dcubed/8007420-webrev/0-jdk8-tl/test/java/lang/instrument/RedefineSubclassWithTwoInterfacesImpl_1.java.html Is exactly the same as the file RedefineSubclassWithTwoInterfacesImpl.java Isn't one suppose

hg: hsx/hotspot-rt/hotspot: 8000968: NPG: UseCompressedKlassPointers asserts with ObjectAlignmentInBytes for > 32G CompressedOops

2013-02-04 Thread harold . seigel
Changeset: 10d5f25a7c67 Author:hseigel Date: 2013-02-04 08:26 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10d5f25a7c67 8000968: NPG: UseCompressedKlassPointers asserts with ObjectAlignmentInBytes for > 32G CompressedOops Summary: Pick a base that works for both

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Coleen Phillimore
Ok, my poor eyes. One short comment below. On 2/4/2013 4:22 PM, Daniel D. Daugherty wrote: Thanks for the additional test comments. Replies embedded below. On 2/4/13 1:06 PM, Coleen Phillimore wrote: On 2/4/2013 12:19 PM, Daniel D. Daugherty wrote: Adding back dropped aliases and people..

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
Thanks for the additional test comments. Replies embedded below. On 2/4/13 1:06 PM, Coleen Phillimore wrote: On 2/4/2013 12:19 PM, Daniel D. Daugherty wrote: Adding back dropped aliases and people... I think I have all the aliases on this, this time. And the individual people also. Thanks!

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
Greetings, I've updated the fix due to comments in Code Review Round 0. Here is a summary of changes made to the various files: src/share/vm/oops/cpCacheOop.cpp (HSX-23.6, HSX-24) src/share/vm/oops/cpCache.cpp (HSX-25) src/share/vm/oops/klassVtable.cpp - removed the new RC_TRACE_NO_CR() macro

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Coleen Phillimore
On 2/4/2013 12:19 PM, Daniel D. Daugherty wrote: Adding back dropped aliases and people... I think I have all the aliases on this, this time. Thanks for reviewing the first test! Replies embedded below. Ok, now I see about the scaffolding framework for the first test. I can say it looks c

hg: jdk8/tl/jdk: 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream; ...

2013-02-04 Thread xueming . shen
Changeset: e202f43a8b8a Author:sherman Date: 2013-02-04 11:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e202f43a8b8a 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte strea

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
On 2/4/13 12:21 PM, serguei.spit...@oracle.com wrote: Dan, The fixes look good for all 3 HS versions (modulo discussions with Coleen and Karen). Great discovery, thank you for doing this! Thanks Serguei! I'm working on addressing Coleen's and Karen's comments and will be rolling out three

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread serguei.spit...@oracle.com
Dan, The fixes look good for all 3 HS versions (modulo discussions with Coleen and Karen). Great discovery, thank you for doing this! Thanks, Serguei On 2/1/13 11:55 AM, Daniel D. Daugherty wrote: Greetings, I have a fix for the following JVM/TI bug: 7182152 Instrumentation hot swap

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Coleen Phillimore
On 2/4/2013 12:26 PM, Daniel D. Daugherty wrote: On 2/4/13 10:16 AM, Coleen Phillimore wrote: On 2/4/2013 11:50 AM, Daniel D. Daugherty wrote: Thanks for the additional comment. Reply below. On 2/4/13 8:34 AM, Coleen Phillimore wrote: On 2/4/2013 10:15 AM, Daniel D. Daugherty wrote: Adding

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
On 2/4/13 10:16 AM, Coleen Phillimore wrote: On 2/4/2013 11:50 AM, Daniel D. Daugherty wrote: Thanks for the additional comment. Reply below. On 2/4/13 8:34 AM, Coleen Phillimore wrote: On 2/4/2013 10:15 AM, Daniel D. Daugherty wrote: Adding back the missing aliases and people... Sorry, I

hg: jdk8/tl/jdk: 8006994: Cleanup PKCS12 tests to ensure streams get closed

2013-02-04 Thread vincent . x . ryan
Changeset: 5bf1c9e6be60 Author:vinnie Date: 2013-02-04 17:20 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bf1c9e6be60 8006994: Cleanup PKCS12 tests to ensure streams get closed Reviewed-by: mullan ! test/java/security/KeyStore/PBETest.java ! test/sun/security/pkcs12/Store

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
Adding back dropped aliases and people... Thanks for reviewing the first test! Replies embedded below. On 2/4/13 8:09 AM, Coleen Phillimore wrote: On 2/1/2013 6:55 PM, Daniel D. Daugherty wrote: And here is the webrev for the new tests (relative to JDK8-T&L): http://cr.openjdk.java.net/~dcub

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Coleen Phillimore
On 2/4/2013 11:50 AM, Daniel D. Daugherty wrote: Thanks for the additional comment. Reply below. On 2/4/13 8:34 AM, Coleen Phillimore wrote: On 2/4/2013 10:15 AM, Daniel D. Daugherty wrote: Adding back the missing aliases and people... Sorry, I meant to send this re-all. I missed something

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
Thanks for the additional comment. Reply below. On 2/4/13 8:34 AM, Coleen Phillimore wrote: On 2/4/2013 10:15 AM, Daniel D. Daugherty wrote: Adding back the missing aliases and people... Sorry, I meant to send this re-all. I missed something major in my earlier review. The metadata->is_val

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
Karen, Thanks for the reviews! Replies embedded below. On 2/4/13 8:19 AM, Karen Kinnear wrote: Dan, All 3 versions of the code looks good. Thank you for enabling the printing for product since this type of problem is so hard to duplicate. You're welcome. A small note, I think it would

Re: RFR (S): 8004172: Update jstat counter names to reflect metaspace changes

2013-02-04 Thread Erik Helin
There have been some updates to the hotspot code based on feedback from the hotspot-gc-dev mailing list. The only change to the JDK code is that the namespace is back to "sun.gc" :) New webrevs: - jdk: http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.03/ - hotspot: http://cr.openjdk.java.n

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Coleen Phillimore
On 2/4/2013 10:15 AM, Daniel D. Daugherty wrote: Adding back the missing aliases and people... Sorry, I meant to send this re-all. I missed something major in my earlier review. The metadata->is_valid() flag should only be enabled in debug mode. It adds a word to all metadata. Coleen, T

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Karen Kinnear
Dan, All 3 versions of the code looks good. Thank you for enabling the printing for product since this type of problem is so hard to duplicate. A small note, I think it would have been easier for the internal code logic for the CPCE::check_no_old_or_obsolete_entries to reverse the true/false, bu

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-04 Thread Daniel D. Daugherty
Adding back the missing aliases and people... Coleen, Thanks for the review. Replies embedded below. On 2/4/13 7:26 AM, Coleen Phillimore wrote: On 2/1/2013 6:55 PM, Daniel D. Daugherty wrote: And here is the webrev for the new tests (relative to JDK8-T&L): http://cr.openjdk.java.net/~dcub

Re: RFR (S) 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-02-04 Thread Alan Bateman
On 04/02/2013 11:03, Yekaterina Kantserova wrote: But JDKToolFinder.getJDKTool is used even for finding java, e.g. I need to fork a java process - JDKToolFinder.getJDKTool("java") for some JRE tests? It might be better to rename JDKToolFinder to something like JdkFinder and have it define get

Re: RFR (S) 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-02-04 Thread Yekaterina Kantserova
On 02/04/2013 11:55 AM, Alan Bateman wrote: On 04/02/2013 10:33, Yekaterina Kantserova wrote: No, it was a bad example. Let's take another one: /java -jar jtreg.jar -jdk MONKEY -compilejdk LION test.java/ In this case JDKToolFinder.getJDKTool("jcmd") will return LION/bin/jcmd, but I need to

Re: RFR (S) 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-02-04 Thread Alan Bateman
On 04/02/2013 10:33, Yekaterina Kantserova wrote: No, it was a bad example. Let's take another one: /java -jar jtreg.jar -jdk MONKEY -compilejdk LION test.java/ In this case JDKToolFinder.getJDKTool("jcmd") will return LION/bin/jcmd, but I need to test MONKEY/bin/jcmd. The -compilejdk option

Re: RFR (S) 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-02-04 Thread Yekaterina Kantserova
On 02/01/2013 04:18 PM, Alan Bateman wrote: On 01/02/2013 15:06, Yekaterina Kantserova wrote: Thanks for explanation! But I'm still confused. In my use case I need to test /_the tool_/ I'll find with JDKToolFinder. It will work if just -jdk will be specified. But if -compilejdk happens to be

Re: hg: jdk8/tl/jdk: 8002048: Protocol to discovery of manageable Java processes on a network

2013-02-04 Thread Alan Bateman
Dmitry - the test doesn't compile/run with jtreg, was it tested before you pushed this? -Alan On 03/02/2013 17:40, dmitry.samers...@oracle.com wrote: Changeset: 962d6612cace Author:dsamersoff Date: 2013-02-03 21:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/962d6612