hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-02-05 Thread coleen . phillimore
Changeset: ab826603e572 Author:simonis Date: 2013-02-04 13:14 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ab826603e572 8007475: Memory stomp with UseMallocOnly Summary: Fix off-by-one error Reviewed-by: coleenp, hseigel ! src/share/vm/classfile/stackMapFrame.hp

Re: RFR (S) 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-02-05 Thread Yekaterina Kantserova
On 02/04/2013 02:18 PM, Alan Bateman wrote: On 04/02/2013 11:03, Yekaterina Kantserova wrote: But JDKToolFinder.getJDKTool is used even for finding java, e.g. I need to fork a java process - JDKToolFinder.getJDKTool("java") for some JRE tests? It might be better to rename JDKToolFinder to som

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-02-05 Thread david . holmes
Changeset: 12285410684f Author:dholmes Date: 2013-02-04 23:53 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/12285410684f 8006508: Wrong frame constructor is called in os_linux_x86.cpp Reviewed-by: dholmes, coleenp Contributed-by: Jeremy Manson ! src/os_cpu/bsd_x

hg: jdk8/tl/jdk: 7170447: Intermittent DeadListenerTest.java failure

2013-02-05 Thread jaroslav . bachorik
Changeset: 9ffcd758e2be Author:jbachorik Date: 2013-02-05 12:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ffcd758e2be 7170447: Intermittent DeadListenerTest.java failure Summary: Due to asynchronous nature of processing server notifications it may happen that an "unreg

hg: jdk8/tl/jdk: 8005791: Remove java.beans.* imports from com.sun.jmx.mbeanserver.Introspector

2013-02-05 Thread jaroslav . bachorik
Changeset: 3119f0ebb58d Author:jbachorik Date: 2013-02-05 12:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3119f0ebb58d 8005791: Remove java.beans.* imports from com.sun.jmx.mbeanserver.Introspector Reviewed-by: rbackman ! src/share/classes/com/sun/jmx/mbeanserver/Intros

Re: RFR (S) 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-02-05 Thread Alan Bateman
On 05/02/2013 10:51, Yekaterina Kantserova wrote: On 02/04/2013 02:18 PM, Alan Bateman wrote: On 04/02/2013 11:03, Yekaterina Kantserova wrote: But JDKToolFinder.getJDKTool is used even for finding java, e.g. I need to fork a java process - JDKToolFinder.getJDKTool("java") for some JRE tests

hg: jdk8/tl/jdk: 8007483: attributes are ignored when loading keys from a PKCS12 keystore

2013-02-05 Thread vincent . x . ryan
Changeset: e526277b51be Author:vinnie Date: 2013-02-05 14:25 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e526277b51be 8007483: attributes are ignored when loading keys from a PKCS12 keystore Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java !

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-02-05 Thread Jaroslav Bachorik
Updates in http://cr.openjdk.java.net/~jbachorik/8005472/webrev.05 Comments inline On 01/10/2013 10:44 PM, Stuart Marks wrote: > On 1/10/13 7:20 AM, Jaroslav Bachorik wrote: >> Update: http://cr.openjdk.java.net/~jbachorik/8005472/webrev.04 > > Thanks for the update. > > Note, argv[0] is used b

hg: jdk8/tl/jaxp: 8007389: Remove uses of _ as identifier in jaxp

2013-02-05 Thread alan . bateman
Changeset: f0ad3747b40e Author:emc Date: 2013-02-05 14:56 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f0ad3747b40e 8007389: Remove uses of _ as identifier in jaxp Reviewed-by: lancea, joehw ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFa

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-05 Thread serguei.spit...@oracle.com
Both tests look good, I do not see any issues yet. What is missed is a comment explaining what happened when the bug is not fixed and what correct behavior is expected. Maybe it'd make sense to put bad and good output into the comment, not everything, but the most important fragments. It would hel

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-05 Thread Daniel D. Daugherty
On 2/5/13 10:50 AM, serguei.spit...@oracle.com wrote: Both tests look good, I do not see any issues yet. What is missed is a comment explaining what happened when the bug is not fixed and what correct behavior is expected. Maybe it'd make sense to put bad and good output into the comment, not eve

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-05 Thread serguei.spit...@oracle.com
On 2/5/13 10:03 AM, Daniel D. Daugherty wrote: On 2/5/13 10:50 AM, serguei.spit...@oracle.com wrote: Both tests look good, I do not see any issues yet. What is missed is a comment explaining what happened when the bug is not fixed and what correct behavior is expected. Maybe it'd make sense to p

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-05 Thread Karen Kinnear
New versions look great. Thank you. For jdk8 only - is redefineclasses in the MINIMALVM? I missed your reply. If so, I was assuming that the additional tracing would also be conditional in the builds. I believe in addition to ifdef's there is a list of files not included in MINIMALVM, but I didn'

Re: RFR (S): 8004172: Update jstat counter names to reflect metaspace changes

2013-02-05 Thread Mandy Chung
Hi Erik, On 2/4/13 8:01 AM, Erik Helin wrote: There have been some updates to the hotspot code based on feedback from the hotspot-gc-dev mailing list. The only change to the JDK code is that the namespace is back to "sun.gc" :) New webrevs: - jdk:http://cr.openjdk.java.net/~ehelin/8004172/jdk/w

Re: RFR (S): 8004172: Update jstat counter names to reflect metaspace changes

2013-02-05 Thread Mandy Chung
Also, the jstat man page needs to be updated per this change (I mentioned this in the previous review [1]) http://download.java.net/jdk8/docs/technotes/tools/share/jstat.html You can contact the docs team for this. Mandy [1] http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-January

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-05 Thread Daniel D. Daugherty
On 2/5/13 12:56 PM, Karen Kinnear wrote: New versions look great. Thank you. Thanks! For jdk8 only - is redefineclasses in the MINIMALVM? I missed your reply. If so, I was assuming that the additional tracing would also be conditional in the builds. I believe in addition to ifdef's there is

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-02-05 Thread Stuart Marks
Hi, thanks for the updates. Capturing the Client output in a file seems preferable to putting a shell pipeline in backquotes. But, the old code piped both stdout and stderr into grep using 2>&1, whereas the new code redirects only stdout, which is then searched by grep. Was that intentional? I

hg: jdk8/tl/langtools: 8007485: test creates .class files in the test/ directory

2013-02-05 Thread jonathan . gibbons
Changeset: de932285124c Author:jjg Date: 2013-02-05 21:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de932285124c 8007485: test creates .class files in the test/ directory Reviewed-by: mcimadamore ! test/tools/javac/api/8007344/Test.java

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-05 Thread Daniel D. Daugherty
Greetings, The JPDA stack testing finished with no new regressions on HSX-23.6, HSX-24 or HSX-25. The HSX-24 version of the fix has been pushed. I've updated the HSX-25 version of the fix due to Karen's comments about the MinimalVM configuration in Code Review Round 1. In this latest round for H