hg: hsx/hotspot-rt/hotspot: 7182152: Instrumentation hot swap test incorrect monitor count

2013-02-06 Thread daniel . daugherty
Changeset: 8d9fc28831cc Author:dcubed Date: 2013-02-06 14:31 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8d9fc28831cc 7182152: Instrumentation hot swap test incorrect monitor count Summary: Add/refine new tracing support using -XX:TraceRedefineClasses=16384. Rev

hg: jdk8/tl/jdk: 8006995: java launcher fails to open executable JAR > 2GB

2013-02-06 Thread martinrb
Changeset: 2f1505c49e79 Author:martin Date: 2013-02-06 17:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f1505c49e79 8006995: java launcher fails to open executable JAR > 2GB Summary: Use O_LARGEFILE consistently when opening jar files Reviewed-by: alanb, sherman ! src/s

Re: RR(S): 8007536 Incorrect copyright header in JDP files

2013-02-06 Thread Mikael Vidstedt
Looks good. Cheers, Mikael On 2013-02-06 06:05, Dmitry Samersoff wrote: Hi Everyone, Please, review this, copyright-only fix http://cr.openjdk.java.net/~dsamersoff/8007536.JDP-COPYRIGHT/webrev.01/jdk/ -Dmitry

hg: jdk8/tl/langtools: 8007698: jtreg test T6306137.java won't compile with ASCII encoding

2013-02-06 Thread james . holmlund
Changeset: b386b8c45387 Author:jjh Date: 2013-02-06 23:10 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b386b8c45387 8007698: jtreg test T6306137.java won't compile with ASCII encoding Reviewed-by: ksrini ! test/tools/javac/api/T6306137.java

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-06 Thread Daniel D. Daugherty
Thanks Serguei! Dan On 2/6/13 1:22 PM, serguei.spit...@oracle.com wrote: Looks good. Thanks, Serguei On 2/6/13 11:54 AM, Karen Kinnear wrote: Thank you Dan - this is much better and sets a good model for the rest of us. thanks, Karen On Feb 6, 2013, at 9:05 AM, Daniel D. Daugherty wrote:

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-06 Thread serguei.spit...@oracle.com
Already reviewed. :) It is good. Thanks, Serguei On 2/6/13 12:09 PM, Daniel D. Daugherty wrote: Karen, Thanks for the re-review! Serguei, just waiting for you to chime in!! Dan On 2/6/13 12:54 PM, Karen Kinnear wrote: Thank you Dan - this is much better and sets a good model for the rest

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-06 Thread serguei.spit...@oracle.com
Looks good. Thanks, Serguei On 2/6/13 11:54 AM, Karen Kinnear wrote: Thank you Dan - this is much better and sets a good model for the rest of us. thanks, Karen On Feb 6, 2013, at 9:05 AM, Daniel D. Daugherty wrote: Adding other alias and people back onto the thread... Thanks for the re-re

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-06 Thread Daniel D. Daugherty
Karen, Thanks for the re-review! Serguei, just waiting for you to chime in!! Dan On 2/6/13 12:54 PM, Karen Kinnear wrote: Thank you Dan - this is much better and sets a good model for the rest of us. thanks, Karen On Feb 6, 2013, at 9:05 AM, Daniel D. Daugherty wrote: Adding other alias

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-06 Thread Daniel D. Daugherty
Greetings, I've revised the tests based on Coleen's and Serguei's feedback in Code Review Round 0. Here is the URL for the webrev for Code Review Round 1: http://cr.openjdk.java.net/~dcubed/8007420-webrev/1-jdk8-tl/ Summary of the changes: - RedefineAbstractClass.sh - cleaned up the header co

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-06 Thread Karen Kinnear
Thank you Dan - this is much better and sets a good model for the rest of us. thanks, Karen On Feb 6, 2013, at 9:05 AM, Daniel D. Daugherty wrote: > Adding other alias and people back onto the thread... > > Thanks for the re-review! > > > On 2/6/13 6:41 AM, Coleen Phillimore wrote: >> >> Thi

hg: jdk8/tl/jdk: 8006505: additional changes for JSR 310 support

2013-02-06 Thread lance . andersen
Changeset: 1574fa3df1c0 Author:lancea Date: 2013-02-06 14:15 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1574fa3df1c0 8006505: additional changes for JSR 310 support Reviewed-by: naoto, ulfzibis ! src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/SQLIn

hg: jdk8/tl: 8004726: Link bug ids to jbs rather than monaco.

2013-02-06 Thread mike . duigou
Changeset: 168dd033604a Author:mduigou Date: 2013-02-06 11:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/168dd033604a 8004726: Link bug ids to jbs rather than monaco. Reviewed-by: ohair, chegar, katleman ! make/scripts/webrev.ksh

Re: 8007277: JDK-8002048 testcase fails to compile

2013-02-06 Thread Dmitry Samersoff
Mandy, The test designed to leave as much as possible to JTReg but work without JTRreg as well. so if test run under JTReg, --no-compile option used and test is compiled by JTReg it requires both @compile header tag and explicit compilation code. Actual changes contains a comment explaining it.

hg: jdk8/tl/langtools: 8007566: DocLint too aggressive with not allowed here:

2013-02-06 Thread jonathan . gibbons
Changeset: 153d20d0cac5 Author:jjg Date: 2013-02-06 07:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/153d20d0cac5 8007566: DocLint too aggressive with not allowed here: Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/do

Re: 8007277: JDK-8002048 testcase fails to compile

2013-02-06 Thread Mandy Chung
On 2/6/2013 2:47 AM, Alan Bateman wrote: diff --git a/test/sun/management/jdp/JdpTest.sh b/test/sun/management/jdp/JdpTest.sh --- a/test/sun/management/jdp/JdpTest.sh +++ b/test/sun/management/jdp/JdpTest.sh @@ -23,7 +23,7 @@ # @test # @bug 7169888 -# @build JdpUnitTest JdpClient JdpDoSome

Re: RFR (S) 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-02-06 Thread Yekaterina Kantserova
Alan, thanks for the review! // Katja On 02/05/2013 12:54 PM, Alan Bateman wrote: On 05/02/2013 10:51, Yekaterina Kantserova wrote: On 02/04/2013 02:18 PM, Alan Bateman wrote: On 04/02/2013 11:03, Yekaterina Kantserova wrote: But JDKToolFinder.getJDKTool is used even for finding java, e.g.

hg: jdk8/tl/langtools: 2 new changesets

2013-02-06 Thread maurizio . cimadamore
Changeset: 1df20330f6bd Author:mcimadamore Date: 2013-02-06 14:03 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1df20330f6bd 8007463: Cleanup inference related classes Summary: Make Infer.InferenceContext an inner class; adjust bound replacement logic in Type.UndetVar

RR(S): 8007536 Incorrect copyright header in JDP files

2013-02-06 Thread Dmitry Samersoff
Hi Everyone, Please, review this, copyright-only fix http://cr.openjdk.java.net/~dsamersoff/8007536.JDP-COPYRIGHT/webrev.01/jdk/ -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer

Re: JVM/TI code review request (XS and M) (7182152)

2013-02-06 Thread Daniel D. Daugherty
Adding other alias and people back onto the thread... Thanks for the re-review! On 2/6/13 6:41 AM, Coleen Phillimore wrote: This is good that you added the INCLUDE_JVMTI. I didn't think it'd add that much space, but it a good change. I didn't think it would add much space either, but...

hg: jdk8/tl/jdk: 8007277: JDK-8002048 testcase fails to compile

2013-02-06 Thread dmitry . samersoff
Changeset: 0e7d5dd84fdf Author:dsamersoff Date: 2013-02-06 16:53 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e7d5dd84fdf 8007277: JDK-8002048 testcase fails to compile Summary: sun.* classes is not included to ct.sym file and symbol file have to be ignored Reviewed-by: a

Re: RR(S) Re: 8007277: JDK-8002048 testcase fails to compile

2013-02-06 Thread Alan Bateman
On 06/02/2013 12:28, Dmitry Samersoff wrote: Hi Everyone, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/8007277.JDP-TEST/webrev.01/jdk/ -Dmitry This looks fine to me (and good to get this one fixed as it is failing everywhere since the original changes were pushed). -Alan

RR(S) Re: 8007277: JDK-8002048 testcase fails to compile

2013-02-06 Thread Dmitry Samersoff
Hi Everyone, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/8007277.JDP-TEST/webrev.01/jdk/ -Dmitry On 2013-02-06 14:47, Alan Bateman wrote: > > Dmitry - I realize you might be looking at this already but > test/sun/management/jdp/JdpTest.sh is failing on all platforms since it

Re: 8007277: JDK-8002048 testcase fails to compile

2013-02-06 Thread Dmitry Samersoff
Alan, Thank you! I plan to fix it shortly. -Dmitry On 2013-02-06 14:47, Alan Bateman wrote: > > Dmitry - I realize you might be looking at this already but > test/sun/management/jdp/JdpTest.sh is failing on all platforms since it > was pushed. We can either put it on the exclude list (ProblemLi

hg: jdk8/tl: 8007625: race with nested repos in /common/bin/hgforest.sh

2013-02-06 Thread chris . hegarty
Changeset: 8dd61906da5f Author:chegar Date: 2013-02-06 11:36 + URL: http://hg.openjdk.java.net/jdk8/tl/rev/8dd61906da5f 8007625: race with nested repos in /common/bin/hgforest.sh Reviewed-by: dholmes, ohair, ohrstrom ! common/bin/hgforest.sh ! get_source.sh

8007277: JDK-8002048 testcase fails to compile

2013-02-06 Thread Alan Bateman
Dmitry - I realize you might be looking at this already but test/sun/management/jdp/JdpTest.sh is failing on all platforms since it was pushed. We can either put it on the exclude list (ProblemList.txt) or fix it. Since it is trivial to fix then I'd like to do that - attached is the proposed

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-02-06 Thread Jaroslav Bachorik
On 02/05/2013 11:47 PM, Stuart Marks wrote: > Hi, thanks for the updates. > > Capturing the Client output in a file seems preferable to putting a > shell pipeline in backquotes. But, the old code piped both stdout and > stderr into grep using 2>&1, whereas the new code redirects only stdout, > whi