On 02/07/2013 12:02 PM, Dmitry Samersoff wrote:
Florian,
I can submit a request to IANA if you prefer, but I don't know what
the turn-around time will be.
Official IANA assignment would benefit everybody and your help is much
appreciated.
So please submit IANA request.
I filled out the por
Florian,
Thank you for doing it. I'll check with client team what is better for
them.
-Dmitry
On 2013-02-11 14:28, Florian Weimer wrote:
> On 02/07/2013 12:02 PM, Dmitry Samersoff wrote:
>> Florian,
>>
>>> I can submit a request to IANA if you prefer, but I don't know what
>>> the turn-around t
Hi Everybody,
Please review a test bug:
Summary:
Built in test function of Solaris /bin/sh doesn't have -e operator and
doesn't allow a variable and a function with the same name.
Webrev:
http://cr.openjdk.java.net/~dsamersoff/8007786.JDP-TEST2/webrev.01/jdk/
-Dmitry
--
Dmitry Samersoff
Ora
Changeset: 1df991184045
Author:dsamersoff
Date: 2013-02-11 18:44 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1df991184045
8007536: Incorrect copyright header in JDP files
Summary: Copyright header in JDP files missed the "classpath exception" rule.
Reviewed-by: mikael
! s
Greetings,
I've revised one of the tests to make it more portable based
on JPRT test results for the Code Review Round 1 version.
Here is the URL for the webrev for Code Review Round 2:
http://cr.openjdk.java.net/~dcubed/8007420-webrev/2-jdk8-tl/
Summary of the changes:
- RedefineSubclassWith
Looks good, although I was surprised you don't need -e.
Coleen
On 02/11/2013 10:05 AM, Daniel D. Daugherty wrote:
Greetings,
I've revised one of the tests to make it more portable based
on JPRT test results for the Code Review Round 1 version.
Here is the URL for the webrev for Code Review R
On 2/11/13 8:34 AM, Coleen Phillimore wrote:
Looks good, although I was surprised you don't need -e.
Thanks for the review!
If you only have a single edit cmd, then '-e' is not needed.
Dan
Coleen
On 02/11/2013 10:05 AM, Daniel D. Daugherty wrote:
Greetings,
I've revised one of the tes
Looks good.
Thanks,
Serguei
On 2/11/13 7:05 AM, Daniel D. Daugherty wrote:
Greetings,
I've revised one of the tests to make it more portable based
on JPRT test results for the Code Review Round 1 version.
Here is the URL for the webrev for Code Review Round 2:
http://cr.openjdk.java.net/~dcu
Thanks for another re-review!
Dan
On 2/11/13 10:28 AM, serguei.spit...@oracle.com wrote:
Looks good.
Thanks,
Serguei
On 2/11/13 7:05 AM, Daniel D. Daugherty wrote:
Greetings,
I've revised one of the tests to make it more portable based
on JPRT test results for the Code Review Round 1 versi
Changeset: abd530253f01
Author:dcubed
Date: 2013-02-11 10:07 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abd530253f01
8007420: add test for 6805864 to com/sun/jdi, add test for 7182152 to
java/lang/instrument
Reviewed-by: coleenp, sspitsyn
+ test/com/sun/jdi/RedefineAbst
Nasty, so normally the code picks up the value from the VMIntConstant
vmstructs array which is the hardcoded default value, but with this fix
it's picked up from the command line options database which reflects the
actual current value. That makes sense and looks good.
Cheers,
Mikael
On 201
Yes, you got it right.
Thanks,
/Staffan
On 11 feb 2013, at 19:45, Mikael Vidstedt wrote:
>
> Nasty, so normally the code picks up the value from the VMIntConstant
> vmstructs array which is the hardcoded default value, but with this fix it's
> picked up from the command line options database
Changeset: f21a4b761424
Author:alanb
Date: 2013-02-11 20:16 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f21a4b761424
8007405: Update java.lang.reflect API to replace SYNTHESIZED with MANDATED
Reviewed-by: darcy
! src/share/classes/java/lang/reflect/Executable.java
! src/s
Changeset: 927a311d00f9
Author:coleenp
Date: 2013-02-11 14:06 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/927a311d00f9
8007320: NPG: move method annotations
Summary: allocate method annotations and attach to ConstMethod if present
Reviewed-by: dcubed, jiangli, s
Changeset: 01af1b5c631d
Author:darcy
Date: 2013-02-11 13:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/01af1b5c631d
8007574: Provide isFunctionalInterface in javax.lang.model
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/model/JavacElements.java
! src/sh
On 10/02/2013 5:06 AM, Staffan Larsen wrote:
Please review this small patch to avoid reading flag values in SA as constants.
Reading them as constants means SA will only see the default value for these
flags. Instead the infrastructure in SA to read command line flags should be
used. In addit
Greetings,
Right after I pushed the changeset for 8007420, Alan B let me know that
he had updated the JLI/JPLIS test infrastructure to support running the
tests with a JRE instead of a JDK. Alan made his changes in early January,
but I had developed this test back in December. I never checked to
This looks good.
BTW, the bug report links in the webrev are not resolved.
It was not a big problem for me, just wanted to let you know.
Thanks,
Serguei
On 2/11/13 4:41 PM, Daniel D. Daugherty wrote:
Greetings,
Right after I pushed the changeset for 8007420, Alan B let me know that
he had up
Serguei,
Thanks for the fast review!
I fixed the broken JBS link, but I can't do anything about getting
the bugs.sun.com entry out any faster. Sigh...
Dan
On 2/11/13 6:14 PM, serguei.spit...@oracle.com wrote:
This looks good.
BTW, the bug report links in the webrev are not resolved.
It was
Changeset: 465cce29a9ed
Author:mduigou
Date: 2013-02-06 11:28 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/465cce29a9ed
8006594: Add jdk_core target to jdk/test/Makefile
Reviewed-by: alanb
! make/jprt.properties
! test/Makefile
! test/ProblemList.txt
Changeset: 7817368287cd
Author:mduigou
Date: 2013-02-06 11:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/7817368287cd
8006595: Use jdk/test/Makefile targets in preference to local definitions
Reviewed-by: alanb
! common/makefiles/Main.gmk
! test/Makefile
21 matches
Mail list logo
