hg: jdk8/tl: 3 new changesets

Changeset: 45d6d221 Author:katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/45d6d221 Added tag jdk8-b77 for changeset 3933eebc659d ! .hgtags Changeset: bbb7548d45c7 Author:lana Date: 2013-02-14 22:11 -0800 URL: http://hg.open

hg: jdk8/tl/jaxp: Added tag jdk8-b77 for changeset 573e789c187a

Changeset: 00958c5a7070 Author:katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/00958c5a7070 Added tag jdk8-b77 for changeset 573e789c187a ! .hgtags

hg: jdk8/tl/hotspot: 36 new changesets

Changeset: 1f84c84f8e1a Author:katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1f84c84f8e1a Added tag jdk8-b77 for changeset cdb46031e718 ! .hgtags Changeset: 1a0174612b49 Author:amurillo Date: 2013-02-08 08:16 -0800 URL: ht

hg: jdk8/tl/jaxws: Added tag jdk8-b77 for changeset 64dfba1bad16

Changeset: 391de4c992d1 Author:katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/391de4c992d1 Added tag jdk8-b77 for changeset 64dfba1bad16 ! .hgtags

hg: jdk8/tl/langtools: 3 new changesets

Changeset: bc24411bcc37 Author:katleman Date: 2013-02-14 11:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bc24411bcc37 Added tag jdk8-b77 for changeset 89c664151689 ! .hgtags Changeset: a3aa32fe4536 Author:lana Date: 2013-02-14 22:11 -0800 URL: http

hg: jdk8/tl/corba: 2 new changesets

Changeset: 27d6368ae8ba Author:katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/27d6368ae8ba Added tag jdk8-b77 for changeset 35684a40c584 ! .hgtags Changeset: c528d8ce83f1 Author:lana Date: 2013-02-19 20:48 -0800 URL: http://h

Re: Code Review fix for 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly

David, Thanks for the review! I had previously done a code history analysis for the offending code block as an example for Ron on how that is done in this crazy multi source code control system we call Java... Yes, this went from Mercurial back into TeamWare and I had to find the old rt_baseline

Re: Code Review fix for 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly

Okay full disclosure. :) I filed this bug back in 2009 so I undoubtedly ran into a failure where this guard was causing the useful error information to be lost, and so I filed the bug. Now I am so much older and wiser I'm wondering about the original reason for the guard again. ;-) David On

Re: Code Review fix for 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly

The one-reporter only logic in report_and_die has been there for a very long time, pre-dating the addition of the check in report_vm_out_of_memory. So I have to wonder what prompted the inclusion of that guard originally? No doubt there was some failure case where we were getting recursive erro

Re: RFR(XXS): 8007147: Trace event ExecuteVMOperation may get dangling pointer

On 20/02/2013 5:30 AM, Dean Long wrote: On 2/19/2013 11:00 AM, Staffan Larsen wrote: On 19 feb 2013, at 19:56, Dean Long mailto:dean.l...@oracle.com>> wrote: When the VM_Operation is created, we could take a snapshot of the thread_id of the caller, then use that later. One problem with that

hg: jdk8/tl/langtools: 8006948: Update javac for MethodParameters format change

Changeset: 9345394ac8fe Author:ksrini Date: 2013-02-19 17:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9345394ac8fe 8006948: Update javac for MethodParameters format change Reviewed-by: ksrini, forax Contributed-by: eric.mccor...@oracle.com ! src/share/classes/com

hg: jdk8/tl/jdk: 8008262: pack200 should support MethodParameters - part 2

Changeset: ec1a79c3a99c Author:ksrini Date: 2013-02-19 16:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec1a79c3a99c 8008262: pack200 should support MethodParameters - part 2 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/cla

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

Thanks Nils. Looks good to me too. David On 19/02/2013 10:52 PM, Nils Loodin wrote: Here's the updated webrev: http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/ Regards, Nils Loodin On 02/19/2013 12:09 PM, Nils Loodin wrote: On 02/09/2013 03:13 AM, David Holmes wrote: On 9/02/2013 2:4

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 56c364daccc3 Author:emc Date: 2013-02-19 11:36 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/56c364daccc3 8007153: Ensure that MethodParameters API works properly with RedefineClasses Summary: Adds code to HotSpot to properly update MethodParameter attr

Re: Code Review fix for 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly

For the record, "thumbs up". > http://cr.openjdk.java.net/~dcubed/for_rdurbin/6799919-webrev/0-hsx25 src/share/vm/utilities/debug.cpp No comments. Dan On 2/19/13 4:48 PM, Daniel D. Daugherty wrote: Greetings, I'm sponsoring this code review request from Ron Durbin. This change is targete

Code Review fix for 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly

Greetings, I'm sponsoring this code review request from Ron Durbin. This change is targeted at JDK8/HSX-25 in the RT_Baseline repo. Dan I have a proposed fix for the following bug: 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly http://bugs.sun.com/bugdata

hg: jdk8/tl/jdk: 8008107: [parfait] Use after free of pointer in jdk/src/share/native/sun/security/pkcs11/wrapper/p11_convert.c

Changeset: 267bca6af07e Author:jzavgren Date: 2013-02-19 15:31 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/267bca6af07e 8008107: [parfait] Use after free of pointer in jdk/src/share/native/sun/security/pkcs11/wrapper/p11_convert.c Reviewed-by: mullan, chegar ! src/share/

hg: jdk8/tl/jdk: 8004561: Additional functional interfaces, extension methods and name changes

Changeset: 16efb7ba188f Author:mduigou Date: 2013-02-19 11:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16efb7ba188f 8004561: Additional functional interfaces, extension methods and name changes Summary: Adds additional functional interfaces for primitives and "Bi" (two

Re: RFR(XXS): 8007147: Trace event ExecuteVMOperation may get dangling pointer

On 2/19/2013 11:00 AM, Staffan Larsen wrote: On 19 feb 2013, at 19:56, Dean Long > wrote: When the VM_Operation is created, we could take a snapshot of the thread_id of the caller, then use that later. One problem with that is if the thread_id gets reused for a

Re: RFR(XXS): 8007147: Trace event ExecuteVMOperation may get dangling pointer

I agree, it's better to emit 0, which we have used as "not available" in other events. Erik Staffan Larsen skrev 2013-02-19 10:59: I don't like this solution since we are swallowing information that could potentially be interesting (that a VMOperation happened). I think it's fine to say that

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

Looks good. /Staffan On 19 feb 2013, at 13:52, Nils Loodin wrote: > Here's the updated webrev: > > http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/ > > Regards, > Nils Loodin > > On 02/19/2013 12:09 PM, Nils Loodin wrote: >> On 02/09/2013 03:13 AM, David Holmes wrote: >>> On 9/02/2013

Re: RFR(XXS): 8007147: Trace event ExecuteVMOperation may get dangling pointer

On 19 feb 2013, at 19:56, Dean Long wrote: > When the VM_Operation is created, we could take a snapshot of the thread_id > of the caller, then use that later. One problem with that is if the thread_id gets reused for a new thread quickly after the old thread terminates. This is perhps ulikely

Re: RFR(XXS): 8007147: Trace event ExecuteVMOperation may get dangling pointer

When the VM_Operation is created, we could take a snapshot of the thread_id of the caller, then use that later. Or we could block the creating thread from fully exiting until the VM op executes. dl On 2/19/2013 1:59 AM, Staffan Larsen wrote: I don't like this solution since we are swallowing

Re: hg: jdk8/tl/langtools: 8006212: javac, convert jtreg tests from shell script to java

Woohoo -- 23 shell tests replaced with equivalent Java code: that's over 2/3 of the shell tests in langtools/test. -- Jon On 02/19/2013 09:54 AM, vicente.rom...@oracle.com wrote: Changeset: dc8b7aa7cef3 Author:vromero Date: 2013-02-19 17:53 + URL: http://hg.openjdk.java.net/

hg: jdk8/tl/jdk: 7092447: Clarify the default locale used in each locale sensitive operation

Changeset: af396ec087f4 Author:naoto Date: 2013-02-19 10:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af396ec087f4 7092447: Clarify the default locale used in each locale sensitive operation Reviewed-by: okutsu ! src/share/classes/java/text/DateFormat.java ! src/share/c

hg: hsx/hotspot-rt/hotspot: 6749267: Signal handler should save/restore errno

Changeset: 5cd2fac2ae70 Author:hseigel Date: 2013-02-19 08:51 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5cd2fac2ae70 6749267: Signal handler should save/restore errno Summary: Save errno before processing signal, then restore it. Reviewed-by: acorn, sspitsyn

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

Looks good. Thanks, Serguei On 2/19/13 4:52 AM, Nils Loodin wrote: Here's the updated webrev: http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/ Regards, Nils Loodin On 02/19/2013 12:09 PM, Nils Loodin wrote: On 02/09/2013 03:13 AM, David Holmes wrote: On 9/02/2013 2:40 AM, Nils Loodin

hg: jdk8/tl/jdk: 8008312: Re-enable MethodParameter tests in JDK

Changeset: e20c1c9197bf Author:emc Date: 2013-02-19 17:09 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e20c1c9197bf 8008312: Re-enable MethodParameter tests in JDK Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Parameter.java ! test/java/lang/reflect/Parameter/Wi

hg: jdk8/tl/jdk: 8007609: WinNTFileSystem_md.c should correctly check value returned from realloc

Changeset: 824187de1591 Author:jzavgren Date: 2013-02-19 16:19 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/824187de1591 8007609: WinNTFileSystem_md.c should correctly check value returned from realloc Reviewed-by: alanb, chegar, dholmes ! src/windows/native/java/io/WinNTF

Re: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()

On 13/02/2013 09:47, Yekaterina Kantserova wrote: Hi everyone, This small fixconcerns jdk.testlibrary.JdkFinder utility class. The check below is too OS dependent and should be deleted. ... binPath += File.separatorChar + "bin" + File.separatorChar + executable; File toolFile

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 885bb24f6018 Author:coffeys Date: 2013-02-19 14:07 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/885bb24f6018 7197187: Currency.isPastCutoverDate should be made more robust Reviewed-by: alanb ! src/share/classes/java/util/Currency.java Changeset: 01b6b0dd2006 Au

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

Here's the updated webrev: http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/ Regards, Nils Loodin On 02/19/2013 12:09 PM, Nils Loodin wrote: On 02/09/2013 03:13 AM, David Holmes wrote: On 9/02/2013 2:40 AM, Nils Loodin wrote: Please review the following very small and insignificant chan

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

On 02/09/2013 03:13 AM, David Holmes wrote: On 9/02/2013 2:40 AM, Nils Loodin wrote: Please review the following very small and insignificant change: Basically, I need to access a performance-counter by name from within the JVM. The method name by_name seems a little odd to me. find_by_name wo

RFR: 8007806: Need a Throwables performance counter

It would be interesting to know the number of thrown throwables in the JVM, to be able to do some high level application diagnostics / statistics. A good way to put this number would be a performance counter, since it is accessible both from Java and from the VM. http://bugs.sun.com/bugdatabase/v

Re: RFR(XXS): 8007147: Trace event ExecuteVMOperation may get dangling pointer

I don't like this solution since we are swallowing information that could potentially be interesting (that a VMOperation happened). I think it's fine to say that in the case of non-blocking VMOperations, the caller thread will be undefined or set to 0. We could add that information to the event

RE: RFR(XXS): 8007147: Trace event ExecuteVMOperation may get dangling pointer

Hi David, Thanks for taking a look. The original idea was to use thread id 0 as a signal for "Unknown Thread" or "no thread" if you like - however, there is nothing actually enforcing this; it was more of an implicit assumption (and to be honest, the only OS which I know for sure will never gi

[PATCH] A small fix on "scanoops" command in CLHSDB

Hi all, When I use “scanoops” command in CLHSDB, I find that if the type doesn’t exist, the output will be all the oops in the scope [start, end]. (see below) I think that’s irrational because all the oops between 0xee2000a0 and 0xee200550 are of type “java/lang/Class” and there

hg: jdk8/tl: 8008435: Fix new build to include jdk.Supported in ct.sym

Changeset: ecc8fda8f187 Author:darcy Date: 2013-02-19 00:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ecc8fda8f187 8008435: Fix new build to include jdk.Supported in ct.sym Reviewed-by: erikj ! common/makefiles/javadoc/NON_CORE_PKGS.gmk

hg: jdk8/tl/jdk: 8008434: Misc javadoc warning fixes in DateTimeFormatterBuilder and TimeZone

Changeset: 49b3d8efd30a Author:darcy Date: 2013-02-19 00:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49b3d8efd30a 8008434: Misc javadoc warning fixes in DateTimeFormatterBuilder and TimeZone Reviewed-by: mduigou, okutsu ! src/share/classes/java/time/format/DateTimeForm