Re: Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

Nice catch. Looks good. Thanks, Serguei On 2/21/13 9:09 PM, Coleen Phillimore wrote: I'm sorry about this but I need one more review. I omitted one instance of JVM_CONSTANT_Object in templateTable_sparc.cpp and I forgot that you can't make any edit to the VM without making a duplicate

Re: Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

I'm sorry about this but I need one more review. I omitted one instance of JVM_CONSTANT_Object in templateTable_sparc.cpp and I forgot that you can't make any edit to the VM without making a duplicate edit to the serviceability agent. open webrev at http://cr.openjdk.java.net/~coleenp/8000

hg: jdk8/tl: 9 new changesets

Changeset: ffb4d2e95140 Author:erikj Date: 2013-02-15 10:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ffb4d2e95140 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! c

答复: [PATCH] A small fix on "scanoops" command in CLHSDB

Staffan & Kris, Thank both of you for reviewing this. Hope you two could be official Reviewer soon :) Regards, Yunda 发件人: Staffan Larsen [mailto:staffan.lar...@oracle.com] 发送时间: 2013年2月21日 18:21 收件人: Krystal Mo 抄送: 云达; serviceability-dev@openjdk.java.net 主题: Re: [PATCH] A small fix on "scanoops

Re: Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

Thank you for filing the new bug on reconstitution. I think it needs more than this patch#42 symbol because the oop has to be carried forth from the resolved_references array in the old constant pool, and repatched into the new constant pool once the new resolved_references array is created

Re: 8008662: Add @jdk.Supported to JDK-specific/supported API

On 02/21/2013 10:46 AM, Alan Bateman wrote: Joe Darcy recently added @jdk.Supported [1] to make it possible to identify JDK-specific APIs. I'd like to add this to a number of APIs in the com.sun namespace to make it obvious these are "supported". Specifically I'm proposing to add it to:

Re: 8008662: Add @jdk.Supported to JDK-specific/supported API

On 2/21/2013 10:46 AM, Alan Bateman wrote: Joe Darcy recently added @jdk.Supported [1] to make it possible to identify JDK-specific APIs. I'd like to add this to a number of APIs in the com.sun namespace to make it obvious these are "supported". It's nice to be able to mark what is suppor

hg: jdk8/tl/jdk: 8008356: Test LambdaSerialization.java failing

Changeset: 1da987f0311a Author:rfield Date: 2013-02-21 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da987f0311a 8008356: Test LambdaSerialization.java failing Summary: run in /othervm mode Reviewed-by: ksrini ! test/java/lang/invoke/lambda/LambdaSerialization.java

hg: jdk8/tl/langtools: 8008658: Four new method param jtreg tests fail in nightly tests

Changeset: dabb36173c63 Author:ksrini Date: 2013-02-21 12:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dabb36173c63 8008658: Four new method param jtreg tests fail in nightly tests Reviewed-by: jjg, ksrini, mcimadamore Contributed-by: eric.mccor...@oracle.com ! sr

Re: Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

On Feb 20, 2013, at 8:11 PM, Coleen Phillimore wrote: > Thanks to John's feedback, I've modified this change again to revert back to > my original change to zero out the Symbol* to indicate pseudo string (could > be thought of as "patched string"). Also cleaned up unused constant pool > Obj

hg: hsx/hotspot-rt/hotspot: 8008071: Crashed in promote_malloc_records() with Kitchensink after 19 days

Changeset: fc64254f5579 Author:zgu Date: 2013-02-21 07:50 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fc64254f5579 8008071: Crashed in promote_malloc_records() with Kitchensink after 19 days Summary: Added NULL pointer check for arena size record Reviewed-by: ss

hg: jdk8/tl/langtools: 8008405: Now that metafactory is in place, add javac lambda serialization tests

Changeset: cd7340a84bb8 Author:rfield Date: 2013-02-21 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd7340a84bb8 8008405: Now that metafactory is in place, add javac lambda serialization tests Summary: Tests part of original langtools serialization review. Revie

Re: Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

Coleen, I like the fix. It looks good, and you also have done a nice clean-up*!* The class file reconstitution issue will be tracked by in a separate bug report (just filed): https://jbs.oracle.com/bugs/browse/JDK-8008678 constant pool reconstitution must support pseudo strings Thanks, Se

Re: Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

On 2/21/13 11:20 AM, John Rose wrote: On Feb 21, 2013, at 11:16 AM, "serguei.spit...@oracle.com " > wrote: I think, the John's suggestion for odd strings should work here. Something like: if (sym == NULL) { str = "CONSTANT

Re: 8008662: Add @jdk.Supported to JDK-specific/supported API

Well, that was quite a few files to have to go through :-) Looks fine On Feb 21, 2013, at 1:46 PM, Alan Bateman wrote: > > Joe Darcy recently added @jdk.Supported [1] to make it possible to identify > JDK-specific APIs. > > I'd like to add this to a number of APIs in the com.sun namespace to

Re: Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

On Feb 21, 2013, at 11:16 AM, "serguei.spit...@oracle.com" wrote: > I think, the John's suggestion for odd strings should work here. > Something like: > if (sym == NULL) { > str = "CONSTANT_PLACEHOLDER_42"; > } > > I will file a bug on this. Yes, that looks good. I suggest either the

Re: Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

On 2/20/13 11:59 AM, Coleen Phillimore wrote: On 2/20/2013 2:51 PM, John Rose wrote: On Feb 20, 2013, at 10:20 AM, Coleen Phillimore mailto:coleen.phillim...@oracle.com>> wrote: Summary: Add JVM_CONSTANT_PseudoString in place of JVM_CONSTANT_Object and use this tag to distinguish patched pse

8008662: Add @jdk.Supported to JDK-specific/supported API

Joe Darcy recently added @jdk.Supported [1] to make it possible to identify JDK-specific APIs. I'd like to add this to a number of APIs in the com.sun namespace to make it obvious these are "supported". Specifically I'm proposing to add it to: - Java Debug Interface (com.sun.jdi) - Attach

Re: RFR (S) 7178741: SA: jstack -m produce UnalignedAddressException in output (Linux)

Looks good! /Staffan (not a Reviewer) On 21 feb 2013, at 16:25, Kevin Walls wrote: > Hi, > > I'd like to get reviews on this small SA fix: > > http://cr.openjdk.java.net/~kevinw/7178741/webrev_8.00/ > > jstack -m follows native frames, and gets confused if it can't follow from > frame poin

Re: RFR (S) 7178741: SA: jstack -m produce UnalignedAddressException in output (Linux)

Hi Kevin, The changes look good. Thanks, Poonam On 2/21/2013 8:55 PM, Kevin Walls wrote: Hi, I'd like to get reviews on this small SA fix: http://cr.openjdk.java.net/~kevinw/7178741/webrev_8.00/ jstack -m follows native frames, and gets confused if it can't follow from frame pointer to sav

hg: jdk8/tl/langtools: 6 new changesets

Changeset: d686d8a7eb78 Author:mcimadamore Date: 2013-02-21 15:19 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d686d8a7eb78 8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler Summary: Disentangle cyclic dependency between static-ness of syn

RFR(M): 7165259 Remove BugSpot

Please review the following change to remove the BugSpot UI for the Serviceability Agent. My understanding is that BugSpot was intended as a more general native debugger not only focused on the JVM, but that it was never fully implemented. I don't think there is a need for a general-purpose debu

RFR (S) 7178741: SA: jstack -m produce UnalignedAddressException in output (Linux)

Hi, I'd like to get reviews on this small SA fix: http://cr.openjdk.java.net/~kevinw/7178741/webrev_8.00/ jstack -m follows native frames, and gets confused if it can't follow from frame pointer to saved frame pointer. Additional sanity checks on the register values avoid lengthy exception m

Re: RFR (XS): 8008541 Remove old code in HotSpot that supported the jmap -permstat functionality

Erik, Looks good! Bengt On 2/21/13 2:06 PM, Erik Helin wrote: All, based on some internal feedback, I've updated the change. The removal of PermStat.java could be done in the first change, reducing the size of this change. Webrev: http://cr.openjdk.java.net/~ehelin/8008541/webrev.01/ The

Re: RFR (S): 8008536: Add HotSpot support for printing class loader statistics for JMap

Erik, Looks good! Bengt On 2/21/13 2:06 PM, Erik Helin wrote: All, based on some internal feedback, I've updated the change. The file PermStat.java can be removed already in this first change. This means that 'hg mv' can be used, which provides a better history. Webrev: http://cr.openjdk.ja

Re: RFR (S): 8008536: Add HotSpot support for printing class loader statistics for JMap

Thanks. Still good! /Staffan On 21 feb 2013, at 14:09, Erik Helin wrote: > Staffan, > > On 02/21/2013 12:22 PM, Staffan Larsen wrote: >> All of these changes look good to me. What I didn't realize at first what >> the change from PermStat.java to ClassLoaderStats.java was simply a name >> ch

Re: RFR (S): 8008536: Add HotSpot support for printing class loader statistics for JMap

Staffan, On 02/21/2013 12:22 PM, Staffan Larsen wrote: All of these changes look good to me. What I didn't realize at first what the change from PermStat.java to ClassLoaderStats.java was simply a name change - no code was changed. I've update the changes to take this into account. On 02/21

Re: RFR (S): 8008536: Add HotSpot support for printing class loader statistics for JMap

All, based on some internal feedback, I've updated the change. The file PermStat.java can be removed already in this first change. This means that 'hg mv' can be used, which provides a better history. Webrev: http://cr.openjdk.java.net/~ehelin/8008536/webrev.01/ The second and third change have

Re: RFR (XS): 8005116: NPG: Rename -permstat option for jmap in jdk8 to -classstats

All, I've updated the change based on internal feedback and feedback from Staffan Larsen. The bug has been renamed to use -clstats and the help text now uses "class loader" instead of "classloader". Webrev: http://cr.openjdk.java.net/~ehelin/8005116/webrev.01/ The first and third change have a

Re: RFR (XS): 8008541 Remove old code in HotSpot that supported the jmap -permstat functionality

All, based on some internal feedback, I've updated the change. The removal of PermStat.java could be done in the first change, reducing the size of this change. Webrev: http://cr.openjdk.java.net/~ehelin/8008541/webrev.01/ The first and second change have also been updated. Thanks, Erik On 02

Re: RFR (S): 8008536: Add HotSpot support for printing class loader statistics for JMap

All of these changes look good to me. What I didn't realize at first what the change from PermStat.java to ClassLoaderStats.java was simply a name change - no code was changed. The 8005116 bug says that the new option should be -classstats, but the code uses -clstats. I think this is better

Re: [PATCH] A small fix on "scanoops" command in CLHSDB

I think this looks good, too. I'm not an official Reviewer, either. Thanks, /Staffan On 21 feb 2013, at 04:32, Krystal Mo wrote: > Hi Yunda, > > This patch looks reasonable to me. But you'll need an official Reviewer to > review this. > > - Kris > > On 2013/2/19 1:24, 云达 wrote: >> Hi all, >