RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket

2013-03-04 Thread Staffan Larsen
I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: 57 static void dll_build_name(char* buffer, size_t buflen, 58const

hg: jdk8/tl/jdk: 8009267: Restore isAnnotationPresent methods in public AnnotatedElement implementations

2013-03-04 Thread joe . darcy
Changeset: 83e847f59fd6 Author:darcy Date: 2013-03-04 19:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83e847f59fd6 8009267: Restore isAnnotationPresent methods in public AnnotatedElement implementations Reviewed-by: jjg ! src/share/classes/java/lang/Class.java !

hg: jdk8/tl/jdk: 8004240: Return value from getAdapterPrefence() can be modified

2013-03-04 Thread naoto . sato
Changeset: 1a2e59d19d3e Author:naoto Date: 2013-03-04 20:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1a2e59d19d3e 8004240: Return value from getAdapterPrefence() can be modified Reviewed-by: okutsu !

Re: RFR(S): 8008357: [sampling] assert(sender_blob-is_runtime_stub() || sender_blob-is_nmethod()) failed: Impossible call chain

2013-03-04 Thread Rickard Bäckman
Anyone have time to look at this? Thanks /R On Mar 1, 2013, at 10:27 AM, Rickard Bäckman wrote: Hi all, here comes another update to frame.safe_for_sender. If the PC at a place where the stack doesn't match the _frame_size we sometimes read an invalid return PC. In this case we read

RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-04 Thread Staffan Larsen
A very small fix for a warning. webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ Thanks, /Staffan

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-04 Thread David Holmes
Looks fine to me - thanks Staffan! David On 5/03/2013 5:24 PM, Staffan Larsen wrote: A very small fix for a warning. webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ Thanks, /Staffan

RE: RFR(S): 8008357: [sampling] assert(sender_blob-is_runtime_stub() || sender_blob-is_nmethod()) failed: Impossible call chain

2013-03-04 Thread Markus Grönlund
Rickard, Sorry, please forget about my first comments on the first assert: The comments on line 221-222 is are a bit confusion in association with the conditional and the follow-up assert on line 225. The comment outlines the layout and invariant for nmethods, but in the conditional