hg: jdk8/tl/jdk: 8009604: old make images failed: JarBASE64Encoder class not found

2013-03-06 Thread weijun . wang
Changeset: cf54f6be3e9e Author:weijun Date: 2013-03-07 11:32 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf54f6be3e9e 8009604: old make images failed: JarBASE64Encoder class not found Reviewed-by: xuelei, wetmore ! make/common/Release.gmk

hg: jdk8/tl/jdk: 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so

2013-03-06 Thread martinrb
Changeset: 14e49a70729a Author:martin Date: 2013-03-06 17:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/14e49a70729a 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so Summary: Define FILES_m to force use of linker script Reviewed-by: sherman, a

RE: [PATCH] typeToVtbl of BasicTypeDataBase should not be static

2013-03-06 Thread Yunda
Staffan, Thanks! I think the issue here is quite clear, since the role of "typeToVtbl " filed of BasicTypeDataBase is similar to "typeToVtblMap" field of BasicVtblAccess and the latter is not static. Regards, Yunda From: Staffan Larsen [mailto:staffan.lar...@oracle.com] Sent: Tuesday, March

RE: [PATCH] A small fix on "scanoops" command in CLHSDB

2013-03-06 Thread Yunda
Staffan, Thanks for doing this, too☺ Regards, Yunda From: Staffan Larsen [mailto:staffan.lar...@oracle.com] Sent: Tuesday, March 05, 2013 9:21 PM To: 云达(Yunda) Cc: Krystal Mo; serviceability-dev@openjdk.java.net Subject: Re: [PATCH] A small fix on "scanoops" command in CLHSDB I have created iss

hg: hsx/hotspot-rt/hotspot: 7107135: Stack guard pages are no more protected after loading a shared library with executable stack

2013-03-06 Thread zhengyu . gu
Changeset: 9058789475af Author:iklam Date: 2013-03-05 13:55 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9058789475af 7107135: Stack guard pages are no more protected after loading a shared library with executable stack Summary: Detect the execstack attribute of

Re: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket

2013-03-06 Thread serguei.spit...@oracle.com
Staffan, Thank you for the confirmation and taking care about this issue! Thanks, Serguei On 3/6/13 11:36 AM, Staffan Larsen wrote: Nice catch, Serguei! Unfortunately I have already pushed my change, but I filed "JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite loop" t

Re: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket

2013-03-06 Thread Staffan Larsen
Nice catch, Serguei! Unfortunately I have already pushed my change, but I filed "JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite loop" to track this new problem and I am working on a fix. Thanks, /Staffan On 5 mar 2013, at 20:26, serguei.spit...@oracle.com wrote: > Hi S

Re: RFR: 8008917 CMS: Concurrent mode failure tracing event

2013-03-06 Thread Erik Helin
Hi Kevin, I think that there _might_ be a bug in CMS which was present even before you added the event tracing. If you look in aquire_control_and_collect, you will see that "should_compact" can be set to false by decide_foreground_collection_type. If this is the case, then we will end up in

Re: RFR: JDK-8008790 - Promotion failed tracing event for all GCs

2013-03-06 Thread Erik Helin
Hi Jesper, looks good. Thanks, Erik On 03/06/2013 05:04 PM, Jesper Wilhelmsson wrote: Hi, Additional feedback resulted in a new webrev: http://cr.openjdk.java.net/~jwilhelm/8008790/webrev.hsx24.3/ Thanks, /Jesper On 26/2/13 4:54 PM, Jesper Wilhelmsson wrote: Hi, After some internal feed

hg: jdk8/tl/jdk: 8007808: Missing method: Executable.getAnnotatedReturnType()

2013-03-06 Thread joel . franck
Changeset: 38e1821c4472 Author:jfranck Date: 2013-03-06 18:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38e1821c4472 8007808: Missing method: Executable.getAnnotatedReturnType() Reviewed-by: darcy, forax ! src/share/classes/java/lang/reflect/Constructor.java ! src/share

Re: RFR: 8008917 CMS: Concurrent mode failure tracing event

2013-03-06 Thread Jesper Wilhelmsson
Looks good! Since we want to implement this event for G1 as well, maybe we should remove the "CMS" from the event name and path? Thanks, /Jesper On 1/3/13 6:34 PM, Kevin Walls wrote: Hi, I'd like some reviews on this CMS Concurrent Mode Failure event: http://cr.openjdk.java.net/~kevinw/800

hg: jdk8/tl: 8009162: root repo "make test" target should run against image

2013-03-06 Thread mike . duigou
Changeset: b35d986ff276 Author:mduigou Date: 2013-03-06 08:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b35d986ff276 8009162: root repo "make test" target should run against image Reviewed-by: alanb, martin, erikj ! common/makefiles/Main.gmk

Re: RFR: 8003348: SA can not read core file on OS X

2013-03-06 Thread Yumin Qi
Thanks, Serguei Will take care what you have indicated but refactoring code for ps_core.c (Pgrab_core). Maybe in future, code cleaning should include this, the better choice I think is regroup code to detail in specific platform, such as with new file ps_core_darwin.c etc but not now. /Yu

Re: RFR: JDK-8008790 - Promotion failed tracing event for all GCs

2013-03-06 Thread Jesper Wilhelmsson
Hi, Additional feedback resulted in a new webrev: http://cr.openjdk.java.net/~jwilhelm/8008790/webrev.hsx24.3/ Thanks, /Jesper On 26/2/13 4:54 PM, Jesper Wilhelmsson wrote: Hi, After some internal feedback a new version of the webrev is available at: http://cr.openjdk.java.net/~jwilhelm/80

hg: jdk8/tl/langtools: 3 new changesets

2013-03-06 Thread maurizio . cimadamore
Changeset: d0178bd8125c Author:mcimadamore Date: 2013-03-06 15:29 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0178bd8125c 8009299: Javac crashes when compiling method reference to static interface method Summary: Assertion in Check.checMethod is too strict Reviewed

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-06 Thread Staffan Larsen
On 6 mar 2013, at 00:23, David Holmes wrote: > On 6/03/2013 9:08 AM, Dean Long wrote: >> What if allocate_init_map() fails to allocate memory? Shouldn't >> add_class_share_map_info() follow the pattern of add_map_info(): >> return NULL or "map", and have the caller check for NULL? > > AFAICS a

hg: jdk8/tl/jdk: 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket

2013-03-06 Thread staffan . larsen
Changeset: 34372bb9115d Author:sla Date: 2013-03-05 19:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34372bb9115d 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket Reviewed-by: alanb ! src/share/back/tran