Serguei and Saffan,
Please take look at the same link for new webrev.
Thanks
Yumin
On 3/7/2013 4:01 PM, serguei.spit...@oracle.com wrote:
Thank you for making the suggested changes!
Serguei
On 3/7/13 3:55 PM, Yumin Qi wrote:
Hi, Serguei
Thanks for the review, I reviewed the part of Pgra
Changeset: 6b803ba47588
Author:zgu
Date: 2013-03-07 14:06 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6b803ba47588
8008257: NMT: assert(new_rec->is_allocation_record()) failed when running with
shared memory option
Summary: Corrected virtual memory recording an
Thank you for making the suggested changes!
Serguei
On 3/7/13 3:55 PM, Yumin Qi wrote:
Hi, Serguei
Thanks for the review, I reviewed the part of Pgrab_core, you are
right, I now put the code into two chunks: APPLE and none APPLE.
Will send another webrev for you tonight --- add all your c
Hi Kevin,
Changes look good to me.
Thanks,
Poonam
On 3/1/2013 11:04 PM, Kevin Walls wrote:
Hi,
I'd like some reviews on this CMS Concurrent Mode Failure event:
http://cr.openjdk.java.net/~kevinw/8008917/hotspot/
The event doesn't actually carry any new information, but it is a
warning we n
Hi, Serguei
Thanks for the review, I reviewed the part of Pgrab_core, you are
right, I now put the code into two chunks: APPLE and none APPLE.
Will send another webrev for you tonight --- add all your concerns.
See answers below:
On 3/7/2013 3:32 PM, serguei.spit...@oracle.com wrote:
Hi Yumin,
No insisting on refactoring, it is just desirable. :)
*
agent/src/os/bsd/symtab.c*
Need a cleanup:
54 // #define NAMELEN 4096
78 // dysymtab_command dysymtabcmd;
114 // guarantee(symtab->hash_table, "unexpected failure: dbopen");
This function is too big, it would be nice
Nice fix!
This is more clear and robust.
Extra memory allocation is Ok.
Thanks,
Serguei
On 3/7/13 3:54 AM, Staffan Larsen wrote:
Here is a webrev for fixing this problem. I actually removed all of
our own tokenization code in dll_build_name() and replaced it with
calls to strtok_r (strtok_s o
Hi Erik -
Yes, now you mention it I can see the route to printing the old warning
or logging the event twice...
I don't think it's reported as a problem, or maybe it's very rare and
nobody has spotted it.
But assuming it's not a "user-requested" collection, to get that false
"should_compac
Changeset: a02c3ddc182b
Author:rfield
Date: 2013-03-07 08:26 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a02c3ddc182b
8009582: Method reference generic constructor gives: IllegalArgumentException:
Invalid lambda deserialization
Reviewed-by: mcimadamore
! src/share/
Here is a webrev for fixing this problem. I actually removed all of our own
tokenization code in dll_build_name() and replaced it with calls to strtok_r
(strtok_s on windows) instead. I think this should be more robust, at the cost
of an extra memory allocation. I've also added the const qualifi
Thanks David!
On 7 mar 2013, at 11:53, David Holmes wrote:
> On 7/03/2013 6:27 PM, Staffan Larsen wrote:
>> Can I have a Review for this small change, please.
>
> I could have sworn I'd already seen this one and reviewed it :)
>
> If it fixes the problem - looks fine.
>
> David
>
>> Thanks,
On 7/03/2013 6:27 PM, Staffan Larsen wrote:
Can I have a Review for this small change, please.
I could have sworn I'd already seen this one and reviewed it :)
If it fixes the problem - looks fine.
David
Thanks,
/Staffan
On 18 feb 2013, at 11:15, Staffan Larsen wrote:
Please review this
Changeset: 48b7295f02f8
Author:chegar
Date: 2013-03-07 10:07 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48b7295f02f8
6370908: Add support for HTTP_CONNECT proxy in Socket class
Reviewed-by: chegar
Contributed-by: Damjan Jovanovic , Chris Hegarty
+ src/share/classes/jav
Changeset: 823fb9229724
Author:vromero
Date: 2013-03-07 10:12 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/823fb9229724
8009170: Regression: javac generates redundant bytecode in assignop involving
arrays
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/ja
Changeset: 3806171b52d8
Author:vromero
Date: 2013-03-07 10:04 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3806171b52d8
8009138: javac, equals-hashCode warning tuning
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classe
Looks good.
Thanks,
Serguei
On 3/7/13 12:10 AM, Staffan Larsen wrote:
Adding core-libs-dev and re-asking for a review.
Thanks,
/Staffan
On 27 feb 2013, at 15:59, Staffan Larsen wrote:
Please review the following test fix.
webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/
bug: htt
Can I have a Review for this small change, please.
Thanks,
/Staffan
On 18 feb 2013, at 11:15, Staffan Larsen wrote:
> Please review this change for hs24 / jdku.
>
> webrev: http://cr.openjdk.java.net/~sla/8005572/webrev.00/
>
> The problem lies with the order of the newly introduced JfrBuffer
Adding core-libs-dev and re-asking for a review.
Thanks,
/Staffan
On 27 feb 2013, at 15:59, Staffan Larsen wrote:
> Please review the following test fix.
>
> webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637
>
> The pr
18 matches
Mail list logo
