Changeset: 6b748c9e1845
Author:zgu
Date: 2013-03-26 14:11 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6b748c9e1845
8010651: create.bat still builds the kernel
Summary: Remove old kernel build targets and VS C++ projects created by
create.bat on Windows
Reviewed
Forgot to comment on the test...
On 3/26/13 4:11 PM, Coleen Phillimore wrote:
Summary: Neglected to copy the annotations in clone_with_new_data when
they were moved to ConstMethod.
open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
bug link at http://bugs.sun.com/view_bug.do?bug_id=8
On 3/26/13 4:11 PM, Coleen Phillimore wrote:
Summary: Neglected to copy the annotations in clone_with_new_data when
they were moved to ConstMethod.
open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
Thumbs up! Only a comment suggestion and a naming heckle :-)
src/share/vm/oops/const
Changeset: 33b6a52f0037
Author:darcy
Date: 2013-03-26 18:15 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/33b6a52f0037
7059170: Assume availablility of URLClassLoader.close
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java
- src/share/
On 3/26/13 5:17 PM, Coleen Phillimore wrote:
On 03/26/2013 07:24 PM, serguei.spit...@oracle.com wrote:
Copy usually means copying values by pointers.
Not clear what's wrong with the "set_annotations" as there is no such
function yet.
There are set_x_annotations and I wouldn't want someone t
Changeset: 330b35b27e68
Author:darcy
Date: 2013-03-26 17:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/330b35b27e68
7041251: Use j.u.Objects utility methods in langtools
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/util/Pair.java
! src/share/classes/jav
On 03/26/2013 07:24 PM, serguei.spit...@oracle.com wrote:
Copy usually means copying values by pointers.
Not clear what's wrong with the "set_annotations" as there is no such
function yet.
There are set_x_annotations and I wouldn't want someone to think
set_annotations just sets one sort.
Copy usually means copying values by pointers.
Not clear what's wrong with the "set_annotations" as there is no such
function yet.
Probably, you find it confusing too.
But I'm not insisting on the copy_annotation_pointers() either. :)
Let's keep it as it is.
Thanks,
Serguei
On 3/26/13 3:58 PM
It copies the pointers. I can't change it to set_annotations because
there are already set_ functions. O could change to
copy_annotation_pointers() if you insist.
Coleen
On 03/26/2013 07:00 PM, serguei.spit...@oracle.com wrote:
Coleen,
This does not look like a clone or copy, it just set
Coleen,
This does not look like a clone or copy, it just sets the value?
366 void ConstMethod::copy_annotations(ConstMethod* cm) {
367 if (cm->has_method_annotations()) {
368 assert(has_method_annotations(), "should be allocated already");
369 set_method_annotations(cm->method_anno
Coleen,
Looks good.
thanks,
Karen
On Mar 26, 2013, at 6:11 PM, Coleen Phillimore wrote:
> Summary: Neglected to copy the annotations in clone_with_new_data when they
> were moved to ConstMethod.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
> bug link at http://bugs.sun.com/
Changeset: 36376b540a98
Author:hseigel
Date: 2013-03-26 09:06 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/36376b540a98
8009595: The UseSplitVerifier option needs to be deprecated.
Summary: Put UseSplitVerifier option on the deprecated list.
Reviewed-by: dcubed,
Summary: Neglected to copy the annotations in clone_with_new_data when
they were moved to ConstMethod.
open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
Also. please review JDK test modified to test that this crash is fixed
(
Thumbs up.
Mandy
On 3/26/13 4:29 AM, Erik Helin wrote:
Anyone?
It is a very small change and I would really like these tests to start
running again in the nightly testing.
Thanks,
Erik
On 03/22/2013 03:53 PM, Erik Helin wrote:
Hi all,
the tests for jstat can be re-enabled now that jstat
Changeset: 3b56ef8e1ce1
Author:martin
Date: 2013-03-26 13:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b56ef8e1ce1
8007905: To add a system property to create zip file without using ZIP64 end
table when entry count > 64k
Summary: Provide a system property to inhibit ZI
Changeset: 1916ca1dec2f
Author:rbackman
Date: 2013-03-26 15:00 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1916ca1dec2f
8009382: Add JVM_Get{Field|Method}TypeAnnotations
Reviewed-by: dcubed, rbackman
Contributed-by: Joel Borggren-Franck
! make/bsd/makefiles/ma
Hi David,
Thank you for your opinion and concern on this!
The removal of the NoSafepointVerifier is the biggest concern in this fix.
It was raised in the preliminary review and already discussed a little bit.
Now I hope to clear it up during the open code review.
John wanted to look at it more c
Looks good.
/Staffan
On 25 mar 2013, at 21:13, Erik Gahlin wrote:
> Hi,
>
> Could you please review this small change to the metadata for StackTrace
> content type, used by the event tracing framework. A boolean flag has been
> added so it's possible to see if a stack trace has been truncate
Hi Dan,
thanks for the review!
On 03/26/2013 02:15 PM, Daniel D. Daugherty wrote:
The HotSpot changes were included in HSX-25-B22 which was
included in JDK8-B81 which is promoted. Have you rerun the
tests to make sure that they either pass or that the remaining
failure modes (if any) are covere
Changeset: ae4ef3102d9c
Author:lagergren
Date: 2013-03-25 12:01 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae4ef3102d9c
8017010: index evaluation to a temporary location for index operator much
change temporaries to slots, but never scoped vars
Reviewed-by: hannesw,
Still need a Reviewer…
Thanks
/R
On Mar 25, 2013, at 12:43 PM, Staffan Larsen wrote:
> Looks good to me - not a Reviewer.
>
> /Staffan
>
> On 25 mar 2013, at 12:13, Rickard Bäckman wrote:
>
>> Hi,
>>
>> trying again, can I please have two reviews on this change?
>> Some small changes after
The HotSpot changes were included in HSX-25-B22 which was
included in JDK8-B81 which is promoted. Have you rerun the
tests to make sure that they either pass or that the remaining
failure modes (if any) are covered by an open bug or bugs?
Thumbs up for the ProblemList.txt change.
Dan
On 3/26/1
Hi Staffan,
thanks for the review! Now I just need a JDK reviewer to take a look at
this.
Erik
On 03/26/2013 01:09 PM, Staffan Larsen wrote:
Looks good!
On 26 mar 2013, at 12:29, Erik Helin wrote:
Anyone?
It is a very small change and I would really like these tests to start running
ag
Looks good!
On 26 mar 2013, at 12:29, Erik Helin wrote:
> Anyone?
>
> It is a very small change and I would really like these tests to start
> running again in the nightly testing.
>
> Thanks,
> Erik
>
> On 03/22/2013 03:53 PM, Erik Helin wrote:
>> Hi all,
>>
>> the tests for jstat can be r
Anyone?
It is a very small change and I would really like these tests to start
running again in the nightly testing.
Thanks,
Erik
On 03/22/2013 03:53 PM, Erik Helin wrote:
Hi all,
the tests for jstat can be re-enabled now that jstat and the tests for
jstat have been updated to account for m
Hi Serguei,
The removal of the NoSafepointVerifier could be problematic. If that
method is never meant to be on the stack when you block for a safepoint
then the method is atomic with respect to the safepoint - and so can not
suffer interference from actions that occur at a safepoint (like cla
Looks good!
/Staffan
On 25 mar 2013, at 22:17, Erik Gahlin wrote:
> Hi,
>
> Could you please review these small metadata changes for the event tracing
> framework:
>
> - Promotion Failed -> objectCount has the datatype BYTES64, which implies
> that it is a size. It is not, and the type shou
Please, review the following fix.
The fix was preliminarily reviewed by Coleen, Christian
and John but still a final and open jdk review is needed.
So that, everyone is welcome to review the fix!
This is open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.
28 matches
Mail list logo
