Request for reviews (S): JDK-8011979: SA: Special-case Instance.printValueOn() for Java mirrors

2013-04-11 Thread Krystal Mo
Hi everyone, Could I have a few reviews for this change, please? Webrev: http://cr.openjdk.java.net/~kmo/8011979/webrev.00/ CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011979 Description: (copied from the CR) Currently it's hard to tell from the output of

RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread Rickard Bäckman
Hi all, can I please have reviews for this change. In the current implementation do_suspend uses spin loops to wait until a thread has been suspended. I would like to change that to use semaphores to reduce CPU usage and also make it easier to have a deterministic timeout. Since we are

Re: RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread David Holmes
Rickard, On 11/04/2013 9:51 PM, Rickard Bäckman wrote: Hi all, can I please have reviews for this change. In the current implementation do_suspend uses spin loops to wait until a thread has been suspended. I would like to change that to use semaphores to reduce CPU usage and also make it

Re: RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread Rickard Bäckman
David, On Apr 11, 2013, at 2:15 PM, David Holmes wrote: Rickard, On 11/04/2013 9:51 PM, Rickard Bäckman wrote: Hi all, can I please have reviews for this change. In the current implementation do_suspend uses spin loops to wait until a thread has been suspended. I would like to change

Re: RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread David Holmes
On 11/04/2013 10:30 PM, Rickard Bäckman wrote: David, On Apr 11, 2013, at 2:15 PM, David Holmes wrote: Rickard, On 11/04/2013 9:51 PM, Rickard Bäckman wrote: Hi all, can I please have reviews for this change. In the current implementation do_suspend uses spin loops to wait until a thread

Re: RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread Rickard Bäckman
On Apr 11, 2013, at 2:39 PM, David Holmes wrote: On 11/04/2013 10:30 PM, Rickard Bäckman wrote: David, On Apr 11, 2013, at 2:15 PM, David Holmes wrote: Rickard, On 11/04/2013 9:51 PM, Rickard Bäckman wrote: Hi all, can I please have reviews for this change. In the current

Re: RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread Staffan Larsen
Looks good to me. /Staffan On 11 apr 2013, at 13:51, Rickard Bäckman rickard.back...@oracle.com wrote: Hi all, can I please have reviews for this change. In the current implementation do_suspend uses spin loops to wait until a thread has been suspended. I would like to change that to

hs25 review request (round 2): 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands

2013-04-11 Thread serguei.spit...@oracle.com
Please, review the hs25 fix (round 2) below. Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.2/ CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037 https://jbs.oracle.com/bugs/browse/JDK-8007037 This webrev includes a review fix from

Re: RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread David Holmes
On 11/04/2013 11:02 PM, Rickard Bäckman wrote: On Apr 11, 2013, at 2:39 PM, David Holmes wrote: So what did you mean about pthread_semaphore (what is that anyway?) ?? Never mind, pthread condition variables. Ah I see. I really, really, really don't like seeing three versions of this

hg: jdk8/tl/langtools: 2 new changesets

2013-04-11 Thread lana . steuck
Changeset: 2c9acb17f41a Author:katleman Date: 2013-04-11 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2c9acb17f41a Added tag jdk8-b85 for changeset 4a48f3173534 ! .hgtags Changeset: d13af7751456 Author:lana Date: 2013-04-11 19:15 -0700 URL:

hg: jdk8/tl/jaxws: 2 new changesets

2013-04-11 Thread lana . steuck
Changeset: 26c840af7720 Author:katleman Date: 2013-04-11 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/26c840af7720 Added tag jdk8-b85 for changeset 8c0b6bccfe47 ! .hgtags Changeset: 28886cb008bb Author:lana Date: 2013-04-11 19:15 -0700 URL:

hg: jdk8/tl: 10 new changesets

2013-04-11 Thread lana . steuck
Changeset: 52d1b385a4ed Author:erikj Date: 2013-04-04 09:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/52d1b385a4ed 8006828: SKIP_BOOT_CYCLE=false must work in new building infrastructure Reviewed-by: tbell, alanb ! common/autoconf/bootcycle-spec.gmk.in !

hg: jdk8/tl/jdk: 5 new changesets

2013-04-11 Thread lana . steuck
Changeset: e22961ea91bd Author:erikj Date: 2013-04-05 09:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e22961ea91bd 8008373: JFR JTReg tests fail with CompilationError on MacOSX; missing '._sunec.jar' Reviewed-by: tbell ! makefiles/CompileDemos.gmk !

hg: jdk8/tl/hotspot: 62 new changesets

2013-04-11 Thread lana . steuck
Changeset: d26674db4d91 Author:amurillo Date: 2013-03-28 19:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d26674db4d91 8011022: new hotspot build - hs25-b26 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0c3ee6f1fa23 Author:coleenp Date: 2013-03-27

hg: hsx/hotspot-rt: 9 new changesets

2013-04-11 Thread john . coomes
Changeset: 52d1b385a4ed Author:erikj Date: 2013-04-04 09:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/52d1b385a4ed 8006828: SKIP_BOOT_CYCLE=false must work in new building infrastructure Reviewed-by: tbell, alanb ! common/autoconf/bootcycle-spec.gmk.in !

hg: hsx/hotspot-rt/corba: Added tag jdk8-b85 for changeset 9583a6431596

2013-04-11 Thread john . coomes
Changeset: 44a8ce4a759f Author:katleman Date: 2013-04-11 09:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/44a8ce4a759f Added tag jdk8-b85 for changeset 9583a6431596 ! .hgtags

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b85 for changeset 41b50e2c5ea3

2013-04-11 Thread john . coomes
Changeset: ca71ec37b2ef Author:katleman Date: 2013-04-11 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/ca71ec37b2ef Added tag jdk8-b85 for changeset 41b50e2c5ea3 ! .hgtags

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b85 for changeset 8c0b6bccfe47

2013-04-11 Thread john . coomes
Changeset: 26c840af7720 Author:katleman Date: 2013-04-11 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/26c840af7720 Added tag jdk8-b85 for changeset 8c0b6bccfe47 ! .hgtags

hg: hsx/hotspot-rt/jdk: 4 new changesets

2013-04-11 Thread john . coomes
Changeset: e22961ea91bd Author:erikj Date: 2013-04-05 09:39 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e22961ea91bd 8008373: JFR JTReg tests fail with CompilationError on MacOSX; missing '._sunec.jar' Reviewed-by: tbell ! makefiles/CompileDemos.gmk !

hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b85 for changeset e0378f0a50da

2013-04-11 Thread john . coomes
Changeset: aed0529f5f5d Author:katleman Date: 2013-04-11 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/aed0529f5f5d Added tag jdk8-b85 for changeset e0378f0a50da ! .hgtags

hg: hsx/hotspot-rt/langtools: Added tag jdk8-b85 for changeset 4a48f3173534

2013-04-11 Thread john . coomes
Changeset: 2c9acb17f41a Author:katleman Date: 2013-04-11 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2c9acb17f41a Added tag jdk8-b85 for changeset 4a48f3173534 ! .hgtags

Re: RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread Rickard Bäckman
On Apr 12, 2013, at 1:04 AM, David Holmes wrote: On 11/04/2013 11:02 PM, Rickard Bäckman wrote: On Apr 11, 2013, at 2:39 PM, David Holmes wrote: So what did you mean about pthread_semaphore (what is that anyway?) ?? Never mind, pthread condition variables. Ah I see. I really,

Re: RFR: 8011882: Replace spin loops as back off when suspending

2013-04-11 Thread David Holmes
On 12/04/2013 3:01 PM, Rickard Bäckman wrote: On Apr 12, 2013, at 1:04 AM, David Holmes wrote: On 11/04/2013 11:02 PM, Rickard Bäckman wrote: On Apr 11, 2013, at 2:39 PM, David Holmes wrote: So what did you mean about pthread_semaphore (what is that anyway?) ?? Never mind, pthread