RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread Markus Grönlund
Thanks David and Sergeui, I have added (back) the INCLUDE_TRACE for the load code. Webrev version 5: http://cr.openjdk.java.net/~mgronlun/8012182/webrev05/ BugID: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012182 Thanks Markus -Original Message- From: David Holmes Sent: d

hg: jdk8/tl/jdk: 8010096: Initial java.util.Spliterator putback

2013-04-17 Thread mike . duigou
Changeset: 674880648db4 Author:briangoetz Date: 2013-04-16 13:51 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/674880648db4 8010096: Initial java.util.Spliterator putback Reviewed-by: mduigou, alanb, chegar, darcy Contributed-by: Paul Sandoz , Brian Goetz , Doug Lea ! src

RE: Why the type of GCId in gcTrace.hpp is uint?

2013-04-17 Thread Yunda
Jesper, Thanks and I'll have a look at it. Regards, Yunda > -Original Message- > From: Jesper Wilhelmsson [mailto:jesper.wilhelms...@oracle.com] > Sent: Wednesday, April 17, 2013 7:13 PM > To: 云达(Yunda) > Cc: hotspot-gc-dev openjdk.java.net (hotspot-gc-...@openjdk.java.net); > serviceab

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread David Holmes
On 18/04/2013 3:39 AM, Markus Grönlund wrote: Hi again, Seems it wasn't really as straightforward as originally suggesting with collocating the event tracing and the JVMTI code - especially if I attempt to breakout the JVMTI notification code from SystemDictionary::define_instance_class(); th

Re: hs25 review request (2nd round): 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition

2013-04-17 Thread John Rose
As we discussed verbally, I suggest adding a line like this at the beginning of every low-level MemberNameTable access function: assert_locked_or_safepoint(MemberNameTable_lock); (I'm modeling this from SystemDictionary::find_class and its brothers.) The rest of it looks good. Reviewed! —

Re: hs25 review request (round 2): 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands

2013-04-17 Thread serguei.spit...@oracle.com
Hi Christian, On 4/17/13 4:06 PM, Christian Thalinger wrote: On Apr 11, 2013, at 4:08 PM, serguei.spit...@oracle.com wrote: Please, review the hs25 fix (round 2) below. Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.2/ One thing that makes it har

Re: hs25 review request (round 2): 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands

2013-04-17 Thread Christian Thalinger
On Apr 11, 2013, at 4:08 PM, serguei.spit...@oracle.com wrote: > Please, review the hs25 fix (round 2) below. > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.2/ One thing that makes it hard to follow what going on are the variable names, e.g.:

hg: jdk8/tl/jdk: 16 new changesets

2013-04-17 Thread lana . steuck
Changeset: 87c62f03bc07 Author:jgodinez Date: 2013-03-27 12:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87c62f03bc07 8010005: [parfait] Memory leak in jdk/src/macosx/native/sun/awt/CTextPipe.m Reviewed-by: bae, prr Contributed-by: jia-hong.c...@oracle.com ! src/macosx/

hg: jdk8/tl/nashorn: 2 new changesets

2013-04-17 Thread lana . steuck
Changeset: 35881a9d0fc2 Author:lana Date: 2013-04-16 08:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/35881a9d0fc2 Merge - test/script/basic/JDK-8017010.js - test/script/basic/JDK-8017010.js.EXPECTED Changeset: 44d8612e29b0 Author:lana Date: 2013-04-17 10:3

hg: jdk8/tl/jaxws: 2 new changesets

2013-04-17 Thread lana . steuck
Changeset: a5e7c2f093c9 Author:lana Date: 2013-04-16 08:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a5e7c2f093c9 Merge - src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/DefaultAuthenticator.java - src/share/jaxws_classes/com/sun/tools/internal/xjc/api/i

hg: jdk8/tl/hotspot: 19 new changesets

2013-04-17 Thread lana . steuck
Changeset: e437668ced9d Author:amurillo Date: 2013-04-11 01:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e437668ced9d 8011948: new hotspot build - hs25-b28 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 68fe50d4f1d5 Author:johnc Date: 2013-04-05 10

hg: jdk8/tl/langtools: 2 new changesets

2013-04-17 Thread lana . steuck
Changeset: 1f19b84efa6d Author:lana Date: 2013-04-16 08:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f19b84efa6d Merge - src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java - test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java

hg: jdk8/tl/jdk: 2 new changesets

2013-04-17 Thread coleen . phillimore
Changeset: 7f9f69729934 Author:coleenp Date: 2013-04-17 12:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7f9f69729934 8009531: Crash when redefining class with annotated method Summary: Add code to annotated methods and command line flags to the tests to verify bug above

hg: jdk8/tl/jdk: 8004260: dynamic proxy class should have the same Java language access as the proxy interfaces

2013-04-17 Thread mandy . chung
Changeset: 73e3b474125e Author:mchung Date: 2013-04-17 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73e3b474125e 8004260: dynamic proxy class should have the same Java language access as the proxy interfaces Reviewed-by: alanb, jrose, jdn ! src/share/classes/java/la

hg: jdk8/tl/jdk: 8010953: Add primitive summary statistics utils

2013-04-17 Thread mike . duigou
Changeset: d9f9040554d6 Author:mduigou Date: 2013-04-17 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f9040554d6 8010953: Add primitive summary statistics utils Reviewed-by: mduigou, dholmes, chegar, darcy Contributed-by: Brian Goetz + src/share/classes/java/util/D

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread serguei.spit...@oracle.com
Hi Markus, Not a thorough review but it looks good to me. Just one question. Did you want to put the post_class_load_event function body also under #if condition? The same way as it is done for post_class_unload_events: 2634 void SystemDictionary::post_class_unload_events(BoolObjectClosure*

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread Markus Grönlund
Hi again, Seems it wasn't really as straightforward as originally suggesting with collocating the event tracing and the JVMTI code - especially if I attempt to breakout the JVMTI notification code from SystemDictionary::define_instance_class(); this seems to have detrimental effects on the UTE

Re: RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads

2013-04-17 Thread serguei.spit...@oracle.com
Hi Mikael, It looks good. Thank you for figuring out how to make it more stable! BTW, the webrev frames mode does not work. Thanks, Serguei On 4/17/13 6:03 AM, Mikael Auno wrote: Hi, I'd like some reviews on http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681 (http://bugs.

hg: jdk8/tl/jdk: 8012019: (fc) Thread.interrupt triggers hang in FileChannelImpl.pread (win)

2013-04-17 Thread alan . bateman
Changeset: 7ded74ffea36 Author:alanb Date: 2013-04-17 16:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ded74ffea36 8012019: (fc) Thread.interrupt triggers hang in FileChannelImpl.pread (win) Reviewed-by: chegar ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! s

hg: jdk8/tl/jdk: 12 new changesets

2013-04-17 Thread vincent . x . ryan
Changeset: 473ed4b94306 Author:vinnie Date: 2013-04-11 17:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/473ed4b94306 7171982: Cipher getParameters() throws RuntimeException: Cannot find SunJCE provider Reviewed-by: vinnie, wetmore Contributed-by: Tony Scarpino ! src/sh

hg: hsx/hotspot-rt/hotspot: 8009928: PSR:PERF Increase default string table size

2013-04-17 Thread harold . seigel
Changeset: 63e31ce40bdb Author:hseigel Date: 2013-04-17 08:20 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/63e31ce40bdb 8009928: PSR:PERF Increase default string table size Summary: Increase default string table size to 60013 for 64-bit platforms. Reviewed-by: co

RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads

2013-04-17 Thread Mikael Auno
Hi, I'd like some reviews on http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681 (http://bugs.sun.com/view_bug.do?bug_id=8009681). The issue here is that when MethodExitReturnValuesTest hooks into MethodExit events through JDI it uses an exclude list to filter out classes f

Re: Why the type of GCId in gcTrace.hpp is uint?

2013-04-17 Thread Jesper Wilhelmsson
云达, I have a fix four this in review right now. I send the mail yesterday, feel free to have a look at it. I changed the GC ID and Compiler ID since they are both unsigned int values. The Javalangthread is a long so I didn't include that in this change. /Jesper 云达(Yunda) skrev 15/3/13 3:36

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread Markus Grönlund
Hi again, Updated webrev (v3) trying to respect the loader constraint checking before event posting - in addition trying to consolidate the event notification code (instrumentation in SystemDictionary::define_instance_class() seems to indicate the ok'ness of moving the JVMTI::should_post call f

hg: jdk8/tl/langtools: 8011181: javac, empty UTF8 entry generated for inner class

2013-04-17 Thread vicente . romero
Changeset: 49d32c84dfea Author:vromero Date: 2013-04-17 11:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/49d32c84dfea 8011181: javac, empty UTF8 entry generated for inner class Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java + test/too

hg: jdk8/tl: 8011347: JKD-8009824 has broken webrev with some ksh versions

2013-04-17 Thread daniel . fuchs
Changeset: b95c5c8ee60a Author:jgish Date: 2013-04-16 13:25 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b95c5c8ee60a 8011347: JKD-8009824 has broken webrev with some ksh versions Reviewed-by: mduigou ! make/scripts/webrev.ksh

hg: jdk8/tl/jdk: 2 new changesets

2013-04-17 Thread yong . huang
Changeset: 414384c3b3eb Author:yhuang Date: 2013-04-16 22:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/414384c3b3eb 8011977: ISO 4217 Amendment Number 155 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/tablea1.txt Cha

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread Markus Grönlund
First, I forgot to mention in the original post that parts of this code was contributed-by: Calvin Cheung (calvin.che...@oracle.com) Calvin will be attributed to this fact in a Contributed-by: when this goes back. Now, "I still find it odd that you post the event before the loader constrain