Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

Markus, It looks good. Thanks, Serguei On 4/17/13 10:46 PM, Markus Grönlund wrote: Thanks David and Sergeui, I have added (back) the INCLUDE_TRACE for the load code. Webrev version 5: http://cr.openjdk.java.net/~mgronlun/8012182/webrev05/ BugID: http://bugs.sun.com/bugdatabase/view_bug.do

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

Thanks Serguei, Can I please also get a (R)eviewer for this? Thanks in advance Markus -Original Message- From: Serguei Spitsyn Sent: den 18 april 2013 09:38 To: Markus Grönlund Cc: David Holmes; Karen Kinnear; serviceability-dev@openjdk.java.net; hotspot-gc-...@openjdk.java.net; hotspo

hg: jdk8/tl/jdk: 8011536: (fs) BasicFileAttributes.creationTime() should return birth time (mac)

Changeset: 296c9ec816c6 Author:alanb Date: 2013-04-18 11:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/296c9ec816c6 8011536: (fs) BasicFileAttributes.creationTime() should return birth time (mac) Reviewed-by: chegar ! src/share/classes/java/nio/file/attribute/BasicFileAt

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

Looks good to me. Thanks, David On 18/04/2013 3:46 PM, Markus Grönlund wrote: Thanks David and Sergeui, I have added (back) the INCLUDE_TRACE for the load code. Webrev version 5: http://cr.openjdk.java.net/~mgronlun/8012182/webrev05/ BugID: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

Thank you. /Markus -Original Message- From: David Holmes Sent: den 18 april 2013 12:28 To: Markus Grönlund Cc: Serguei Spitsyn; Karen Kinnear; serviceability-dev@openjdk.java.net; hotspot-gc-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: Re: RFR(M): 8012182: Add inf

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: aa8170c0dec9 Author:sundar Date: 2013-04-15 20:12 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa8170c0dec9 8012240: Array.prototype.map.call({length: -1, get 0(){throw 0}}, function(){}).length does not throw error Reviewed-by: lagergren, jlaskey ! src/jdk

hg: jdk8/tl/jdk: 8009648: Tests fail in -agentvm -concurrency mode

Changeset: 3c8724085cf7 Author:alanb Date: 2013-04-18 12:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c8724085cf7 8009648: Tests fail in -agentvm -concurrency mode Reviewed-by: alanb Contributed-by: roger.ri...@oracle.com ! test/Makefile ! test/java/time/TEST.propertie

Re: RFR: 8004095: Add support for JMX interface to Diagnostic Framework and Commands,

Karen, Thanks for the review, new webrevs are available here: 8004095: http://cr.openjdk.java.net/~fparain/8004095/webrev.05/ 7150256: http://cr.openjdk.java.net/~fparain/7150256/webrev.05/ My answers to your questions are in-lined below: On 10/01/2013 21:28, Karen Kinnear wrote: 1. in the E

Re: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

Hi all, I'm still looking for reviews for this change... Thanks! /peter On 4/3/2013 6:16 PM, Peter Allwin wrote: Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=67

Re: RFR: 7150256: Add back Diagnostic Command JMX API

Mandy, Thanks for the review New webrevs are available here: 7150256: http://cr.openjdk.java.net/~fparain/7150256/webrev.05/ 8004095: http://cr.openjdk.java.net/~fparain/8004095/webrev.05/ My answers to your questions are in-lined below. On 21/12/2012 00:40, Mandy Chung wrote: Hi Frederic,

hg: hsx/hotspot-rt/hotspot: 8012464: NMT: classes should not derive from _ValueObj, use VALUE_OBJ_CLASS_SPEC instead

Changeset: b80cc96882f7 Author:zgu Date: 2013-04-18 10:04 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b80cc96882f7 8012464: NMT: classes should not derive from _ValueObj, use VALUE_OBJ_CLASS_SPEC instead Summary: NMT value objects should use VALUE_OBJ_CLASS_SPE

Re: Review Request: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

+1 On Apr 18, 2013, at 2:07 PM, Mandy Chung wrote: > This fix adds GetSafepointSyncTime.java test in the ProblemList.txt > until 8010897 is resolved. It has been failing intermittently on macosx-x64. > > diff --git a/test/ProblemList.txt b/test/ProblemList.txt > --- a/test/ProblemList.txt > +++ b

Re: Review Request: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

On 18/04/2013 19:07, Mandy Chung wrote: This fix adds GetSafepointSyncTime.java test in the ProblemList.txt until 8010897 is resolved. It has been failing intermittently on macosx-x64. diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.tx

Review Request: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

This fix adds GetSafepointSyncTime.java test in the ProblemList.txt until 8010897 is resolved. It has been failing intermittently on macosx-x64. diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -144,6 +144,9 @@ # jdk_management +

hg: jdk8/tl/jdk: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

Changeset: 32c3a580812b Author:mchung Date: 2013-04-18 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/32c3a580812b 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt Reviewed-by: lancea, alanb ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters

Changeset: 3b81fac25d26 Author:mchung Date: 2013-04-18 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b81fac25d26 8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters Reviewed-by: mchung Contributed-by: Yasumasa Suenaga ! src/share/classes/su

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 41ed397cc0cd Author:bharadwaj Date: 2013-04-18 08:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/41ed397cc0cd 8006267: InterfaceMethod_ref should allow invokestatic and invokespecial Summary: Lambda changes; spec 0.6.2 - Allow static invokestatic and

hg: jdk8/tl/langtools: 8008174: DocTree API should provide start and end positions for tree nodes

Changeset: ed918a442b83 Author:jlahoda Date: 2013-04-17 15:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed918a442b83 8008174: DocTree API should provide start and end positions for tree nodes Summary: Adding DocSourcePositions to allow access to DocTree starting/en

hg: jdk8/tl/jdk: 8012005: LogManager needs test to ensure stack trace is not being done to find bundle

Changeset: 3e4a0fddeb00 Author:jgish Date: 2013-04-18 16:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e4a0fddeb00 8012005: LogManager needs test to ensure stack trace is not being done to find bundle Reviewed-by: mchung + test/java/util/logging/bundlesearch/ClassPathT

Re: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

Hi Peter, On 19/04/2013 12:10 AM, Peter Allwin wrote: Hi all, I'm still looking for reviews for this change... Sounds like a perfectly reasonable change. Reviewed. Thanks, David Thanks! /peter On 4/3/2013 6:16 PM, Peter Allwin wrote: Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/

hg: jdk8/tl/langtools: 8012658: Change default langtools source level to 7

Changeset: 891b88acf47a Author:jjg Date: 2013-04-18 19:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/891b88acf47a 8012658: Change default langtools source level to 7 Reviewed-by: darcy ! make/netbeans/langtools/nbproject/project.xml

hg: jdk8/tl/langtools: 8012656: cache frequently used name strings for DocImpl classes

Changeset: 95d29b99e5b3 Author:jjg Date: 2013-04-18 20:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/95d29b99e5b3 8012656: cache frequently used name strings for DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/sh

[PATCH] EnableTracing prints exact class name

Hi all, Currently EnableTracing prints class information in this way but I don’t think it’s the information that we need: Java Monitor Wait: [Monitor Class = {instance class} - klass: {other class} The method information used to be this way too: Compilation: [Java Method = {method} - klass:

Re: [PATCH] EnableTracing prints exact class name

Hi Yunda, Marcus is already covering this as part of the classload/unload event changes: http://cr.openjdk.java.net/~mgronlun/8012182/webrev05/ Cheers, David On 19/04/2013 1:28 PM, 云达(Yunda) wrote: Hi all, Currently EnableTracing prints class information in this way but I don’t think it’s

RE: [PATCH] EnableTracing prints exact class name

David, Thanks. Sorry that I didn't see Marcus' changes that carefully. Regards, Yunda > -Original Message- > From: David Holmes [mailto:david.hol...@oracle.com] > Sent: Friday, April 19, 2013 12:12 PM > To: 云达(Yunda) > Cc: hotspot-runtime-...@openjdk.java.net; > serviceability-dev@openjd

hg: hsx/hotspot-rt: 12 new changesets

Changeset: fc1e08c2bb27 Author:mduigou Date: 2013-04-01 11:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/fc1e08c2bb27 8010267: Add test-clean for cleaning of testoutput directory from output directory. Add depedency on test-clean to clean Reviewed-by: mchung, tbell !

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b86 for changeset ca71ec37b2ef

Changeset: 9550aab82b5d Author:katleman Date: 2013-04-18 10:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/9550aab82b5d Added tag jdk8-b86 for changeset ca71ec37b2ef ! .hgtags

hg: hsx/hotspot-rt/corba: Added tag jdk8-b86 for changeset 44a8ce4a759f

Changeset: f1709874d55a Author:katleman Date: 2013-04-18 10:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/f1709874d55a Added tag jdk8-b86 for changeset 44a8ce4a759f ! .hgtags

Re: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

Peter, it looks good to me. /R On Apr 19, 2013, at 4:19 AM, David Holmes wrote: > Hi Peter, > > On 19/04/2013 12:10 AM, Peter Allwin wrote: >> Hi all, I'm still looking for reviews for this change... > > Sounds like a perfectly reasonable change. > > Reviewed. > > Thanks, > David > >> Than

hg: hsx/hotspot-rt/jdk: 50 new changesets

Changeset: 87c62f03bc07 Author:jgodinez Date: 2013-03-27 12:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/87c62f03bc07 8010005: [parfait] Memory leak in jdk/src/macosx/native/sun/awt/CTextPipe.m Reviewed-by: bae, prr Contributed-by: jia-hong.c...@oracle.com ! src/

hg: hsx/hotspot-rt/langtools: 22 new changesets

Changeset: 330b35b27e68 Author:darcy Date: 2013-03-26 17:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/330b35b27e68 7041251: Use j.u.Objects utility methods in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/Pair.java ! src/share/clas

hg: hsx/hotspot-rt/nashorn: 33 new changesets

Changeset: 41a212ea8c0c Author:sundar Date: 2013-03-28 20:48 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/41a212ea8c0c 8010924: Dealing with undefined property gets you a fatal stack Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/runtime/resources/mo

hg: jdk8/tl/jdk: 8006935: Need to take care of long secret keys in HMAC/PRF compuation

Changeset: 7bdb3e186497 Author:xuelei Date: 2013-04-18 22:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bdb3e186497 8006935: Need to take care of long secret keys in HMAC/PRF compuation Reviewed-by: valeriep ! src/share/classes/com/sun/crypto/provider/TlsPrfGenerator.ja