RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

Please review the following small fix to avoid exposing an internal representation. webrev: http://cr.openjdk.java.net/~sla/8003671/webrev.00/ bug: http://bugs.sun.com/view_bug.do?bug_id=8003671 Thanks, /Staffan

hg: jdk8/tl/jdk: 8010280: jvm.cfg needs updating for non-server builds

Changeset: 138f767b8eff Author:dholmes Date: 2013-04-29 07:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/138f767b8eff 8010280: jvm.cfg needs updating for non-server builds Summary: Generate jvm.cfg based on chosen VMs for non-"standard" builds and remove legacy entries f

Re: RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

Staffan, 1. bug is not available (yet?) on bugs.sun.com 2. you probably can use arraycopy routine. -Dmitry On 2013-04-29 14:54, Staffan Larsen wrote: > Please review the following small fix to avoid exposing an internal > representation. > > webrev: http://cr.openjdk.java.net/~sla/8003671/webr

Re: RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

On 29 apr 2013, at 14:15, Dmitry Samersoff wrote: > Staffan, > > 1. bug is not available (yet?) on bugs.sun.com It'll probably take a couple of hours (as usual). > 2. you probably can use arraycopy routine. I could, but I stuck to the same code as was already in the class. It's not performa

hg: jdk8/tl/corba: 4504275: CORBA boolean type unions do not generate compilable code from idlj

Changeset: 8f0a461776a9 Author:dmeetry Date: 2013-04-29 16:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8f0a461776a9 4504275: CORBA boolean type unions do not generate compilable code from idlj Summary: JLS doesn't allow boolean type in switch statement, hence substitu

hg: jdk8/tl/corba: 8011986: [corba] idlj generates read/write union helper methods that throw wrong exception in some cases

Changeset: 846aaf02e516 Author:dmeetry Date: 2013-04-29 16:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/846aaf02e516 8011986: [corba] idlj generates read/write union helper methods that throw wrong exception in some cases Reviewed-by: lancea ! src/share/classes/com/s

Re: RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

Staffan, OK. Looks good for me. -Dmitry On 2013-04-29 16:43, Staffan Larsen wrote: > > On 29 apr 2013, at 14:15, Dmitry Samersoff > wrote: > >> Staffan, >> >> 1. bug is not available (yet?) on bugs.sun.com > > It'll probably take a couple of hours (as usual). > >> 2. you probably can use a

Re: RFR: 8012902: remove use of global operator new - take 2

Hi Yumin, I think we need to pull back on this until we can address the broader issues: a) there are a number of classes that don't obey the rules about extending one of the allocation types b) adding additional operator new/new[] for explicit C-Heap usage conflicts with the use of the exi

Re: RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

Staffan, the change looks good, however I would be happy if we actually used the arraycopy instead :) /R On Apr 29, 2013, at 2:43 PM, Staffan Larsen wrote: > > On 29 apr 2013, at 14:15, Dmitry Samersoff > wrote: > >> Staffan, >> >> 1. bug is not available (yet?) on bugs.sun.com > > It'l

Re: RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

Actually, even better alternatives are Arrays.copyOf or array.clone(); /R On Apr 29, 2013, at 3:15 PM, Rickard Bäckman wrote: > Staffan, > > the change looks good, however I would be happy if we actually used the > arraycopy instead :) > > /R > > On Apr 29, 2013, at 2:43 PM, Staffan Larsen

Re: RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

You are right. I was just being lazy. Update webrev: http://cr.openjdk.java.net/~sla/8003671/webrev.01/ Thanks, /Staffan On 29 apr 2013, at 15:43, Rickard Bäckman wrote: > Actually, even better alternatives are Arrays.copyOf or array.clone(); > > /R > > On Apr 29, 2013, at 3:15 PM, Rickard B

RFR (S): 8013466 SA crashes when attaching to a process on OS X

Please review this small fix of additional NULL-checks in SA on OS X. webrev: http://cr.openjdk.java.net/~sla/8013466/webrev.00/ Thanks, /Staffan

RFR(XS): 8013364 SA-JDI exceptions caused by lack of permissions on OSX should be more verbose about issue cause

Hi, This is an improvement to the error message the user receives when SA attach fails on OS X. The current message is: attach: task_for_pid(13581) failed (5) Error attaching to process: sun.jvm.hotspot.debugger.DebuggerException: Can't attach to the process This is changed to: ERROR: atta

Re: RFR (S): 8013466 SA crashes when attaching to a process on OS X

Looks good, thanks for the fix. /Yumin On 4/29/2013 7:34 AM, Staffan Larsen wrote: Please review this small fix of additional NULL-checks in SA on OS X. webrev: http://cr.openjdk.java.net/~sla/8013466/webrev.00/ Thanks, /Staffan

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 9d324d667bb3 Author:jzavgren Date: 2013-04-29 08:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d324d667bb3 8012108: Memory leak in jdk/src/windows/native/java/net/NetworkInterface_winXP.c Summary: Modified code to fix this leak and then proactively fixed impro

Re: RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

On 4/29/13 7:09 AM, Staffan Larsen wrote: You are right. I was just being lazy. Update webrev: http://cr.openjdk.java.net/~sla/8003671/webrev.01/ This change looks fine to me. Mandy Thanks, /Staffan On 29 apr 2013, at 15:43, Rickard Bäckman wrote: Actually, even better alternatives are

hg: hsx/hotspot-rt/hotspot: 8007154: Remove support for u4 MethodParameter flags fields

Changeset: d1644a010f52 Author:emc Date: 2013-04-26 07:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d1644a010f52 8007154: Remove support for u4 MethodParameter flags fields Summary: Remove support for parsing class files with four-byte flags fields in MethodP

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: f258c5828eb8 Author:hseigel Date: 2013-04-29 16:13 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f258c5828eb8 8011773: Some tests on Interned String crashed JVM with OOM Summary: Instead of terminating the VM, throw OutOfMemoryError exceptions. Reviewed

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 7857129859bd Author:briangoetz Date: 2013-04-20 18:53 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7857129859bd 8012650: Arrays streams methods 8011918: java.util.stream.Streams Reviewed-by: alanb, mduigou, darcy, henryjen Contributed-by: brian.go...@oracle.com,

hg: hsx/hotspot-rt/hotspot: 8012015: Use PROT_NONE when reserving memory

Changeset: f32b6c267d2e Author:mikael Date: 2013-04-29 11:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f32b6c267d2e 8012015: Use PROT_NONE when reserving memory Summary: Reserved memory had PROT_READ+PROT_WRITE access on Linux/bsd, now changed to PROT_NONE. R

Re: RFR (XS): [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params

Staffan, much better! Ship it. /R On Apr 29, 2013, at 4:09 PM, Staffan Larsen wrote: > You are right. I was just being lazy. > > Update webrev: http://cr.openjdk.java.net/~sla/8003671/webrev.01/ > > Thanks, > /Staffan > > On 29 apr 2013, at 15:43, Rickard Bäckman wrote: > >> Actually, eve

Re: RFR(XS): 8013364 SA-JDI exceptions caused by lack of permissions on OSX should be more verbose about issue cause

Staffan, this change looks good. (Not a Reviewer). /R On Apr 29, 2013, at 4:40 PM, Staffan Larsen wrote: > Hi, > > This is an improvement to the error message the user receives when SA attach > fails on OS X. The current message is: > > > attach: task_for_pid(13581) failed (5) > Error attac

Re: RFR (S): 8013466 SA crashes when attaching to a process on OS X

Looks good (Not a Reviewer). /R On Apr 29, 2013, at 4:34 PM, Staffan Larsen wrote: > Please review this small fix of additional NULL-checks in SA on OS X. > > webrev: http://cr.openjdk.java.net/~sla/8013466/webrev.00/ > > Thanks, > /Staffan >