hg: hsx/hotspot-rt/hotspot: 46 new changesets

2013-05-03 Thread daniel . daugherty
Changeset: a6e09d6dd8e5 Author:dlong Date: 2013-04-24 20:55 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a6e09d6dd8e5 8003853: specify offset of IC load in java_to_interp stub Summary: refactored code to allow platform-specific differences Reviewed-by: dlong, twi

hg: jdk8/tl/langtools: 8008768: Using {@inheritDoc} in simple tag defined via -tag fails

2013-05-03 Thread jonathan . gibbons
Changeset: d918b63a5509 Author:jjg Date: 2013-05-03 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d918b63a5509 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Reviewed-by: jjg, mduigou Contributed-by: jonathan.gibb...@oracle.com, mike.dui...@ora

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-03 Thread zhengyu . gu
Changeset: bf089b838c9e Author:ccheung Date: 2013-05-02 16:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bf089b838c9e 8012641: Perf_CreateLong creates perf counter of incorrect type Reviewed-by: mchung, hseigel, coleenp ! src/share/vm/prims/perf.cpp Changeset

hg: jdk8/tl/jdk: 8005922: TEST_BUG: There is no /tmp directory for windows system.

2013-05-03 Thread jason . uh
Changeset: d7f3d5659c46 Author:juh Date: 2013-05-03 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d7f3d5659c46 8005922: TEST_BUG: There is no /tmp directory for windows system. Reviewed-by: weijun ! test/sun/security/tools/policytool/ChangeUI.html ! test/sun/security/

hg: jdk8/tl/jdk: 8013528: Provide SharedSecrets access to String(char[], boolean) constructor

2013-05-03 Thread mike . duigou
Changeset: fc156b925259 Author:mduigou Date: 2013-05-03 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc156b925259 8013528: Provide SharedSecrets access to String(char[], boolean) constructor Reviewed-by: martin, alanb, chegar, plevart ! src/share/classes/java/lang/Sy

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-03 Thread frederic . parain
Changeset: 31a4e55f8c9d Author:fparain Date: 2013-05-03 05:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/31a4e55f8c9d 8004095: Add support for JMX interface to Diagnostic Framework and Commands Reviewed-by: acorn, sla ! src/share/vm/classfile/vmSymbols.hpp ! s

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread frederic parain
You're right. I'll update setAttributes() to return an empty AttributeList. Fred On 03/05/2013 20:53, Mandy Chung wrote: DynamicMBean: public AttributeList setAttributes(AttributeList attributes); Maybe you looked at setAttribute method. It's easily misread with and without 's'. On 5/3/

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread Mandy Chung
DynamicMBean: public AttributeList setAttributes(AttributeList attributes); Maybe you looked at setAttribute method. It's easily misread with and without 's'. On 5/3/2013 11:40 AM, frederic parain wrote: MBeanServer.setAttributes() returns an AttributeList but the return type of DynamicM

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread frederic parain
MBeanServer.setAttributes() returns an AttributeList but the return type of DynamicMBean.setAttributes() is void. Does it mean that in our case, setAttributes() should simply be a no-op method? Fred On 03/05/2013 20:19, Daniel Fuchs wrote: Hi, On 5/3/13 8:02 PM, Mandy Chung wrote: 2. Investig

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread frederic parain
Thank you Mandy, I'll file the bugs and fix the exception cause. Fred On 03/05/2013 20:02, Mandy Chung wrote: Frederic, This looks good. Thanks for the update and also move the native method and implementations to DiagnosticCommandImpl.c and removing the check for rdcmd_support which is much

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread Mandy Chung
On 5/3/2013 11:19 AM, Daniel Fuchs wrote: Hi, On 5/3/13 8:02 PM, Mandy Chung wrote: 2. Investigate what DiagnosticCommandImpl.getAttributes and setAttributes should do per DynamicMBean spec. The current implementation throws UOE which seem to be okay. It's good to confirm what is specified or

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread frederic parain
I'll fix it and file a new bug. Fred On 03/05/2013 20:30, Mandy Chung wrote: On 5/3/2013 11:19 AM, Daniel Fuchs wrote: Hi, On 5/3/13 8:02 PM, Mandy Chung wrote: 2. Investigate what DiagnosticCommandImpl.getAttributes and setAttributes should do per DynamicMBean spec. The current implementat

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread Daniel Fuchs
Hi, On 5/3/13 8:02 PM, Mandy Chung wrote: 2. Investigate what DiagnosticCommandImpl.getAttributes and setAttributes should do per DynamicMBean spec. The current implementation throws UOE which seem to be okay. It's good to confirm what is specified or not specified per DynamicMBean spec By a

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread Mandy Chung
Frederic, This looks good. Thanks for the update and also move the native method and implementations to DiagnosticCommandImpl.c and removing the check for rdcmd_support which is much cleaner. Minor comment: DiagnosticCommandImpl.Wrapper constructor - it'd be good to catch the exception causi

hg: jdk8/tl/langtools: 8002387: Improve rendered HTML formatting for {@code}

2013-05-03 Thread jonathan . gibbons
Changeset: 38c4bade0ec1 Author:jjg Date: 2013-05-03 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38c4bade0ec1 8002387: Improve rendered HTML formatting for {@code} Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javadoc/Comment.java + test/com/sun/javadoc

hg: jdk8/tl/langtools: 8012728: Normalize @ignore comments on langtools tests

2013-05-03 Thread jonathan . gibbons
Changeset: abd153854f16 Author:jjg Date: 2013-05-03 09:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abd153854f16 8012728: Normalize @ignore comments on langtools tests Reviewed-by: vromero, mcimadamore ! test/com/sun/javadoc/_template/Template.java ! test/com/sun/

Re: RFR: 7150256: Add back Diagnostic Command JMX API

2013-05-03 Thread frederic parain
Hi all, After an intense work with Mandy, here's a new webrev which fix the issue with the PlatformManagedObject specification. The DiagnosticCommandMBean is not a PlatformManagedObject anymore, it's just a DynamicMBean registered to the platform MBean server. Many smaller fixes have also been do

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-05-03 Thread Daniel Fuchs
Hi Jaroslav, In Client.java - you could consider replacing the AtomicLong with a CountDownLatch. This would allow you to remove the various Thread.sleep() in the code (in particular the one at the end). You could use CountDownLatch.await(long timeout, TimeUnit unit) to avoid waiting for ever in

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-05-03 Thread Jaroslav Bachorik
Please re-review the updated webrev http://cr.openjdk.java.net/~jbachorik/8005472/webrev.06 I've replaced the shell script with the plain java test. The javac API is used to compile the the auxiliary classes as was recommended. This allowed to simplify the test. The test does not check for a cert

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-03 Thread staffan . larsen
Changeset: c456f4510385 Author:sla Date: 2013-05-03 12:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385 8008453: JvmtiClassFileReconstituter does not recognize default methods Reviewed-by: acorn, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstitu

hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b88 for changeset 40c107d1ae6f

2013-05-03 Thread john . coomes
Changeset: 501bc4aeb1b1 Author:katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/501bc4aeb1b1 Added tag jdk8-b88 for changeset 40c107d1ae6f ! .hgtags

hg: hsx/hotspot-rt/langtools: Added tag jdk8-b88 for changeset a1e10f3adc47

2013-05-03 Thread john . coomes
Changeset: adec2a5d510a Author:katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/adec2a5d510a Added tag jdk8-b88 for changeset a1e10f3adc47 ! .hgtags

hg: hsx/hotspot-rt/jdk: 8 new changesets

2013-05-03 Thread john . coomes
Changeset: 78d08fc2dd12 Author:mullan Date: 2013-04-25 11:18 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/78d08fc2dd12 8011313: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout not defined Reviewed-by: vinnie ! src/share/classes/sun/security/provide

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b88 for changeset 24fa5452e5d4

2013-05-03 Thread john . coomes
Changeset: 88838e08e4ef Author:katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/88838e08e4ef Added tag jdk8-b88 for changeset 24fa5452e5d4 ! .hgtags

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b88 for changeset 7122f7bb0fcc

2013-05-03 Thread john . coomes
Changeset: 21f75e572cb3 Author:katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/21f75e572cb3 Added tag jdk8-b88 for changeset 7122f7bb0fcc ! .hgtags

hg: hsx/hotspot-rt: 6 new changesets

2013-05-03 Thread john . coomes
Changeset: 1dfcc874461e Author:omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1dfcc874461e 8013480: fix zero build on arm Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in

hg: hsx/hotspot-rt/corba: Added tag jdk8-b88 for changeset 4e3a881ebb1e

2013-05-03 Thread john . coomes
Changeset: 1f13a798d1b8 Author:katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/1f13a798d1b8 Added tag jdk8-b88 for changeset 4e3a881ebb1e ! .hgtags

Re: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException

2013-05-03 Thread Kevin Walls
Thanks Staffan, thanks Peter! On 02/05/13 14:11, Peter Allwin wrote: Hi Kevin, Looks good! I've been looking into improving the quality of native stack traces on Windows using IDebugControl::GetStackTrace. This has the