hg: jdk8/tl/jaxp: 8012683: Remove unused, obsolete ObjectFactory classes

2013-05-20 Thread huizhe . wang
Changeset: 37b73984640a Author:joehw Date: 2013-05-20 23:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/37b73984640a 8012683: Remove unused, obsolete ObjectFactory classes Reviewed-by: lancea - src/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/com/

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-20 Thread Staffan Larsen
On 21 maj 2013, at 04:34, David Holmes wrote: > > > Hi Joe, > > As I have previously stated you copied the struct definitions instead of > moving them outside the ifdef. > > Serviceability folk: we are particularly interested in whether the use of > ticks_no_class_load is deemed appropriat

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread David Holmes
On 21/05/2013 2:50 PM, Dean Long wrote: Right, unless there is a way to inject them conditionally. You can inject them conditionally based on the JRE version, but then why bother moving to the Java level if you will still need the code in the VM ? On 5/20/2013 9:02 PM, Ioi Lam wrote: But i

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
Right, unless there is a way to inject them conditionally. dl On 5/20/2013 9:02 PM, Ioi Lam wrote: But if you move these fields into Class.java (in JDK8), then hsx25 will not run on JDK7 anymore, unless these fields are also added in Class.java in JDK7. - Ioi On 05/20/2013 05:42 PM, Dean Lo

hg: hsx/hotspot-rt/hotspot: 8014878: Clean up class field layout code

2013-05-20 Thread vladimir . kozlov
Changeset: bbddfb08190f Author:shade Date: 2013-05-20 23:41 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bbddfb08190f 8014878: Clean up class field layout code Summary: rename/remove local variables, re-arrange instance_size calculation, more comments. Reviewed-

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Ioi Lam
But if you move these fields into Class.java (in JDK8), then hsx25 will not run on JDK7 anymore, unless these fields are also added in Class.java in JDK7. - Ioi On 05/20/2013 05:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of java.lang.Cl

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread David Holmes
On 21/05/2013 12:50 PM, Coleen Phillimore wrote: On 5/20/2013 8:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. We actual

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
On 5/20/2013 7:50 PM, Coleen Phillimore wrote: On 5/20/2013 8:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. We actuall

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread David Holmes
Hi Coleen, On 21/05/2013 8:39 AM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers, init_lock into java_lang_Class Basic VM changes look fine to me. Net footprint change is zero except that these fields are in Java heap rather than metaspace. This helps a little with Inst

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Coleen Phillimore
On 5/20/2013 8:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. We actually use the protection domain and init_lock from w

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-20 Thread David Holmes
Hi Joe, As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? Thanks,

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. dl On 05/20/2013 03:39 PM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers, i

hg: jdk8/tl/jaxp: 8014891: Redundant setting of external access properties in setFeatures

2013-05-20 Thread huizhe . wang
Changeset: a7cec93e4682 Author:joehw Date: 2013-05-20 16:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a7cec93e4682 8014891: Redundant setting of external access properties in setFeatures Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderI

RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Coleen Phillimore
Summary: Inject protection_domain, signers, init_lock into java_lang_Class Net footprint change is zero except that these fields are in Java heap rather than metaspace. This helps a little with InstanceKlass size which is in fixed size space with UseCompressedKlassPointers. Included serviceab

hg: jdk8/tl/jdk: 8004789: (zipfs) zip provider doesn't work correctly with file systems providers rather than the default

2013-05-20 Thread xueming . shen
Changeset: 6a9148865139 Author:sherman Date: 2013-05-20 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a9148865139 8004789: (zipfs) zip provider doesn't work correctly with file systems providers rather than the default Summary: to use Files.createTempFile(...) to cre

hg: hsx/hotspot-rt/hotspot: 8014871: Move @Contended regression tests to the same place

2013-05-20 Thread david . holmes
Changeset: 5e3573e08a83 Author:shade Date: 2013-05-20 15:43 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5e3573e08a83 8014871: Move @Contended regression tests to the same place Summary: Move the missing test to appropriate location. Reviewed-by: dholmes, sla -

hg: jdk8/tl/nashorn: 15 new changesets

2013-05-20 Thread sundararajan . athijegannathan
Changeset: 80d4db063d5a Author:jlaskey Date: 2013-05-14 11:15 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/80d4db063d5a 8014512: Exclude testing and infrastructure packages from code coverage Reviewed-by: sundar Contributed-by: james.las...@oracle.com ! make/code_cover