Changeset: 6c138b9851fb
Author:sspitsyn
Date: 2013-05-24 17:36 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6c138b9851fb
8013945: CMS fatal error: must own lock MemberNameTable_lock
Summary: The "delete mnt" needs to grab MemberNameTable_lock if
!SafepointSynchr
Changeset: 5e769206f036
Author:ksrini
Date: 2013-05-24 17:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e769206f036
8007333: [launcher] removes multiple back slashes
Reviewed-by: alanb, akhil
! src/windows/bin/cmdtoargs.c
! test/tools/launcher/Arrrghs.java
Changeset: 293b99787401
Author:dholmes
Date: 2013-05-14 07:24 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/293b99787401
8014460: Need to check for non-empty EXT_LIBS_PATH before using it
Reviewed-by: tbell, collins, sla, coleenp
! make/bsd/makefiles/arm.make
! m
Changeset: 0f8e9a0e5d9a
Author:darcy
Date: 2013-05-24 11:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f8e9a0e5d9a
8014836: Have GenericDeclaration extend AnnotatedElement
Reviewed-by: jfranck
! src/share/sample/language/model/CoreReflectionFactory.java
Webrev with the fix suggested by Mikael G. :
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.2/
I'm going to integrate it after testing, but a couple of extra eyes to
double-check it would be nice.
Thanks,
Serguei
On 5/24/13 2:29 AM, serguei.spit...@oracle.c
Ok, thank you for the review!
Serguei
On 5/24/13 3:56 AM, David Holmes wrote:
Sorry just saw Mikael already suggested this. :)
David
On 24/05/2013 8:54 PM, David Holmes wrote:
Hi Serguei,
You can avoid the code duplication if you use the safepoint check to
assign either the MemberNameTable_l
Looks good, but the indentation is wrong in one place.
/Staffan
On 24 maj 2013, at 16:13, Nils Loodin wrote:
> Simple fix not to add a confusing dialog.
>
> Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
>
> Webrev:
> http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
>
> Regards,
>
Looks good! (not a reviewer)
Nils Loodin skrev 2013-05-24 16:13:
Simple fix not to add a confusing dialog.
Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
Webrev:
http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
Regards,
Nils Loodin
On 2013-05-24 16:13, Nils Loodin wrote:
Simple fix not to add a confusing dialog.
Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
Webrev:
http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
Fix looks simple and good to me. However, I don't have my OpenJDK
username yet, so this might n
Changeset: 58329d9f6b68
Author:mcimadamore
Date: 2013-05-24 15:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58329d9f6b68
8014643: Parser regression in JDK 8 when compiling super.x
Summary: Fixed latent bug in JavacParser.analyzeParens()
Reviewed-by: jjg, vromero
!
Wrong link:
On 05/24/2013 04:13 PM, Nils Loodin wrote:
Simple fix not to add a confusing dialog.
Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
This should be http://bugs.sun.com/view_bug.do?bug_id=6470730
Webrev:
http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
Regards,
Nils Lo
Simple fix not to add a confusing dialog.
Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730
Webrev:
http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/
Regards,
Nils Loodin
Mikael,
I like your suggestion, will send new webrev tomorrow.
Thank you for the review!
Serguei
On 5/24/13 3:29 AM, Mikael Gerdin wrote:
Serguei,
On 2013-05-24 11:29, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
jbs:
Sorry just saw Mikael already suggested this. :)
David
On 24/05/2013 8:54 PM, David Holmes wrote:
Hi Serguei,
You can avoid the code duplication if you use the safepoint check to
assign either the MemberNameTable_lock or NULL to a Mutex variable:
Mutex* lock = (atsafepoint ? NULL : MemberName
Hi Serguei,
You can avoid the code duplication if you use the safepoint check to
assign either the MemberNameTable_lock or NULL to a Mutex variable:
Mutex* lock = (atsafepoint ? NULL : MemberNameTable_lock);
{
MutexLockerEx ml(lock, ...);
...
}
David
On 24/05/2013 7:29 PM, serguei.spit
Serguei,
On 2013-05-24 11:29, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1
Thanks, Staffan!
Serguei
On 5/24/13 3:22 AM, Staffan Larsen wrote:
Looks good!
/Staffan
On 24 maj 2013, at 11:29, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
Open we
Looks good!
/Staffan
On 24 maj 2013, at 11:29, serguei.spit...@oracle.com wrote:
> Please, review the fix for:
> bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
> jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotsp
Please, review the fix for:
bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/
Summary:
CMS calls InstanceKlass::release_C_heap_structures() c
Changeset: b7fa10a3a69a
Author:sspitsyn
Date: 2013-05-23 23:04 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b7fa10a3a69a
8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes
Summary: The fix of perf regression is to use method_idnum() for
20 matches
Mail list logo
