hg: jdk8/tl/jdk: 8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently

2013-05-28 Thread dan . xu
Changeset: e59d7f0f36f7 Author:ewang Date: 2013-05-28 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e59d7f0f36f7 8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently Reviewed-by: dxu, alanb Contributed-by: yiming.w...@oracle.com ! test/java/io/pa

hg: hsx/hotspot-rt/hotspot: 8014912: Restore PrintSharedSpaces functionality after NPG

2013-05-28 Thread ioi . lam
Changeset: a1ebd310d5c1 Author:iklam Date: 2013-05-28 16:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1ebd310d5c1 8014912: Restore PrintSharedSpaces functionality after NPG Summary: Added dumping of object sizes in CDS archive, sorted by MetaspaceObj::Type R

Re: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

2013-05-28 Thread David Holmes
On 28/05/2013 11:13 PM, Jaroslav Bachorik wrote: Please, review the fix for JDK-8002307. The fix assures the immutability by cloning the provided arrays in the constructor and then cloning them again in the getters. This fix has the same problems/issues as 8010815: http://mail.openjdk.java.ne

hg: jdk8/tl/jdk: 6251788: (rb) PropertyResourceBundle doesn't document exceptions

2013-05-28 Thread naoto . sato
Changeset: b99d56d1aa3f Author:naoto Date: 2013-05-28 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b99d56d1aa3f 6251788: (rb) PropertyResourceBundle doesn't document exceptions Reviewed-by: okutsu ! src/share/classes/java/util/PropertyResourceBundle.java

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-28 Thread daniel . daugherty
Changeset: 01c2bdd24bb5 Author:shade Date: 2013-05-28 19:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/01c2bdd24bb5 8015493: runtime/contended/OopMaps.java fails with OutOfMemory Summary: limit the memory footprint to dodge OutOfMemory errors. Reviewed-by: dcub

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-28 Thread Jaroslav Bachorik
And the webrev would come handy, of course. http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ -JB- On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: > The fix enforces the management interfaces (read MBean and MXBean > interfaces) being public. While this is defined in the specification it

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-28 Thread zhengyu . gu
Changeset: 51af5fae397d Author:ccheung Date: 2013-05-24 17:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/51af5fae397d 8015265: revise the fix for 8007037 Reviewed-by: sspitsyn, dholmes, dcubed ! src/share/vm/oops/constantPool.cpp Changeset: 4cc7d4d5dc92 Autho

Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

2013-05-28 Thread Mandy Chung
Good catch. Looks good. There are other j.l.management tests that force GC to happen and I'm not sure if any of them requires similar fix. Might be worth to check if any of them has similar assumption. Mandy On 5/28/13 1:11 AM, Staffan Larsen wrote: Please review the following fix: webrev

hg: jdk8/tl/jdk: 8001750: CharsetDecoder.replacement should not be changeable except via replaceWith method

2013-05-28 Thread xueming . shen
Changeset: 7fa2d1dcb8f6 Author:sherman Date: 2013-05-28 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fa2d1dcb8f6 8001750: CharsetDecoder.replacement should not be changeable except via replaceWith method Summary: to make defensive copy for set/get replacement byte a

hg: jdk8/tl/langtools: 8012333: javac, ClassFile should have a read(Path) method

2013-05-28 Thread vicente . romero
Changeset: d042cba65eab Author:vromero Date: 2013-05-28 17:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d042cba65eab 8012333: javac, ClassFile should have a read(Path) method Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/ClassFile.java

hg: hsx/hotspot-rt/hotspot: 8015329: Print reason for failed MiniDumpWriteDump() call

2013-05-28 Thread christian . tornqvist
Changeset: a213d425d87a Author:ctornqvi Date: 2013-05-28 15:08 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a213d425d87a 8015329: Print reason for failed MiniDumpWriteDump() call Summary: Printing both result from GetLastError and text representation of error. A

hg: jdk8/tl/jdk: 7038105: File.isHidden() should return true for pagefile.sys and hiberfil.sys

2013-05-28 Thread rob . mckenna
Changeset: b16a8b4ae6b4 Author:robm Date: 2013-05-28 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b16a8b4ae6b4 7038105: File.isHidden() should return true for pagefile.sys and hiberfil.sys Reviewed-by: alanb ! src/windows/native/java/io/WinNTFileSystem_md.c ! test/ja

Re: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

2013-05-28 Thread Peter Allwin
Hi Jaroslav, Just one comment, should we get rid of the static empty arrays in ModelMBeanInfoSupport.java now that they're not in use? 343 private static final ModelMBeanAttributeInfo[] NO_ATTRIBUTES = 344 new ModelMBeanAttributeInfo[0]; 345 private static final ModelMBea

hg: jdk8/tl/jdk: 8014420: Default JDP address does not match the one assigned by IANA

2013-05-28 Thread dmitry . samersoff
Changeset: 7d7bfce34a79 Author:dsamersoff Date: 2013-05-28 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7bfce34a79 8014420: Default JDP address does not match the one assigned by IANA Summary: JDP protocol defaults changed to IANA assigned values Reviewed-by: dholme

RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-28 Thread Jaroslav Bachorik
The fix enforces the management interfaces (read MBean and MXBean interfaces) being public. While this is defined in the specification it was not enforced in any way and it was allowed to create MBeans for eg. private MBean interfaces. The fix adds checks when creating and registering MBeans and t

hg: jdk8/tl/jdk: 8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-05-28 Thread jaroslav . bachorik
Changeset: 7d9fab5d86cd Author:jbachorik Date: 2013-05-28 15:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d9fab5d86cd 8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows Reviewed-by: chegar, smarks, dfuchs ! test/Pro

RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

2013-05-28 Thread Jaroslav Bachorik
Please, review the fix for JDK-8002307. The fix assures the immutability by cloning the provided arrays in the constructor and then cloning them again in the getters. The constructors are fixed in the javax/management/MBeanInfo.java and the arrays used in getters are cloned using an already exist

hg: jdk8/tl/langtools: 6970173: Debug pointer at bad position

2013-05-28 Thread vicente . romero
Changeset: c6df5b20f9eb Author:vromero Date: 2013-05-28 12:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c6df5b20f9eb 6970173: Debug pointer at bad position Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T6970173

Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

2013-05-28 Thread Bengt Rutisson
On 5/28/13 10:56 AM, Staffan Larsen wrote: On 28 maj 2013, at 10:34, Bengt Rutisson wrote: Staffan, Looks good. One minor question: Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount into the existing comment section rather than adding a new section for it? I th

Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

2013-05-28 Thread Staffan Larsen
On 28 maj 2013, at 10:34, Bengt Rutisson wrote: > > Staffan, > > Looks good. > > One minor question: > > Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount > into the existing comment section rather than adding a new section for it? I > think it might increase th

Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

2013-05-28 Thread Peter Allwin
Looking good to me. /peter - Original Message - From: nils.loo...@oracle.com To: serviceability-dev@openjdk.java.net Sent: Tuesday, May 28, 2013 10:36:20 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/R

Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

2013-05-28 Thread Bengt Rutisson
Staffan, Looks good. One minor question: Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount into the existing comment section rather than adding a new section for it? I think it might increase the chances that someone reads the comment if it is closer to the @run

Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

2013-05-28 Thread Nils Loodin
Looks good. /Nisse On 05/28/2013 10:11 AM, Staffan Larsen wrote: Please review the following fix: webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 The problem is that serial gc does not compact the heap at every full gc

RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

2013-05-28 Thread Staffan Larsen
Please review the following fix: webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 The problem is that serial gc does not compact the heap at every full gc but only every 4th full gc (by default). When the heap isn't compac