Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds

2013-05-29 Thread serguei.spit...@oracle.com
Please, review the fix and unit test for: bug: http://bugs.sun.com/view_bug.do?bug_id=8015436 jbs: https://jbs.oracle.com/bugs/browse/JDK-8015436 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1 Summary: The InstanceKlass _initial_method_idnum

hg: jdk8/tl/jdk: 4759491: method ZipEntry.setTime(long) works incorrectly; ...

2013-05-29 Thread xueming . shen
Changeset: 90df6756406f Author:sherman Date: 2013-05-29 19:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90df6756406f 4759491: method ZipEntry.setTime(long) works incorrectly 6303183: Support NTFS and Unix-style timestamps for entries in Zip files 7012856: (zipfs) Newly c

hg: jdk8/tl/langtools: 8015641: genstubs needs to cope with static interface methods

2013-05-29 Thread jonathan . gibbons
Changeset: d685b12b62a4 Author:jjg Date: 2013-05-29 15:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d685b12b62a4 8015641: genstubs needs to cope with static interface methods Reviewed-by: ksrini ! make/tools/genstubs/GenStubs.java

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Daniel Fuchs
On 5/29/13 7:17 PM, Jaroslav Bachorik wrote: On Wed 29 May 2013 05:33:21 PM CEST, Eamonn McManus wrote: I would recommend against changing the code to do additional calls to Class.forName during MBean introspection. As I recall we made the opposite change some years ago, both because Class.forNa

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Jaroslav Bachorik
On Wed 29 May 2013 05:33:21 PM CEST, Eamonn McManus wrote: > I would recommend against changing the code to do additional calls to > Class.forName during MBean introspection. As I recall we made the > opposite change some years ago, both because Class.forName can be slow > (it may call out to a use

hg: jdk8/tl/nashorn: 9 new changesets

2013-05-29 Thread james . laskey
Changeset: 0bf451c0678d Author:hannesw Date: 2013-05-27 12:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0bf451c0678d 8015348: RegExp("[") results in StackOverflowError Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/sc

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Eamonn McManus
I would recommend against changing the code to do additional calls to Class.forName during MBean introspection. As I recall we made the opposite change some years ago, both because Class.forName can be slow (it may call out to a user ClassLoader) and because it is a potential source of security pro

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Jaroslav Bachorik
Updated webrev - http://cr.openjdk.java.net/~jbachorik/8010285/webrev.01 It adds regtests and takes care of the comments from David and Shanliang. -JB- On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: > The fix enforces the management interfaces (read MBean and MXBean > interfaces) being public.

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Daniel Fuchs
On 5/29/13 4:44 PM, Jaroslav Bachorik wrote: On Wed 29 May 2013 03:38:59 PM CEST, Daniel Fuchs wrote: On 5/29/13 1:18 PM, shanliang wrote: Jaroslav, Introspector.java - Line 496 - 515 It is good to do check: (Modifier.isPublic(c.getModifiers()) || MBeanAnalyzer.ALLOW_

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Jaroslav Bachorik
On Wed 29 May 2013 03:38:59 PM CEST, Daniel Fuchs wrote: > On 5/29/13 1:18 PM, shanliang wrote: >> Jaroslav, >> >> Introspector.java >> - >> Line 496 - 515 >> It is good to do check: >> (Modifier.isPublic(c.getModifiers()) || >> MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) >> but i

hg: jdk8/tl/jdk: 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate

2013-05-29 Thread vincent . x . ryan
Changeset: 00ad19610e75 Author:vinnie Date: 2013-05-29 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00ad19610e75 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate Reviewed-by: xuelei ! src/share/classes/sun/security/provider/ce

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Daniel Fuchs
On 5/29/13 1:18 PM, shanliang wrote: Jaroslav, Introspector.java - Line 496 - 515 It is good to do check: (Modifier.isPublic(c.getModifiers()) || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) but it is not necessary if an interface is not equal to clMBeanName. is it possible to

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Jaroslav Bachorik
On Wed 29 May 2013 01:18:50 PM CEST, shanliang wrote: > Jaroslav, > > Introspector.java > - > Line 496 - 515 > It is good to do check: > (Modifier.isPublic(c.getModifiers()) || > MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) > but it is not necessary if an interface is not equal to c

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread shanliang
Jaroslav, Introspector.java - Line 496 - 515 It is good to do check: (Modifier.isPublic(c.getModifiers()) || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) but it is not necessary if an interface is not equal to clMBeanName. is it possible to simplify the method as: private st

hg: jdk8/tl/langtools: 7053059: VerifyError with double Assignment using a Generic Member of a Superclass

2013-05-29 Thread vicente . romero
Changeset: 92e420e9807d Author:vromero Date: 2013-05-29 10:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/92e420e9807d 7053059: VerifyError with double Assignment using a Generic Member of a Superclass Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/java

hg: jdk8/tl/jdk: 8014928: (fs) Files.readAllBytes() copies content to new array when content completely read

2013-05-29 Thread alan . bateman
Changeset: 2b3242a69a44 Author:alanb Date: 2013-05-29 10:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b3242a69a44 8014928: (fs) Files.readAllBytes() copies content to new array when content completely read Reviewed-by: martin ! src/share/classes/java/nio/file/Files.ja

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread Jaroslav Bachorik
On Wed 29 May 2013 10:09:38 AM CEST, David Holmes wrote: > Hi Jaroslav, > > Just wondering why this needs to be public: > > + public static void testComplianceMBeanInterface(Class > interfaceClass) > + throws NotCompliantMBeanException{ > + StandardMBeanIntrospector.getInstance().ge

RFR: 8013590: NPG: Add a memory pool MXBean for Metaspace

2013-05-29 Thread Erik Helin
Hi all, this want sent to hotspot-gc-...@openjdk.java.net, sending to serviceability-dev@openjdk.java.net as well since the change is about memory pools. This change adds two memory pools for metaspace, one for Metaspace and one for compressed klass space. The memory pool for compressed klass spa

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-05-29 Thread David Holmes
Hi Jaroslav, Just wondering why this needs to be public: + public static void testComplianceMBeanInterface(Class interfaceClass) + throws NotCompliantMBeanException{ + StandardMBeanIntrospector.getInstance().getAnalyzer(interfaceClass); + } Same question goes for the exi

hg: jdk8/tl/jdk: 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException

2013-05-29 Thread staffan . larsen
Changeset: bd6d3801347b Author:sla Date: 2013-05-29 09:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6d3801347b 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Summary: Make sure serial gc compacts heap every time Review