RFR(XXS): 8015856 Remove java/lang/instrument/IsModifiableClassAgent.java from ProblemList.txt

2013-06-04 Thread Staffan Larsen
The problem was fixed in JDK-8009615 and the fix is now available in the TL forest. See diff below. Thanks, /Staffan diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -122,9 +122,6 @@ # jdk_lang -# 8009615

Re: RFR - 6526682: JConsole shows negative CPU Usage

2013-06-04 Thread Staffan Larsen
I agree with Erik that this will just be hiding another problem (and making that problem harder to find). /Staffan On 1 jun 2013, at 10:06, Erik Gahlin erik.gah...@oracle.com wrote: Nils, do you know why you get a negative number? As I remember it, the MBean returns -1 if the value is not

Re: URGENT: RR(XS):8015604 JDP packets containing ideographic characters are broken

2013-06-04 Thread Peter Allwin
Agreed, we should at least check that the byte length = 0x (which writeUTF will do for us). Other than that it looks good! /peter - Original Message - From: staffan.lar...@oracle.com To: dmitry.samers...@oracle.com Cc: serviceability-dev@openjdk.java.net Sent: Tuesday, June 4, 2013

hg: jdk8/tl/jdk: 8005698: Handle Frequent HashMap Collisions with Balanced Trees

2013-06-04 Thread alan . bateman
Changeset: 5223d3228658 Author:bchristi Date: 2013-06-04 10:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5223d3228658 8005698: Handle Frequent HashMap Collisions with Balanced Trees Summary: HashMap bins with many collisions store entries in balanced trees Reviewed-by:

Re: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

2013-06-04 Thread Jaroslav Bachorik
On 05/29/2013 04:08 AM, David Holmes wrote: On 28/05/2013 11:13 PM, Jaroslav Bachorik wrote: Please, review the fix for JDK-8002307. The fix assures the immutability by cloning the provided arrays in the constructor and then cloning them again in the getters. This fix has the same

Re: URGENT: RR(XS):8015604 JDP packets containing ideographic characters are broken

2013-06-04 Thread Dmitry Samersoff
Staffan, Two bytes len prefix is a part of JDP protocol specification, so I would prefer to write it explicitly. But changed to *writeUTF()* as recommended. see: http://cr.openjdk.java.net/~dsamersoff/8015604/webrev.02/ -Dmitry On 2013-06-04 11:48, Staffan Larsen wrote: Looks good. Even

hg: jdk8/tl/jdk: 8015790: Remove duplicate spliterator tests

2013-06-04 Thread paul . sandoz
Changeset: fad4ef2123ca Author:psandoz Date: 2013-06-04 11:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fad4ef2123ca 8015790: Remove duplicate spliterator tests Reviewed-by: alanb, mduigou -

Re: URGENT: RR(XS):8015604 JDP packets containing ideographic characters are broken

2013-06-04 Thread Staffan Larsen
Thanks for changing this. Looks good! /Staffan On 4 jun 2013, at 11:50, Dmitry Samersoff dmitry.samers...@oracle.com wrote: Staffan, Two bytes len prefix is a part of JDP protocol specification, so I would prefer to write it explicitly. But changed to *writeUTF()* as recommended.

hg: jdk8/tl/jdk: 8014723: sun/misc/URLClassPath/ClassnameCharTest.java failing

2013-06-04 Thread michael . x . mcmahon
Changeset: f8b071428ca5 Author:michaelm Date: 2013-06-04 10:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b071428ca5 8014723: sun/misc/URLClassPath/ClassnameCharTest.java failing Reviewed-by: alanb, chegar ! src/share/classes/java/net/HttpURLPermission.java !

Re: URGENT: RR(XS):8015604 JDP packets containing ideographic characters are broken

2013-06-04 Thread Dmitry Samersoff
Jaroslav, Nope. I'd replaced calls to writeShort and writeByte to one writeUTF. I'll reformat comments to avoid any confusions. -Dmitry On 2013-06-04 13:57, Jaroslav Bachorik wrote: On Tue 04 Jun 2013 11:50:41 AM CEST, Dmitry Samersoff wrote: Staffan, Two bytes len prefix is a part of JDP

Re: RFR - 6526682: JConsole shows negative CPU Usage

2013-06-04 Thread Mario Torre
I agree with Erik and Staffan, I was actually a bit surprised this passed the review status so quickly. The code right before that line is: float cpuUsage = Math.min(99F, elapsedCpu / (elapsedTime * 1F * result.nCPUs)); I would look at elapsedTime as a suspect here. It really seems to me

hg: jdk8/tl/langtools: 3 new changesets

2013-06-04 Thread maurizio . cimadamore
Changeset: 5cd3cb69c8b3 Author:mcimadamore Date: 2013-06-04 11:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5cd3cb69c8b3 7116676: RichDiagnosticFormatter throws NPE when formatMessage is called directly Summary: Fix NPE in RichDiagnosticFormatter.formatMessage

hg: jdk8/tl/jdk: 8015872: ProblemList.txt updates (6/2013)

2013-06-04 Thread alan . bateman
Changeset: 780fbbd50ce4 Author:alanb Date: 2013-06-04 11:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/780fbbd50ce4 8015872: ProblemList.txt updates (6/2013) Reviewed-by: chegar ! test/ProblemList.txt

Re: URGENT: RR(XS):8015604 JDP packets containing ideographic characters are broken

2013-06-04 Thread David Holmes
On 4/06/2013 7:50 PM, Dmitry Samersoff wrote: Staffan, Two bytes len prefix is a part of JDP protocol specification, so I would prefer to write it explicitly. But changed to *writeUTF()* as recommended. see: http://cr.openjdk.java.net/~dsamersoff/8015604/webrev.02/ The new comment doesn't

hg: hsx/hotspot-rt/hotspot: 8015803: Test8015436.java fails 'can not access a member of class Test8015436 with modifiers public static'

2013-06-04 Thread serguei . spitsyn
Changeset: 2f004f9dc9e1 Author:sspitsyn Date: 2013-06-04 01:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2f004f9dc9e1 8015803: Test8015436.java fails 'can not access a member of class Test8015436 with modifiers public static' Summary: Newly added test has an

Re: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

2013-06-04 Thread David Holmes
Based on discussions around 8010815 I withdraw my comments on this change. I'll leave it to others to review this. David On 4/06/2013 7:51 PM, Jaroslav Bachorik wrote: On 05/29/2013 04:08 AM, David Holmes wrote: On 28/05/2013 11:13 PM, Jaroslav Bachorik wrote: Please, review the fix for

hg: jdk8/tl/langtools: 7165659: javac incorrectly sets strictfp access flag on inner-classes

2013-06-04 Thread vicente . romero
Changeset: 775a51e3276f Author:vromero Date: 2013-06-04 13:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/775a51e3276f 7165659: javac incorrectly sets strictfp access flag on inner-classes Reviewed-by: jjg, mcimadamore !

Re: URGENT: RR(XS):8015604 JDP packets containing ideographic characters are broken

2013-06-04 Thread Dmitry Samersoff
David, Fixed comments. -Dmitry On 2013-06-04 16:13, David Holmes wrote: On 4/06/2013 7:50 PM, Dmitry Samersoff wrote: Staffan, Two bytes len prefix is a part of JDP protocol specification, so I would prefer to write it explicitly. But changed to *writeUTF()* as recommended. see:

hg: jdk8/tl/jdk: 8014855: TEST_BUG: java/nio/file/Files/StreamTest.java fails when sym links not supported

2013-06-04 Thread alan . bateman
Changeset: 25a8e6fd0210 Author:alanb Date: 2013-06-04 15:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/25a8e6fd0210 8014855: TEST_BUG: java/nio/file/Files/StreamTest.java fails when sym links not supported Reviewed-by: alanb Contributed-by: henry@oracle.com !

hg: jdk8/tl/jaxp: 8015630: Remove default restriction settings of jaxp 1.5 properties in JDK8

2013-06-04 Thread huizhe . wang
Changeset: 5b958f0a5498 Author:joehw Date: 2013-06-04 09:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5b958f0a5498 8015630: Remove default restriction settings of jaxp 1.5 properties in JDK8 Reviewed-by: alanb !

hg: jdk8/tl/jdk: 8013903: Japanese calendar field names are not displayed with -Djava.locale.providers=HOST on Windows

2013-06-04 Thread naoto . sato
Changeset: 379e1bcae693 Author:naoto Date: 2013-06-04 10:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/379e1bcae693 8013903: Japanese calendar field names are not displayed with -Djava.locale.providers=HOST on Windows Reviewed-by: okutsu !

hg: jdk8/tl/langtools: 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations

2013-06-04 Thread jonathan . gibbons
Changeset: 8fb68f73d4b1 Author:jjg Date: 2013-06-04 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8fb68f73d4b1 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations Reviewed-by: mcimadamore, jfranck !

hg: jdk8/tl/jdk: 8005704: Update ConcurrentHashMap to v8

2013-06-04 Thread chris . hegarty
Changeset: d6401129327e Author:dl Date: 2013-06-04 21:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6401129327e 8005704: Update ConcurrentHashMap to v8 Reviewed-by: chegar, mduigou ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java

hg: jdk8/tl/jdk: 8014097: add doPrivileged methods with limited privilege scope

2013-06-04 Thread mandy . chung
Changeset: bd84bad9ee99 Author:jdn Date: 2013-06-04 15:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd84bad9ee99 8014097: add doPrivileged methods with limited privilege scope Reviewed-by: mchung ! src/share/classes/java/security/AccessControlContext.java !

hg: hsx/hotspot-rt/hotspot: 8010257: remove unused thread-local variables _ScratchA and _ScratchB

2013-06-04 Thread daniel . daugherty
Changeset: 62e7bac9524f Author:dcubed Date: 2013-06-04 19:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/62e7bac9524f 8010257: remove unused thread-local variables _ScratchA and _ScratchB Summary: Remove dead code. Reviewed-by: twisti, coleenp !