Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-06-18 Thread Daniel Fuchs
Hi Jaroslav, I've added the tests for the proper behaviour when the com.sun.jmx.mbeans.allowNonPublic system property is set to true. http://cr.openjdk.java.net/~jbachorik/8010285/webrev.05/ Thanks for adding the test. I haven't looked at the source again, I trust nothing changed there.

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-06-18 Thread Jaroslav Bachorik
On Tue 18 Jun 2013 12:25:35 PM CEST, Daniel Fuchs wrote: Hi Jaroslav, I've added the tests for the proper behaviour when the com.sun.jmx.mbeans.allowNonPublic system property is set to true. http://cr.openjdk.java.net/~jbachorik/8010285/webrev.05/ Thanks for adding the test. I haven't

hg: jdk8/tl/nashorn: 14 new changesets

2013-06-18 Thread sundararajan . athijegannathan
Changeset: df5d7f34e35e Author:hannesw Date: 2013-06-11 17:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/df5d7f34e35e 8015379: PropertyMap.addProperty() is slow Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/runtime/PropertyMap.java Changeset: aa16622193e1

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-06-18 Thread Jaroslav Bachorik
On Tue 18 Jun 2013 12:30:07 PM CEST, Jaroslav Bachorik wrote: On Tue 18 Jun 2013 12:25:35 PM CEST, Daniel Fuchs wrote: Hi Jaroslav, I've added the tests for the proper behaviour when the com.sun.jmx.mbeans.allowNonPublic system property is set to true.

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-06-18 Thread Daniel Fuchs
On 6/18/13 1:27 PM, Jaroslav Bachorik wrote: On Tue 18 Jun 2013 12:30:07 PM CEST, Jaroslav Bachorik wrote: On Tue 18 Jun 2013 12:25:35 PM CEST, Daniel Fuchs wrote: Hi Jaroslav, I've added the tests for the proper behaviour when the com.sun.jmx.mbeans.allowNonPublic system property is set to

hg: jdk8/tl/jdk: 8016046: (process) Strict validation of input should be security manager case only [win].

2013-06-18 Thread alexey . utkin
Changeset: 956b00d7d4ea Author:uta Date: 2013-06-18 17:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/956b00d7d4ea 8016046: (process) Strict validation of input should be security manager case only [win]. Reviewed-by: alanb, ahgross !

Re: Codereview for JDK-8016221: A unit test should not use a fixed port to run a jmx connector (JDCMD MBean Tests)

2013-06-18 Thread shanliang
Jaroslav Bachorik wrote: Hi Shanliang, the change looks fine. The only small thing I have is whether it is good to wrap cc.close(); cs.stop(); in try/catch and swallow the exception. Wouldn't it be better to let the test fail if something goes wrong with closing JMXConnector and

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-06-18 Thread zhengyu . gu
Changeset: 1f4355cee9a2 Author:zgu Date: 2013-06-18 08:44 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1f4355cee9a2 8013651: NMT: reserve/release sequence id's in incorrect order due to race Summary: Fixed NMT race condition for realloc, uncommit and release

hg: jdk8/tl/langtools: 8016607: javac, avoid analyzing lambdas for source 7 compilation

2013-06-18 Thread vicente . romero
Changeset: e701af23a095 Author:vromero Date: 2013-06-18 18:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e701af23a095 8016607: javac, avoid analyzing lambdas for source 7 compilation Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com !

hg: jdk8/tl/langtools: 8016267: javac, TypeTag refactoring has provoked performance issues

2013-06-18 Thread vicente . romero
Changeset: 9851071b551a Author:vromero Date: 2013-06-18 19:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9851071b551a 8016267: javac, TypeTag refactoring has provoked performance issues Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java !

Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

2013-06-18 Thread Dan Xu
Thanks for your feedbacks. I have updated my changes and uploaded to webrev at http://cr.openjdk.java.net/~dxu/8016592/webrev.01/. I have tested the fix with the jck tests and regression tests. And the results look good. Thanks! -Dan On 06/17/2013 01:03 AM, Daniel Fuchs wrote: Hi Dan,

hg: jdk8/tl/hotspot: 11 new changesets

2013-06-18 Thread chris . hegarty
Changeset: f75faf51e8c4 Author:hseigel Date: 2013-03-07 11:49 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f75faf51e8c4 7158805: Better rewriting of nested subroutine calls Reviewed-by: mschoene, coleenp ! src/share/vm/memory/allocation.cpp !

hg: jdk8/tl/jaxp: 9 new changesets

2013-06-18 Thread chris . hegarty
Changeset: f14f72174f00 Author:chegar Date: 2013-04-24 10:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f14f72174f00 Merge Changeset: b225607e056b Author:chegar Date: 2013-04-28 08:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b225607e056b

Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

2013-06-18 Thread Chris Hegarty
On 06/18/2013 07:35 PM, Dan Xu wrote: Thanks for your feedbacks. I have updated my changes and uploaded to webrev at http://cr.openjdk.java.net/~dxu/8016592/webrev.01/. I have tested the Given the previous discussion, this change looks fine to me. -Chris. fix with the jck tests and

hg: jdk8/tl/corba: 9 new changesets

2013-06-18 Thread chris . hegarty
Changeset: 39d15bbb5741 Author:coffeys Date: 2013-04-08 23:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/39d15bbb5741 8001032: Restrict object access Summary: Restrict object access; fix reviewed also by Alexander Fomin Reviewed-by: alanb, ahgross !

hg: jdk8/tl/nashorn: 9 new changesets

2013-06-18 Thread chris . hegarty
Changeset: af8a98ea83d4 Author:chegar Date: 2013-04-24 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/af8a98ea83d4 Merge Changeset: 2237e2ff3685 Author:chegar Date: 2013-04-28 08:16 +0100 URL:

hg: hsx/hotspot-rt/hotspot: 8015660: Test8009761.java Failed: init recursive calls: 24. After deopt 25

2013-06-18 Thread yumin . qi
Changeset: cd54c7e92908 Author:minqi Date: 2013-06-18 09:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd54c7e92908 8015660: Test8009761.java Failed: init recursive calls: 24. After deopt 25 Summary: Windows reserves and only partially commits thread stack.

hg: jdk8/tl/jdk: 2 new changesets

2013-06-18 Thread mike . duigou
Changeset: ba544aab1fcd Author:bpb Date: 2013-06-18 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba544aab1fcd 8015395: NumberFormatException during startup if JDK-internal property java.lang.Integer.IntegerCache.high set to bad value Summary: Fall back to default if

hg: jdk8/tl/jdk: 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap, ConcurrentMap

2013-06-18 Thread mike . duigou
Changeset: 1f7cbe4829fe Author:mduigou Date: 2013-06-18 16:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f7cbe4829fe 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap, ConcurrentMap Reviewed-by: forax, mduigou,

hg: jdk8/tl: 8016780: README-builds.html misses crucial requirement on bootstrap JDK

2013-06-18 Thread stuart . marks
Changeset: b9587f41fd55 Author:smarks Date: 2013-06-18 17:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9587f41fd55 8016780: README-builds.html misses crucial requirement on bootstrap JDK Reviewed-by: dholmes, chegar ! README-builds.html

hg: jdk8/tl/langtools: 8015657: jdk8 l10n resource file translation update 3

2013-06-18 Thread michael . fang
Changeset: 792c40d5185a Author:mfang Date: 2013-06-18 20:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/792c40d5185a 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang !

hg: jdk8/tl/jdk: 8015657: jdk8 l10n resource file translation update 3

2013-06-18 Thread michael . fang
Changeset: d82773b770ce Author:mfang Date: 2013-06-18 21:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d82773b770ce 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang ! src/macosx/classes/com/apple/laf/resources/aqua_pt_BR.properties !

hg: jdk8/tl/corba: 8015657: jdk8 l10n resource file translation update 3

2013-06-18 Thread michael . fang
Changeset: d406edd4f6fd Author:mfang Date: 2013-06-18 20:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d406edd4f6fd 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang !