hg: jdk8/tl/jdk: 8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread joe . darcy
Changeset: eab8f4e29f5e Author:darcy Date: 2013-07-08 22:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab8f4e29f5e 8020095: Fix doclint warnings in java.util.regex Reviewed-by: mchung ! src/share/classes/java/util/regex/MatchResult.java ! src/share/classes/java/util/reg

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-07-08 Thread harold . seigel
Changeset: ba9dacff9c9d Author:hseigel Date: 2013-07-08 19:36 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ba9dacff9c9d 8014399: Remove JVM_SetProtectionDomain from hotspot Summary: JVM_SetProtectionDomain has been deprecated since 1.5 and is being removed Revie

hg: jdk8/tl/jdk: 8020091: Fix HTML doclint issues in java.io

2013-07-08 Thread jason . uh
Changeset: 52454985425d Author:juh Date: 2013-07-08 19:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52454985425d 8020091: Fix HTML doclint issues in java.io Reviewed-by: darcy ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/FileInputStream.java !

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-07-08 Thread jiangli . zhou
Changeset: 71180a6e5080 Author:jiangli Date: 2013-07-03 17:26 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/71180a6e5080 7133260: AllocationProfiler uses space in metadata and doesn't seem to do anything useful. Summary: Remove -Xaprof and Klass::_alloc_count & A

Re: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-08 Thread serguei.spit...@oracle.com
Ok, thanks! Peter, did you manage to reproduce this issue with your script? If so, then, please, include it into the bug report and remove the "noreg-sqe" label. It is Ok if you did not reproduce it, though. Thanks, Serguei On 7/8/13 4:20 PM, Daniel D. Daugherty wrote: I definitely don't i

Re: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-08 Thread Daniel D. Daugherty
I definitely don't insist... :-) BTW, I noticed this in Peter's e-mail: > Testing: > JPRT, reproducing script on Solaris, Linux. so maybe Peter already has this covered with "reproducing script"... Dan On 7/8/13 5:07 PM, serguei.spit...@oracle.com wrote: Dan, Dan, thank you for the recomme

Re: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-08 Thread serguei.spit...@oracle.com
Dan, Dan, thank you for the recommendation. But I'm still not sure it is a right thing to do. Even though, there are multiple test cases associated with this bug they can not be used to verify that fix because an additional condition must be present as well. This condition is a presence of stale

Re: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-08 Thread Daniel D. Daugherty
Serguei, There are a number of existing tests associated with this bug. I don't think that 'noreg-hard' is the right label. I think 'noreg-sqe' is the right one: noreg-sqe Change can be verified by running an existing SQE test suite; the bug should identify the suite and the specific tes

Re: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-08 Thread Daniel D. Daugherty
On 7/8/13 7:54 AM, Peter Allwin wrote: Hello! Looking for reviews of this change: http://cr.openjdk.java.net/~allwin/7162400/webrev.01/ src/share/vm/services/attachListener.hpp No comments. src/os/bsd/vm/attachListener_bsd.cpp

hg: hsx/hotspot-rt/hotspot: 8016903: Thread::_handle_area initial size too big

2013-07-08 Thread ioi . lam
Changeset: cf9d71d3e474 Author:iklam Date: 2013-07-08 10:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cf9d71d3e474 8016903: Thread::_handle_area initial size too big Summary: Changed initial size to Chunk::tiny_size (216 bytes) Reviewed-by: coleenp, dholmes, s

Re: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-08 Thread serguei.spit...@oracle.com
Peter, I've added the label "noreg-hard" with the comment to the report. It is not easy to reproduce the issue and demonstrate the fix in a regression test. Thanks, Serguei On 7/8/13 11:36 AM, serguei.spit...@oracle.com wrote: Hi Peter, The fix looks good. Thanks, Serguei On 7/8/13 6:54

Re: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-08 Thread serguei.spit...@oracle.com
Hi Peter, The fix looks good. Thanks, Serguei On 7/8/13 6:54 AM, Peter Allwin wrote: Hello! Looking for reviews of this change: http://cr.openjdk.java.net/~allwin/7162400/webrev.01/ For CR: http://bugs.sun.com/view_bug.do?bug_id=

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-08 Thread Seán Coffey
On 08/07/13 17:55, Ivan Gerasimov wrote: Thanks, Seán! I located the build in which the memleak was first introduced -- it is jdk8-b69 (hs25-b13). I've updated the bug http://bugs.sun.com/view_bug.do?bug_id=8019845 with this. So what is the correct procedure to go forward now? Should I upda

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-08 Thread Ivan Gerasimov
Thanks, Seán! I located the build in which the memleak was first introduced -- it is jdk8-b69 (hs25-b13). I've updated the bug http://bugs.sun.com/view_bug.do?bug_id=8019845 with this. So what is the correct procedure to go forward now? Should I update the webrev to include changes to the pro

Re: RFR - Changes to address CCC 8014135: Support for statically linked agents

2013-07-08 Thread BILL PITTORE
On 7/4/2013 12:41 PM, Alan Bateman wrote: On 03/07/2013 22:17, BILL PITTORE wrote: These changes address bug 8014135 which adds support for statically linked agents in the VM. This is a followup to the recent JNI spec changes that addressed statically linked JNI libraries( 8005716). The JEP fo

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-08 Thread Rickard Bäckman
Thanks Markus! /R On Jul 8, 2013, at 5:45 PM, Markus Grönlund wrote: > Rickard, > > I think it looks good (not a Reviewer). > > Cheers > Markus > > -Original Message- > From: Rickard Bäckman > Sent: den 4 juli 2013 11:30 > To: serviceability-dev@openjdk.java.net serviceability-dev@op

RE: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-08 Thread Markus Grönlund
Rickard, I think it looks good (not a Reviewer). Cheers Markus -Original Message- From: Rickard Bäckman Sent: den 4 juli 2013 11:30 To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RFR(S): 8016131: nsk/sysdict/vm

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-08 Thread Rickard Bäckman
Trying again, can I please get reviews on this change? Thanks /R On Jul 4, 2013, at 11:30 AM, Rickard Bäckman wrote: > Hi, > > can I please have a couple of reviews for this change? > > The problem in this crash was that we were given an incorrect fp (in this > case 0x0) and had a pc that mat

RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-08 Thread Peter Allwin
Hello! Looking for reviews of this change: http://cr.openjdk.java.net/~allwin/7162400/webrev.01/ For CR: http://bugs.sun.com/view_bug.do?bug_id=7162400 https://jbs.oracle.com/bugs/browse/JDK-7162400 Summary: This change addresses an issue in the Attach API on Solaris, Linux and BSD

hg: jdk8/tl/nashorn: 20 new changesets

2013-07-08 Thread sundararajan . athijegannathan
Changeset: 313bdcd2fd22 Author:sundar Date: 2013-07-03 00:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/313bdcd2fd22 8019629: void operator should always evaluate to undefined Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/interna

hg: jdk8/tl/jdk: 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace

2013-07-08 Thread jesper . wilhelmsson
Changeset: 715d00c95fb2 Author:ehelin Date: 2013-07-08 11:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/715d00c95fb2 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace Reviewed-by: alanb ! test/ProblemList.txt ! test/java/lang/management/Memo