hg: jdk8/tl/jdk: 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries

2013-07-10 Thread paul . sandoz
Changeset: ff5df05222d1 Author:psandoz Date: 2013-07-10 09:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff5df05222d1 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries Reviewed-by: briangoetz !

Re: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

2013-07-10 Thread Dmitry Samersoff
David, Yes, UNIX_PATH_MAX is a historic constant that limit size of sun_path in sockaddr_un. But I would support Peter - on my opinion it's better to always use the same constant. And (being paranoid) it's better to check return value of snprintf to make sure we are getting correct file name to

hg: jdk8/tl/jdk: 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees

2013-07-10 Thread paul . sandoz
Changeset: 882baa1e0a38 Author:psandoz Date: 2013-07-10 10:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/882baa1e0a38 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees Reviewed-by: briangoetz Contributed-by: doug lea

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-07-10 Thread Jaroslav Bachorik
On 07/09/2013 09:42 PM, Mandy Chung wrote: On 7/9/13 3:02 AM, Jaroslav Bachorik wrote: Please, review the final version of the changes: http://cr.openjdk.java.net/~jbachorik/8010285/webrev.07 The change looks reasonable. In the class spec for MXBean, suggest to rename interface

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-10 Thread Ivan Gerasimov
Yes, I forgot to include the most important thing - a link to webrev! Your link is correct. http://cr.openjdk.java.net/~igerasim/8016838/3/webrev/ The tests fail on linux-x64 only, linux-i586 is fine. Here's the link to the logs of the tests run by Daniel Daugherty:

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-10 Thread Seán Coffey
On 10/07/13 11:38, Ivan Gerasimov wrote: Yes, I forgot to include the most important thing - a link to webrev! Your link is correct. http://cr.openjdk.java.net/~igerasim/8016838/3/webrev/ The tests fail on linux-x64 only, linux-i586 is fine. Here's the link to the logs of the tests run by

Re: RFR(S): 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()'

2013-07-10 Thread Rickard Bäckman
Still looking for a Reviewer. Thanks /R On Jul 8, 2013, at 5:49 PM, Rickard Bäckman wrote: Thanks Markus! /R On Jul 8, 2013, at 5:45 PM, Markus Grönlund wrote: Rickard, I think it looks good (not a Reviewer). Cheers Markus -Original Message- From: Rickard Bäckman

Re: RFR: 8019826 Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails with NPE

2013-07-10 Thread shanliang
It looks fine to me. Shanliang Jaroslav Bachorik wrote: Please, review this simple fix. http://cr.openjdk.java.net/~jbachorik/8019826/webrev.00 Firstly, the patch removes a conditional early exit which checks for a build 52 of an unspecified major JVM version - it is not needed any more.

hg: hsx/hotspot-rt/hotspot: 7143807: ResourceMark nesting problem in stringStream

2013-07-10 Thread frederic . parain
Changeset: dbc0b5dc08f5 Author:fparain Date: 2013-07-10 15:49 + URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dbc0b5dc08f5 7143807: ResourceMark nesting problem in stringStream Reviewed-by: kvn, dcubed ! src/share/vm/memory/resourceArea.hpp !

hg: jdk8/tl/jdk: 8020294: Fix doclint issues in java.util.Spliterator

2013-07-10 Thread joe . darcy
Changeset: 7c44ea602cc8 Author:darcy Date: 2013-07-10 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c44ea602cc8 8020294: Fix doclint issues in java.util.Spliterator Reviewed-by: psandoz ! src/share/classes/java/util/Spliterator.java

hg: jdk8/tl/jdk: 2 new changesets

2013-07-10 Thread rob . mckenna
Changeset: 607fa1ff3de2 Author:bpb Date: 2013-07-09 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/607fa1ff3de2 6178739: (fmt) Formatter.format(%0.4f\n, 56789.456789) generates MissingFormatWidthException Summary: Change the field width specification to require a

Re: RFR - Changes to address CCC 8014135: Support for statically linked agents

2013-07-10 Thread BILL PITTORE
On 7/3/2013 6:32 PM, Jeremy Manson wrote: I know that this is mentioned in the JEP, but does it really make sense to have -agentpath work here, rather than just -agentlib? I would think that specifying a full pathname and getting the library loaded out of the launcher would be a little

hg: jdk8/tl/jdk: 8020308: Fix doclint issues in java.lang.management

2013-07-10 Thread joe . darcy
Changeset: 69d9fe8175a0 Author:sspitsyn Date: 2013-07-10 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69d9fe8175a0 8020308: Fix doclint issues in java.lang.management Reviewed-by: darcy Contributed-by: serguei.spit...@oracle.com !

Re: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

2013-07-10 Thread Mandy Chung
On 7/10/2013 4:33 PM, Jaroslav Bachorik wrote: The change looks reasonable. In the class spec for MXBean, suggest to rename interface ThisIsNotMXBean{} to something more explicit interface NonPublicInterfaceNotMXBean{} Since this was a part of the CCC review which was approved I am

hg: jdk8/tl/jdk: 8020318: Fix doclint issues in java.net

2013-07-10 Thread jason . uh
Changeset: 702556f7977e Author:juh Date: 2013-07-10 18:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/702556f7977e 8020318: Fix doclint issues in java.net Reviewed-by: darcy, khazra ! src/share/classes/java/net/CookieStore.java !

Re: RFR: 8019826 Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails with NPE

2013-07-10 Thread David Holmes
On 10/07/2013 7:10 PM, Jaroslav Bachorik wrote: Please, review this simple fix. http://cr.openjdk.java.net/~jbachorik/8019826/webrev.00 Firstly, the patch removes a conditional early exit which checks for a build 52 of an unspecified major JVM version - it is not needed any more. Basically,

Re: RFR: 8019826 Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails with NPE

2013-07-10 Thread Mandy Chung
Looks good. Mandy On Jul 10, 2013, at 5:10 PM, Jaroslav Bachorik jaroslav.bacho...@oracle.com wrote: Please, review this simple fix. http://cr.openjdk.java.net/~jbachorik/8019826/webrev.00 Firstly, the patch removes a conditional early exit which checks for a build 52 of an unspecified