Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread David Holmes
On 25/07/2013 12:08 AM, Jaroslav Bachorik wrote: On 07/24/2013 03:17 PM, Chris Hegarty wrote: On 24/07/2013 13:49, Jaroslav Bachorik wrote: On 07/24/2013 02:32 PM, Chris Hegarty wrote: On 24/07/2013 12:21, David Holmes wrote: On 24/07/2013 7:31 PM, Mandy Chung wrote: On 7/24/2013 4:50 PM, s

hg: jdk8/tl/nashorn: 7 new changesets

2013-07-24 Thread sundararajan . athijegannathan
Changeset: 8b97fe2b7c98 Author:attila Date: 2013-07-23 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8b97fe2b7c98 8021129: Use public lookup again Reviewed-by: lagergren, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/

hg: jdk8/tl/langtools: 8020556: doclint does not check type variables for @throws

2013-07-24 Thread jonathan . gibbons
Changeset: 2fbe77c38802 Author:jjg Date: 2013-07-24 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fbe77c38802 8020556: doclint does not check type variables for @throws Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/c

hg: jdk8/tl/jdk: 8021261: ProblemList.txt updates (7/2013)

2013-07-24 Thread chris . hegarty
Changeset: fd1b5adcfdf0 Author:chegar Date: 2013-07-24 22:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd1b5adcfdf0 8021261: ProblemList.txt updates (7/2013) Reviewed-by: alanb, mcimadamore ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8016916: UnstructuredName should support DirectoryString

2013-07-24 Thread jason . uh
Changeset: f9224fb49890 Author:juh Date: 2013-07-24 12:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9224fb49890 8016916: UnstructuredName should support DirectoryString Reviewed-by: mullan ! src/share/classes/sun/security/pkcs/PKCS9Attribute.java ! src/share/classes/su

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Daniel D. Daugherty
On 7/24/13 1:35 AM, Jaroslav Bachorik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/24/2013 09:21 AM, shanliang wrote: Just to be a test, after terminated 8 threads and checked their states by calling Thread.join() (must be same to Thread.getState()), DO sleep sometime and then cal

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Chris Hegarty
On 24/07/2013 15:08, Jaroslav Bachorik wrote: On 07/24/2013 03:17 PM, Chris Hegarty wrote: On 24/07/2013 13:49, Jaroslav Bachorik wrote: On 07/24/2013 02:32 PM, Chris Hegarty wrote: On 24/07/2013 12:21, David Holmes wrote: On 24/07/2013 7:31 PM, Mandy Chung wrote: On 7/24/2013 4:50 PM, shan

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Jaroslav Bachorik
On 07/24/2013 03:17 PM, Chris Hegarty wrote: > On 24/07/2013 13:49, Jaroslav Bachorik wrote: >> On 07/24/2013 02:32 PM, Chris Hegarty wrote: >>> On 24/07/2013 12:21, David Holmes wrote: On 24/07/2013 7:31 PM, Mandy Chung wrote: > > On 7/24/2013 4:50 PM, shanliang wrote: >> So we ha

hg: jdk8/tl/jdk: 8016221: A unit test should not use a fix port to run a jmx connector

2013-07-24 Thread shanliang . jiang
Changeset: 187a1f2613c0 Author:sjiang Date: 2013-07-24 15:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/187a1f2613c0 8016221: A unit test should not use a fix port to run a jmx connector Reviewed-by: jbachorik, dfuchs ! test/com/sun/management/DiagnosticCommandMBean/Dcm

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Chris Hegarty
On 24/07/2013 13:49, Jaroslav Bachorik wrote: On 07/24/2013 02:32 PM, Chris Hegarty wrote: On 24/07/2013 12:21, David Holmes wrote: On 24/07/2013 7:31 PM, Mandy Chung wrote: On 7/24/2013 4:50 PM, shanliang wrote: So we have 2 kinds of issues here: 1) the test related, like Thread state check

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Jaroslav Bachorik
On 07/24/2013 02:32 PM, Chris Hegarty wrote: > On 24/07/2013 12:21, David Holmes wrote: >> On 24/07/2013 7:31 PM, Mandy Chung wrote: >>> >>> On 7/24/2013 4:50 PM, shanliang wrote: So we have 2 kinds of issues here: 1) the test related, like Thread state checking, we can fix them in t

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Chris Hegarty
On 24/07/2013 12:21, David Holmes wrote: On 24/07/2013 7:31 PM, Mandy Chung wrote: On 7/24/2013 4:50 PM, shanliang wrote: So we have 2 kinds of issues here: 1) the test related, like Thread state checking, we can fix them in the test 2) MBean.getThreadCount() issue, we can create a bug to trac

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread shanliang
Jaroslav Bachorik wrote: On 07/24/2013 01:21 PM, David Holmes wrote: On 24/07/2013 7:31 PM, Mandy Chung wrote: On 7/24/2013 4:50 PM, shanliang wrote: So we have 2 kinds of issues here: 1) the test related, like Thread state checking, we can fix them in the test 2) MBean.getThrea

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Jaroslav Bachorik
On 07/24/2013 01:58 PM, David Holmes wrote: > Aside: it is really annoying that jmx-dev mangles the subject such that > cross-posts end up creating two different email threads :( > > On 24/07/2013 9:50 PM, Jaroslav Bachorik wrote: >> On 07/24/2013 01:21 PM, David Holmes wrote: >>> On 24/07/2013 7:

Re: RR(XS) 8019396: SA-JDI: OSThread class initialization throws an exception

2013-07-24 Thread David Holmes
On 23/07/2013 9:37 PM, Mikael Gerdin wrote: David, On 2013-07-23 12:31, David Holmes wrote: Hi Dmitry, Looks okay. Minor nit: ! return (int)threadIdField.getJInt(addr); The cast should not be need as getJInt returns int. Aside: this looks like a major bug in BasicField to me: pu

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread David Holmes
Aside: it is really annoying that jmx-dev mangles the subject such that cross-posts end up creating two different email threads :( On 24/07/2013 9:50 PM, Jaroslav Bachorik wrote: On 07/24/2013 01:21 PM, David Holmes wrote: On 24/07/2013 7:31 PM, Mandy Chung wrote: On 7/24/2013 4:50 PM, shanl

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Jaroslav Bachorik
On 07/24/2013 01:21 PM, David Holmes wrote: > On 24/07/2013 7:31 PM, Mandy Chung wrote: >> >> On 7/24/2013 4:50 PM, shanliang wrote: >>> So we have 2 kinds of issues here: >>> 1) the test related, like Thread state checking, we can fix them in >>> the test >>> 2) MBean.getThreadCount() issue, we ca

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread David Holmes
On 24/07/2013 7:31 PM, Mandy Chung wrote: On 7/24/2013 4:50 PM, shanliang wrote: So we have 2 kinds of issues here: 1) the test related, like Thread state checking, we can fix them in the test 2) MBean.getThreadCount() issue, we can create a bug to trace it (add your test case to the bug), and

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Mandy Chung
On 7/24/2013 4:50 PM, shanliang wrote: So we have 2 kinds of issues here: 1) the test related, like Thread state checking, we can fix them in the test 2) MBean.getThreadCount() issue, we can create a bug to trace it (add your test case to the bug), and add a workaround (sleep or call 2 times)

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread shanliang
Jaroslav Bachorik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/24/2013 10:38 AM, shanliang wrote: - ---> MBean.getThreadCount() = 7 - ---> MBean.getThreadCount() = 6 I suppose that you added sleep between 2 calls, then there might be an issue with MBean.getT

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Jaroslav Bachorik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/24/2013 10:38 AM, shanliang wrote: > - ---> MBean.getThreadCount() = 7 > > > > - ---> MBean.getThreadCount() = 6 > > I suppose that you added sleep between 2 calls, then there might be > an issue with MBean.getThreadCount() A

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread shanliang
- ---> MBean.getThreadCount() = 7 - ---> MBean.getThreadCount() = 6 I suppose that you added sleep between 2 calls, then there might be an issue with MBean.getThreadCount() Shanliang Jaroslav Bachorik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/24/2013 09:2

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-07-24 Thread yumin . qi
Changeset: 1b6395189726 Author:minqi Date: 2013-07-19 14:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1b6395189726 8012263: ciReplay: gracefully exit & report meaningful error when replay data parsing fails Summary: find_method could return NULL so need expli

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread Jaroslav Bachorik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/24/2013 09:21 AM, shanliang wrote: > Just to be a test, after terminated 8 threads and checked their > states by calling Thread.join() (must be same to > Thread.getState()), DO sleep sometime and then call > mbean.getThreadCount(), if it reports

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-24 Thread shanliang
Just to be a test, after terminated 8 threads and checked their states by calling Thread.join() (must be same to Thread.getState()), DO sleep sometime and then call mbean.getThreadCount(), if it reports a right number, then we may need to verify mbean.getThreadCount() method. Shanliang Jarosl