hg: jdk8/tl/langtools: 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType

2013-07-25 Thread joel . franck
Changeset: a218f7befd55 Author:jfranck Date: 2013-07-25 11:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a218f7befd55 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType Reviewed-by: jjg !

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-25 Thread Jaroslav Bachorik
On 07/25/2013 07:07 AM, David Holmes wrote: On 25/07/2013 12:08 AM, Jaroslav Bachorik wrote: On 07/24/2013 03:17 PM, Chris Hegarty wrote: On 24/07/2013 13:49, Jaroslav Bachorik wrote: On 07/24/2013 02:32 PM, Chris Hegarty wrote: On 24/07/2013 12:21, David Holmes wrote: On 24/07/2013 7:31 PM,

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-25 Thread Daniel Fuchs
On 7/25/13 2:28 PM, Jaroslav Bachorik wrote: For the time being I propose modifying the test to be less race-prone in java and adding a timeout of 500ms after terminating a number of threads. The test modifications are at http://cr.openjdk.java.net/~jbachorik/8020875/webrev.02 Thanks, Hi

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-25 Thread Daniel Fuchs
BTW - I wonder if you should add 8021335 in the @bug line. -- daniel On 7/25/13 2:37 PM, Daniel Fuchs wrote: On 7/25/13 2:28 PM, Jaroslav Bachorik wrote: For the time being I propose modifying the test to be less race-prone in java and adding a timeout of 500ms after terminating a number of

Re: jmx-dev RFR: 8020875 java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently

2013-07-25 Thread Chris Hegarty
On 07/25/2013 01:28 PM, Jaroslav Bachorik wrote: .. I have filed a separate issue for hotspot/svc (JDK-8021335) Yes, this is probably a separate, and more involved, issue. For the time being I propose modifying the test to be less race-prone in java and adding a timeout of 500ms after

hg: jdk8/tl/langtools: 3 new changesets

2013-07-25 Thread maurizio . cimadamore
Changeset: 3155e77d2676 Author:mcimadamore Date: 2013-07-25 14:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3155e77d2676 8020804: javac crashes when speculative attribution infers intersection type with array component Summary: Assertion is causing javac to crash

RFR: Event based tracing is missing thread exit

2013-07-25 Thread Erik Gahlin
Hello, Could you be so kind and review this small change. The fix is targeted for jdk7u40, and the hook is needed to have a leak free event tracing implementation. http://cr.openjdk.java.net/~egahlin/8021353/ Thanks Erik

Re: RFR: Event based tracing is missing thread exit

2013-07-25 Thread Daniel D. Daugherty
On 7/25/13 9:21 AM, Erik Gahlin wrote: Hello, Could you be so kind and review this small change. The fix is targeted for jdk7u40, and the hook is needed to have a leak free event tracing implementation. http://cr.openjdk.java.net/~egahlin/8021353/ Thumbs up! The bug link in the webrev is

hg: jdk8/tl/nashorn: 3 new changesets

2013-07-25 Thread sundararajan . athijegannathan
Changeset: 5c035c4ccc61 Author:sundar Date: 2013-07-25 14:05 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5c035c4ccc61 8021252: invokeMethod throws NoSuchMethodException when script object is from different script context Reviewed-by: lagergren, hannesw !

hg: jdk8/tl/jdk: 2 new changesets

2013-07-25 Thread sean . mullan
Changeset: a834ab2c1354 Author:mullan Date: 2013-07-25 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a834ab2c1354 8010748: Add PKIXRevocationChecker NO_FALLBACK option and improve SOFT_FAIL option Reviewed-by: vinnie !

hg: jdk8/tl/jdk: 8021408: Fix misc doclint issues in java.util and java.io

2013-07-25 Thread joe . darcy
Changeset: 21120e3682ef Author:darcy Date: 2013-07-25 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21120e3682ef 8021408: Fix misc doclint issues in java.util and java.io Reviewed-by: dholmes, chegar, psandoz ! src/share/classes/java/io/ObjectInputStream.java !

Re: RFR - Changes to address CCC 8014135: Support for statically linked agents

2013-07-25 Thread bill . pittore
Still need an official reviewer for the hotspot changes for statically linked agents. thanks, bill These changes address bug 8014135 which adds support for statically linked agents in the VM. This is a followup to the recent JNI spec changes that addressed statically linked JNI libraries(

hg: jdk8/tl/jdk: 8021417: Fix doclint issues in java.util.concurrent

2013-07-25 Thread chris . hegarty
Changeset: 690dcbaa69b7 Author:chegar Date: 2013-07-25 19:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/690dcbaa69b7 8021417: Fix doclint issues in java.util.concurrent Reviewed-by: chegar, lancea Contributed-by: Doug Lea d...@cs.oswego.edu !

hg: jdk8/tl/jdk: 8021421: More doclint fixes in java.net

2013-07-25 Thread chris . hegarty
Changeset: 9cd5159fa870 Author:chegar Date: 2013-07-25 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cd5159fa870 8021421: More doclint fixes in java.net Reviewed-by: lancea, darcy ! src/share/classes/java/net/URI.java

hg: jdk8/tl/jaxp: 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE)

2013-07-25 Thread huizhe . wang
Changeset: 251ca1e2ccd3 Author:joehw Date: 2013-07-25 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/251ca1e2ccd3 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Reviewed-by: chegar, lancea, dfuchs !

hg: jdk8/tl/jdk: 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE)

2013-07-25 Thread huizhe . wang
Changeset: 662ec7782102 Author:joehw Date: 2013-07-25 13:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/662ec7782102 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Reviewed-by: chegar, lancea, dfuchs + test/javax/xml/jaxp/parsers/8021148/JAXPSAXParserTest.java +

hg: hsx/hotspot-rt/corba: Added tag jdk8-b100 for changeset 8d492f1dfd1b

2013-07-25 Thread john . coomes
Changeset: a013024b0747 Author:cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/a013024b0747 Added tag jdk8-b100 for changeset 8d492f1dfd1b ! .hgtags

hg: hsx/hotspot-rt: Added tag jdk8-b100 for changeset d2dcb110e9db

2013-07-25 Thread john . coomes
Changeset: 9f74a220677d Author:cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/9f74a220677d Added tag jdk8-b100 for changeset d2dcb110e9db ! .hgtags

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b100 for changeset 4fd722afae5c

2013-07-25 Thread john . coomes
Changeset: 60b623a36164 Author:cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/60b623a36164 Added tag jdk8-b100 for changeset 4fd722afae5c ! .hgtags

RFR(S) 8014294: Assert in ThreadTimesClosure::do_thread() due to use of naked oop instead of handle

2013-07-25 Thread Christian Tornqvist
Small fix for an assertion due to a use of a naked oop, reproduces with the original regression test. The fix has been tested by running vm.quick locally on my Windows machine and using the original regression test. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8014294/webrev.00/

Re: RFR(S) 8014294: Assert in ThreadTimesClosure::do_thread() due to use of naked oop instead of handle

2013-07-25 Thread serguei.spit...@oracle.com
Hi Christian, The fix is good. Thanks, Serguei On 7/25/13 1:56 PM, Christian Tornqvist wrote: Small fix for an assertion due to a use of a naked oop, reproduces with the original regression test. The fix has been tested by running vm.quick locally on my Windows machine and using the

hg: hsx/hotspot-rt/nashorn: 51 new changesets

2013-07-25 Thread john . coomes
Changeset: 313bdcd2fd22 Author:sundar Date: 2013-07-03 00:08 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/313bdcd2fd22 8019629: void operator should always evaluate to undefined Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java !

hg: hsx/hotspot-rt/langtools: 25 new changesets

2013-07-25 Thread john . coomes
Changeset: d6158f8d7235 Author:vromero Date: 2013-07-04 10:35 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d6158f8d7235 8009924: some langtools tools do not accept -cp as an alias for -classpath Reviewed-by: jjg !

Re: RFR: Event based tracing is missing thread exit

2013-07-25 Thread Erik Gahlin
Thanks for the review, and for providing the description and the link. Erik Daniel D. Daugherty skrev 7/25/13 5:45 PM: On 7/25/13 9:21 AM, Erik Gahlin wrote: Hello, Could you be so kind and review this small change. The fix is targeted for jdk7u40, and the hook is needed to have a leak free

Re: RFR: Event based tracing is missing thread exit

2013-07-25 Thread David Holmes
Erik, On 26/07/2013 1:21 AM, Erik Gahlin wrote: Hello, Could you be so kind and review this small change. The fix is targeted for jdk7u40, and the hook is needed to have a leak free event tracing implementation. http://cr.openjdk.java.net/~egahlin/8021353/ Seems okay. Though

Review Request (M) 7187554: JSR 292: JVMTI PopFrame needs to handle appendix arguments

2013-07-25 Thread serguei.spit...@oracle.com
Please, review the fix for: bug: http://bugs.sun.com/view_bug.do?bug_id=7187554 jbs: https://jbs.oracle.com/bugs/browse/JDK-7187554 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/7187554-JVMTI-JSR292.1 Summary: Restore the appendix argument of a polymorphic

hg: jdk8/tl/jdk: 2 new changesets

2013-07-25 Thread sean . mullan
Changeset: 1744a32d3db3 Author:mullan Date: 2013-07-25 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1744a32d3db3 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo Reviewed-by: xuelei !

About bug fix of 8010278

2013-07-25 Thread Yumin Qi
Hi, Kevin http://cr.openjdk.java.net/~kevinw/8010278/webrev.03/ http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/ I found this fix breaks C2 replay for dumping loaded java classes: at sun.jvm.hotspot.tools.jcore.PackageNameFilter.canInclude(PackageNameFilter.java:55)

hg: jdk8/tl/jdk: 8021429: Fix lint warnings in java.lang.ref

2013-07-25 Thread joe . darcy
Changeset: 86a827321c39 Author:darcy Date: 2013-07-25 20:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86a827321c39 8021429: Fix lint warnings in java.lang.ref Reviewed-by: lancea, mduigou, alanb ! src/share/classes/java/lang/ref/FinalReference.java !