Changeset: f6588f168d79
Author:hannesw
Date: 2013-07-26 13:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f6588f168d79
8020719: Run tests with reduced splitter threshold
Reviewed-by: lagergren, sundar, jlaskey
! make/build.xml
! make/project.properties
+
Hi all,
Could I have a couple of reviews for this patch, please?
https://gist.github.com/rednaxelafx/6102608
Switching the JavaScript engine from Rhino to Nashorn and the No PermGen
project caused a few issues that stopped sa.js from working. This is a
patch that tries to fix the issues that
Changeset: 8c4b2987edac
Author:jlahoda
Date: 2013-07-28 10:17 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c4b2987edac
8020689: Missing LineNumberTable entries in compiled class files
Reviewed-by: ksrini, mcimadamore
!
Hi David,
Nice catch!
I moved the fragment from another file and forgot to remove the #if.
Thanks!
Serguei
On 7/28/13 9:11 PM, David Holmes wrote:
Hi Serguei,
On 26/07/2013 10:14 AM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug:
Changeset: 0532397d0732
Author:sundar
Date: 2013-07-29 18:07 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0532397d0732
8012792: print function defined in engine.js does not handle multiple arguments
Reviewed-by: hannesw
!
Changeset: e83fc6d9cf03
Author:psandoz
Date: 2013-07-29 19:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e83fc6d9cf03
8020156: TreeMap.values().spliterator() does not report ORDERED
8020009: TreeMap.entrySet().spliterator() reports SORTED + null comparator but
the
Please review a small change.
Description:
UE feedback: The Threads list in jconsole doesn't have one thread
selected by default. Selecting one thread (e.g. the first thread) by
default is confusing. The first thread is not necessarily very
interesting to look at.
Solution:
Write short
Please review a small change.
Description:
-interval=0 command line option is accepted. In this case jconsole
doesn't update content at all. It seems that such functionality is
useless for an ordinary user.
Solution:
If interval of zero or less is specified the help text shown, similar to
Please review a small change.
Description:
Start JConsole from the commandline using the Nimbus look feel:
jconsole
-J-Dswing.defaultlaf=com.sun.java.swing.plaf.nimbus.NimbusLookAndFeel
The main window opens, but when creating the 'Connect to..' dialog, we
get a NPE:
Bug:
Please review a small change:
Description:
Switch to the Threads tab and try shrinking the window. When the window
width becomes smaller than some particular size, an exception is printed
to the terminal on every window update.
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=6358357
Webrev:
Please review a small change.
Description:
Strings should be changed to navigating tabular data structure or
tabular data navigation
Solution:
Inserted Data into the titles Composite Navigation and Tabular
Navigation.
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=7015157
Webrev:
Please review a small change.
Description:
Memory graph in Memory tab is not redrawn until the next redraw interval.
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=6417702
Webrev:
http://cr.openjdk.java.net/~egahlin/6417702/
Testing:
Verified that plots are redrawn immediately after a combo
Please review a small change.
Description:
If several threads are selected in the Threads list in the Threads tab,
some thread info is still shown in the thread info panel.
Solution:
Only allow one thread to be selected at a time, so thread info reflect
list selection.
Bug:
Just a small nit - the copyright year should be updated.
Other than that it looks fine.
I can sponsor the push.
-JB-
On 07/29/2013 12:50 PM, Erik Gahlin wrote:
Please review a small change.
Description:
UE feedback: The Threads list in jconsole doesn't have one thread
selected by default.
Changeset: c042fd498f79
Author:ascarpino
Date: 2013-07-19 11:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c042fd498f79
8012971: PKCS11Test hiding exception failures
Reviewed-by: vinnie, valeriep
! test/ProblemList.txt
! test/sun/security/pkcs11/PKCS11Test.java
!
Hi Erik,
I wonder whether it wouldn't be better to default the w to
sufficiently small non-null number (eg. 1) than just abandon the whole
process.
Also, the copyright year should be updated.
I can be the sponsor.
-JB-
On 07/29/2013 01:02 PM, Erik Gahlin wrote:
Please review a small change:
Looks good.
I can be the sponsor.
-JB-
On 07/29/2013 01:13 PM, Erik Gahlin wrote:
Please review a small change.
Description:
Strings should be changed to navigating tabular data structure or
tabular data navigation
Solution:
Inserted Data into the titles Composite Navigation and
Looks good.
I can be the sponsor.
-JB-
On 07/29/2013 01:16 PM, Erik Gahlin wrote:
Please review a small change.
Description:
Memory graph in Memory tab is not redrawn until the next redraw interval.
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=6417702
Webrev:
Looks good.
I can be the sponsor.
-JB-
On 07/29/2013 01:25 PM, Erik Gahlin wrote:
Please review a small change.
Description:
If several threads are selected in the Threads list in the Threads tab,
some thread info is still shown in the thread info panel.
Solution:
Only allow one
The change looks good.
I can be the sponsor.
-JB-
On 07/29/2013 12:52 PM, Erik Gahlin wrote:
Please review a small change.
Description:
-interval=0 command line option is accepted. In this case jconsole
doesn't update content at all. It seems that such functionality is
useless for an
Christian and David,
Thank you for the quick review and comments!
This is a new version of webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/7187554-JVMTI-JSR292.2
Thanks,
Serguei
On 7/28/13 9:11 PM, David Holmes wrote:
Hi Serguei,
On 26/07/2013 10:14 AM,
Changeset: 613cc7beba64
Author:xuelei
Date: 2013-07-29 19:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/613cc7beba64
8021841: Remove SSLEngineDeadlock.java from problem list
Reviewed-by: wetmore
! test/ProblemList.txt
On 30/07/2013 10:34 AM, serguei.spit...@oracle.com wrote:
Christian and David,
Thank you for the quick review and comments!
This is a new version of webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/7187554-JVMTI-JSR292.2
Sorry. You need that guard after all - at least you do
On 7/29/13 8:22 PM, David Holmes wrote:
On 30/07/2013 10:34 AM, serguei.spit...@oracle.com wrote:
Christian and David,
Thank you for the quick review and comments!
This is a new version of webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/7187554-JVMTI-JSR292.2
Sorry. You
Hi Serguei,
I'm fine with restoring to what was in the first webrev.
Further trimming of the JVMTI code is something the embedded folk could
look at. It may not be worthwhile.
Thanks,
David
On 30/07/2013 3:05 PM, serguei.spit...@oracle.com wrote:
On 7/29/13 8:22 PM, David Holmes wrote:
On
25 matches
Mail list logo
