Re: RFR (XS): 6800801: NPE in JConsole when using Nimbus LF

Hi Erik, src/share/classes/sun/tools/jconsole/VMPanel.java 156 if (insets == null) { 157 insets = (Insets) insets.clone(); 158 insets.right += connectedIcon24.getIconWidth() + 8; 159 UIManager.put(TabbedPane.tabAreaInsets, insets); 160 }

Re: RFR (XS): 7015157: String Tabular Navigation should be rephrased for avoiding mistranslation

Looks fine to me. Shanliang Erik Gahlin wrote: Please review a small change. Description: Strings should be changed to navigating tabular data structure or tabular data navigation Solution: Inserted Data into the titles Composite Navigation and Tabular Navigation. Bug:

Re: RFR (XS): 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box

Looks fine to me. Shanliang Erik Gahlin wrote: Please review a small change. Description: Memory graph in Memory tab is not redrawn until the next redraw interval. Bug: http://monaco.us.oracle.com/detail.jsf?cr=6417702 Webrev: http://cr.openjdk.java.net/~egahlin/6417702/ Testing: Verified

Re: RFR (XS): 6417721: Thread list should not allow multiple selection

Looks fine to me. Shanliang Erik Gahlin wrote: Please review a small change. Description: If several threads are selected in the Threads list in the Threads tab, some thread info is still shown in the thread info panel. Solution: Only allow one thread to be selected at a time, so thread

Re: SA: Various fixes to sa.js to make it work in JDK8

Hi Kris, All the JavaScript changes look good to me. Thanks for taking care of rhino-vs-nashorn compatibility issues. PS. I used to work in hotspot serviceability agent in the past. Now, I'm with the nashorn team. Thanks -Sundar On Monday 29 July 2013 01:23 PM, Krystal Mok wrote: Hi all,

Re: SA: Various fixes to sa.js to make it work in JDK8

Hi Sundar, Thank you very much for taking a look at this. It has been quite a while since sa.js was broken, and it's a pain to use CLHSDB without sa.js functioning. Could you please sponsor this patch, and help me find another Reviewer to get this in? By the way, my OpenJDK username is kmo.

Re: Review Request (M) 7187554: JSR 292: JVMTI PopFrame needs to handle appendix arguments

Thanks, David! Run this through a JPRT test build for productEmb to check that the minimal VM builds ok. Yes, I'll test it with a JPRT test build. Thanks, Serguei On 7/29/13 10:11 PM, David Holmes wrote: Hi Serguei, I'm fine with restoring to what was in the first webrev. Further

Re: RFR (XS): 6359971:Threads tab: Simple text to explain that one can click on a thread to get stack trace

Thanks Jaroslav, will fix. If a reviewer could also have a look, it would be great. Thanks Erik Jaroslav Bachorik skrev 2013-07-29 22:52: Just a small nit - the copyright year should be updated. Other than that it looks fine. I can sponsor the push. -JB- On 07/29/2013 12:50 PM, Erik Gahlin

Re: Review Request (M) 7187554: JSR 292: JVMTI PopFrame needs to handle appendix arguments

The updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/7187554-JVMTI-JSR292.3/ Thanks, Serguei On 7/29/13 10:11 PM, David Holmes wrote: Hi Serguei, I'm fine with restoring to what was in the first webrev. Further trimming of the JVMTI code is something the embedded

hg: jdk8/tl/jdk: 8021833: javadoc cleanup in java.net

Changeset: c76f89695c90 Author:juh Date: 2013-07-30 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c76f89695c90 8021833: javadoc cleanup in java.net Summary: code and tt converted to {@code }; package.html to package-info.java Reviewed-by: darcy, chegar !

Re: RFR - Changes to address CCC 8014135: Support for statically linked agents

Thanks Serguei for the comments. Some comments inline. I updated the webrevs at http://cr.openjdk.java.net/~bpittore/8014135/jdk/webrev.02/ http://cr.openjdk.java.net/~bpittore/8014135/hotspot/webrev.01/ http://cr.openjdk.java.net/~bpittore/8014135/javadoc/index.html

Re: RFR (XS): 6800801: NPE in JConsole when using Nimbus LF

Nice catch, thanks Shanliang. Erik Shanliang skrev 2013-07-30 09:14: Hi Erik, src/share/classes/sun/tools/jconsole/VMPanel.java 156 if (insets == null) { 157 insets = (Insets) insets.clone(); 158 insets.right += connectedIcon24.getIconWidth() + 8; 159

hg: jdk8/tl/jdk: 8021767: test/java/time/tck/java/time/format/TCKFormatStyle.java failing

Changeset: 8bc1bbd5b659 Author:sherman Date: 2013-07-30 14:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8bc1bbd5b659 8021767: test/java/time/tck/java/time/format/TCKFormatStyle.java failing Summary: Correct to use fixed locale, not locale of test environment

hg: jdk8/tl/jdk: 8020977: StringJoiner merges with itself not as expected

Changeset: 09a77a1bdbc3 Author:henryjen Date: 2013-07-30 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09a77a1bdbc3 8020977: StringJoiner merges with itself not as expected Reviewed-by: psandoz, chegar, mduigou, smarks ! src/share/classes/java/util/StringJoiner.java

hg: hsx/hotspot-rt/hotspot: 8021296: [TESTBUG] Test8017498.sh fails to find gcc and fails to compile on some Linux releases

Changeset: f9ee986a9fea Author:ccheung Date: 2013-07-30 14:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f9ee986a9fea 8021296: [TESTBUG] Test8017498.sh fails to find gcc and fails to compile on some Linux releases Summary: Added checking for gcc and