Re: RFR (XS) 8023406 - [windows] build_vm_def.sh takes too long even when BUILD_WIN_SA != 1

Ioi, One question, SKIP_GENERATED, is this a environment variable or need to give on command? Others looks OK. Thanks Yumin On 8/20/2013 2:11 PM, Ioi Lam wrote: |Please review a very small fix:|| || ||http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_001/|| || ||Bug: m

Re: RFR: 8022808: Kitchensink hangs on macos

On 21/08/2013 3:39 AM, Gerard Ziemski wrote: On 8/20/2013 4:14 AM, Dmitry Samersoff wrote: 2. Why are we using the the "::" C++ name space before mach/pthread C >APIs calls? I understand that you might be just following the existing >pattern in the file, I'm just wondering if you, or anyone kno

hg: jdk8/tl: 8023433: Improve 'make help'

Changeset: c8da1b6a9762 Author:mduigou Date: 2013-08-20 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c8da1b6a9762 8023433: Improve 'make help' Reviewed-by: tbell ! NewMakefile.gmk

hg: hsx/hotspot-rt/hotspot: 8023287: HOTSPOT_BUILD_COMPILER needs to support "Sun Studio 12u3"

Changeset: 9d6c9b0a8f15 Author:dcubed Date: 2013-08-20 13:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9d6c9b0a8f15 8023287: HOTSPOT_BUILD_COMPILER needs to support "Sun Studio 12u3" Summary: Recognize 0x5120 as "Sun Studio 12u3". Reviewed-by: dholmes, coleenp

Re: RFR (XS): 7023754 JConsole Javascript plugin demo throws exception on window.print

Looks okay to me. Mandy On 8/19/2013 11:16 AM, Erik Gahlin wrote: Thanks Andreas, Here is an updated webrev with an updated copyright header. http://cr.openjdk.java.net/~egahlin/7023754_2/ The same issue was fixed with "8016531: jconsole-plugin script demo does not work with nashorn" http://c

hg: jdk8/tl/langtools: 8013887: In class use, some tables are randomly unsorted

Changeset: 720992953d43 Author:jjg Date: 2013-08-20 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/720992953d43 8013887: In class use, some tables are randomly unsorted Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java

Re: RFR (XS) 8023406 - [windows] build_vm_def.sh takes too long even when BUILD_WIN_SA != 1

Adding in Serviceability Team since the SA belongs to them. Dan On 8/20/13 3:11 PM, Ioi Lam wrote: |Please review a very small fix:|| || ||http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_001/|| || ||Bug: make/windows/build_vm_def.sh takes too long even when BUILD_WIN_SA !=

Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

On 8/20/13 11:12 PM, shanliang wrote: Thanks Daniel and Erik for the comments, here is new version: http://cr.openjdk.java.net/~sjiang/JDK-6566891/01/ This new version looks reasonable. I guess you could dispense of the new nullSubjectConnRef by just using 'null' as key in the WeakHashMap (a

hg: jdk8/tl/langtools: 8022080: javadoc generates invalid HTML in Turkish locale

Changeset: 79e341614c50 Author:jjg Date: 2013-08-20 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79e341614c50 8022080: javadoc generates invalid HTML in Turkish locale Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.jav

hg: jdk8/tl/langtools: 7179455: tools/javac/processing/model/testgetallmembers/Main.java fails against JDK 7 and JDK 8

Changeset: 0f88e3d3d250 Author:ksrini Date: 2013-08-20 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f88e3d3d250 7179455: tools/javac/processing/model/testgetallmembers/Main.java fails against JDK 7 and JDK 8 Reviewed-by: jjg ! test/tools/javac/processing/mode

hg: jdk8/tl/langtools: 8020663: Restructure some properties to facilitate better translation

Changeset: a76dc1b4c299 Author:jjg Date: 2013-08-20 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a76dc1b4c299 8020663: Restructure some properties to facilitate better translation Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/re

Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

Thanks Daniel and Erik for the comments, here is new version: http://cr.openjdk.java.net/~sjiang/JDK-6566891/01/ Erik Gahlin wrote: Shanliang, Let's say the delgationSubject is null and there is previous connection cached (nullSubjectConn != null && nullSubjectConn.get() != null) so you

hg: jdk8/tl/langtools: 8011043: Warn about use of 1.5 and earlier source and target values

Changeset: 58da1296c6b3 Author:darcy Date: 2013-08-20 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58da1296c6b3 8011043: Warn about use of 1.5 and earlier source and target values Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java !

Re: Review Request (M) 7187554: JSR 292: JVMTI PopFrame needs to handle appendix arguments

John, Thank you for the comments! In fact, I was very reluctant to implement it the way as it is in the webrev. I'm in favor of the choice #3, and think, it is much better from the stability point of view. Restoring the MemberName slot at deoptimization is not going to cause a performance degr

Re: RFR (S): 8023101 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails

Hi Staffan -- Thanks for the explanation. I see. Can you check if you can replicate that behaviour with CMS also? I submit that, as Shanliang states, this is not a best efforts behavior. As I recall, in CMS, we used the full gc counts to ensure that the system gc would take effect. I'd assume that

Re: RFR: 8022808: Kitchensink hangs on macos

On 8/20/2013 4:14 AM, Dmitry Samersoff wrote: 2. Why are we using the the "::" C++ name space before mach/pthread C >APIs calls? I understand that you might be just following the existing >pattern in the file, I'm just wondering if you, or anyone knows why. C++ :: means global scope and it solv

hg: jdk8/tl/jdk: 8023250: Update JavaScript code in JDK for changes in iteration over Java arrays

Changeset: 1ccc7bbee0bb Author:attila Date: 2013-08-20 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ccc7bbee0bb 8023250: Update JavaScript code in JDK for changes in iteration over Java arrays Reviewed-by: sundar, sla ! src/share/classes/com/sun/tools/hat/resources/

hg: jdk8/tl/jdk: 8023367: Collections.emptyList().sort((Comparator)null) throws NPE

Changeset: c17d6543b30f Author:psandoz Date: 2013-08-20 17:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c17d6543b30f 8023367: Collections.emptyList().sort((Comparator)null) throws NPE Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Collections.java ! test/java

Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

Shanliang, Let's say the delgationSubject is null and there is previous connection cached (nullSubjectConn != null && nullSubjectConn.get() != null) so you hit: 2016: conn = nullSubjectConn.get(); but before you get the object a GC occurs and clears reference, then getConnectionWithSubject

Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

webrev: http://cr.openjdk.java.net/~sjiang/JDK-6566891/00/ shanliang wrote: Hi, Please review: webrev: http://amos.fr.oracle.com/jmgt/user/sjiang/webrevs/jdk8-6566891/00/ bug: https://jbs.oracle.com/bugs/browse/JDK-6566891 I have passed JCK tests and unit tests. Thanks, Shanliang

hg: jdk8/tl/langtools: 8019243: AnnotationTypeMismatchException instead of MirroredTypeException

Changeset: e811fb09a1dc Author:jfranck Date: 2013-08-20 17:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e811fb09a1dc 8019243: AnnotationTypeMismatchException instead of MirroredTypeException Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Attribute.j

hg: jdk8/tl/jdk: 8016727: test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently

Changeset: 961cdea684b5 Author:sla Date: 2013-08-20 16:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/961cdea684b5 8016727: test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently Reviewed-by: alanb ! test/com/sun/jdi/sde/TemperatureTableTest.java

Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

Hi, Please review: webrev: http://amos.fr.oracle.com/jmgt/user/sjiang/webrevs/jdk8-6566891/00/ bug: https://jbs.oracle.com/bugs/browse/JDK-6566891 I have passed JCK tests and unit tests. Thanks, Shanliang

hg: jdk8/tl/langtools: 7182350: Regression in wording of unchecked warning message

Changeset: 55da6b3a6940 Author:kizune Date: 2013-08-20 17:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55da6b3a6940 7182350: Regression in wording of unchecked warning message Reviewed-by: mcimadamore, jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java !

Re: RFR(XS): JDK-8016727 : test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently

On 20/08/2013 13:34, Staffan Larsen wrote: This test was missing a jtreg directive to compile the HelloWorld class. How could this ever have worked? webrev: http://cr.openjdk.java.net/~sla/8016727/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016727 This looks fine to me,

Re: Please review JDK-8023250

+1 -Sundar On Tuesday 20 August 2013 03:01 PM, Attila Szegedi wrote: Folks, I'm about to introduce a change to Nashorn that requires some small modifications to hat.js to preserve backwards compatibility. If you could please review

RFR(XS): JDK-8016727 : test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently

This test was missing a jtreg directive to compile the HelloWorld class. How could this ever have worked? webrev: http://cr.openjdk.java.net/~sla/8016727/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016727 Thanks, /Staffan

Re: Please review JDK-8023250

Looks good - although I am not an official Reviewer. I can push the change for you once an official Reviewer says ok. Thanks, /Staffan On 20 aug 2013, at 11:31, Attila Szegedi wrote: > Folks, > > I'm about to introduce a change to Nashorn that requires some small > modifications to hat.js to

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: e22ee8e7ae62 Author:jiangli Date: 2013-08-19 14:59 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e22ee8e7ae62 8021948: Change InstanceKlass::_source_file_name and _generic_signature from Symbol* to constant pool indexes. Summary: Change InstanceKlass::

Please review JDK-8023250

Folks, I'm about to introduce a change to Nashorn that requires some small modifications to hat.js to preserve backwards compatibility. If you could please review . If approved, I will also need someone to commit it for me as I d

Re: RFR: 8022808: Kitchensink hangs on macos

On 2013-08-19 20:11, Gerard Ziemski wrote: > hi Staffan, > > A search on the topic of Mac thread id reveals that pretty much everyone > (including Apple itself) uses pthread_mach_thread_np() for thread id, so > it looks like you're correct to use it. > > I do have some more quick feedback/questio

Re: RFR (S): 8023101 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails

Thanks Staffan for sharing the info, it explain why we got failed sometime on our memory leak tests and we had to call System.gc several times. I looked at the System.gc Javadoc: - Calling the gc method suggests that the Java Virtual Machine expend e

Re: RFR (S): 8023101 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails

Bengt in the GC group helped me out in making sense of this. Here is my interpretation of his analysis (any errors are mine). Pasted below is the output of the test with -XX:+PrintGCDetails added. This shows that a concurrent GC was started when the large object was allocated. After the object

Re: RFR (S): 8023101 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails

Hi Shanliang -- That's curious. If the array is unreachable, and you do a full gc (of the stop world variety -- either serial/parallel, or CMS/G1 with ExplicitGCInvokesConcurrent switched off) then the array should be reclaimed and if free space book-keeping is correct, the memory usage after sho

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 10c59b8021ec Author:kevinw Date: 2013-08-19 14:28 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c59b8021ec 8022655: ClassDump ignored jarStream setting Reviewed-by: minqi, sla ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! tes

hg: jdk8/tl/jdk: 8023311: Clean up profile-includes.txt

Changeset: e17da8b09f5e Author:dholmes Date: 2013-08-20 03:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e17da8b09f5e 8023311: Clean up profile-includes.txt Reviewed-by: alanb ! makefiles/profile-includes.txt

hg: jdk8/tl/jdk: 8022071: Some vm/jvmti tests fail because cannot attach to the Java virtual machine

Changeset: 53ea4b5cef9b Author:sla Date: 2013-08-20 08:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53ea4b5cef9b 8022071: Some vm/jvmti tests fail because cannot attach to the Java virtual machine Reviewed-by: erikj, sspitsyn ! makefiles/CompileNativeLibraries.gmk + ma