hg: jdk8/tl/jdk: 8020816: Metafactory crashes on code with method reference; ...

2013-09-04 Thread robert . field
Changeset: bd6fcc5eebb8 Author:rfield Date: 2013-09-04 19:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6fcc5eebb8 8020816: Metafactory crashes on code with method reference 8021050: MethodHandleInfo throws exception when method handle is to a method with @CallerSensit

Re: RR(S): JDK-8015848: SA: ByteCodeRewriter needs implementation for invokedynamic

2013-09-04 Thread Christian Thalinger
On Sep 4, 2013, at 1:35 PM, Dmitry Samersoff wrote: > Please, review the changes. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8015848/webrev.01/ With this change you can dump the boot class path classes again? -- Chris > > -Dmitry > > -- > Dmitry Samersoff > Oracle Java development te

hg: jdk8/tl/langtools: 8024288: javadoc generated-by comment should always be present

2013-09-04 Thread jonathan . gibbons
Changeset: 044721d4d359 Author:jjg Date: 2013-09-04 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/044721d4d359 8024288: javadoc generated-by comment should always be present Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWri

RR(S): JDK-8015848: SA: ByteCodeRewriter needs implementation for invokedynamic

2013-09-04 Thread Dmitry Samersoff
Please, review the changes. http://cr.openjdk.java.net/~dsamersoff/JDK-8015848/webrev.01/ -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.

hg: jdk8/tl/jdk: 7186632: NLS t13y issue on jar.properties file

2013-09-04 Thread xueming . shen
Changeset: c6a4df06d57e Author:sherman Date: 2013-09-04 12:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6a4df06d57e 7186632: NLS t13y issue on jar.properties file Summary: to remove the redundant backslash Reviewed-by: naoto ! src/share/classes/sun/tools/jar/resources/

hg: jdk8/tl/jdk: 6341345: (spec) Console.reader() should make it clear that the reader requires line termination

2013-09-04 Thread xueming . shen
Changeset: 478afc30679b Author:sherman Date: 2013-09-04 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/478afc30679b 6341345: (spec) Console.reader() should make it clear that the reader requires line termination Summary: to clarify the spec Reviewed-by: alanb ! src/sh

Re: Review Request (M) 7187554: JSR 292: JVMTI PopFrame needs to handle appendix arguments

2013-09-04 Thread John Rose
Yes, please file this bug. I'm working on MH-related optimizations, and I am finding that preserving the required code pattern is blocking some optimizations, notably making customized variations of direct MHs. (The required code pattern is that the DMH in Local#0 has a member field which supp

hg: jdk8/tl/nashorn: 2 new changesets

2013-09-04 Thread sundararajan . athijegannathan
Changeset: b5ff11e00050 Author:sundar Date: 2013-09-04 14:29 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b5ff11e00050 8024120: Setting __proto__ to null removes the __proto__ property Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/runtime/ScriptObject.java

hg: jdk8/tl/jdk: 8019853: Break logging and AWT circular dependency

2013-09-04 Thread daniel . fuchs
Changeset: b3d6953b9829 Author:dfuchs Date: 2013-09-04 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3d6953b9829 8019853: Break logging and AWT circular dependency Summary: Break logging and AWT circular dependency, which was at the root cause for 8023258 - Logger.ge

hg: hsx/hotspot-rt/hotspot: 8022798: "assert(seq > 0) failed: counter overflow" in Kitchensink

2013-09-04 Thread zhengyu . gu
Changeset: baa7927dfbd2 Author:zgu Date: 2013-09-04 08:55 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/baa7927dfbd2 8022798: "assert(seq > 0) failed: counter overflow" in Kitchensink Summary: Removed incorrect assertion, sequence number can overflow Reviewed-by:

hg: jdk8/tl/jdk: 6823527: java.util.logging.Handler has thread safety issues

2013-09-04 Thread daniel . fuchs
Changeset: ac6e99af2056 Author:dfuchs Date: 2013-09-04 15:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac6e99af2056 6823527: java.util.logging.Handler has thread safety issues Reviewed-by: dholmes, mchung ! src/share/classes/java/util/logging/ConsoleHandler.java ! src/s

hg: jdk8/tl/langtools: 8008275: javac.Main should be @Supported

2013-09-04 Thread vicente . romero
Changeset: b94824ddcbb6 Author:vromero Date: 2013-09-04 11:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b94824ddcbb6 8008275: javac.Main should be @Supported Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/Main.java

hg: jdk8/tl/jdk: 8008981: Deprecate SecurityManager checkTopLevelWindow, checkSystemClipboardAccess, checkAwtEventQueueAccess

2013-09-04 Thread alan . bateman
Changeset: 336784cd60c3 Author:alanb Date: 2013-09-04 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/336784cd60c3 8008981: Deprecate SecurityManager checkTopLevelWindow, checkSystemClipboardAccess, checkAwtEventQueueAccess Reviewed-by: anthony, art, mchung ! src/macos

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-04 Thread Jaroslav Bachorik
On 09/04/2013 10:29 AM, David Holmes wrote: > On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote: >> On 09/04/2013 04:24 AM, Mandy Chung wrote: >>> Hi Jaroslav, >>> >>> Like Daniel and David said, CyclicBarrier and other j.u.concurrent >>> utility seem a good replacement with the ThreadExecutionSynchron

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-04 Thread David Holmes
On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote: On 09/04/2013 04:24 AM, Mandy Chung wrote: Hi Jaroslav, Like Daniel and David said, CyclicBarrier and other j.u.concurrent utility seem a good replacement with the ThreadExecutionSynchronizer class. ThreadMXBean/Locks.java was written prior to j.u

hg: jdk8/tl/jdk: 8023463: Improvements to HashMap/LinkedHashMap use of bins/buckets and trees (red/black); ...

2013-09-04 Thread paul . sandoz
Changeset: d62c911aebbb Author:psandoz Date: 2013-09-04 09:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d62c911aebbb 8023463: Improvements to HashMap/LinkedHashMap use of bins/buckets and trees (red/black) 8012913: LinkedHashMap key/value/entry spliterators should repor

hg: hsx/hotspot-rt/langtools: 21 new changesets

2013-09-04 Thread john . coomes
Changeset: 7de231613e4a Author:jjg Date: 2013-08-21 16:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7de231613e4a 8023515: import type-annotations updates Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/source/tree/MethodTree.ja

hg: hsx/hotspot-rt/nashorn: 24 new changesets

2013-09-04 Thread john . coomes
Changeset: dbb0a20a6f27 Author:attila Date: 2013-08-21 13:39 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/dbb0a20a6f27 8023373: allow super invocation for adapters Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenera

hg: hsx/hotspot-rt/jdk: 48 new changesets

2013-09-04 Thread john . coomes
Changeset: eb18a483e772 Author:alanb Date: 2013-08-21 09:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eb18a483e772 8023351: Add TEST.groups in preparation to simplify rules in jdk/test/Makefile Reviewed-by: lancea, mduigou ! test/TEST.ROOT + test/TEST.groups Cha

hg: jdk8/tl/jdk: 8024182: test/java/util/Arrays/SetAllTest.java fails to compile due to recent compiler changes

2013-09-04 Thread paul . sandoz
Changeset: 462c5589bc1a Author:psandoz Date: 2013-08-12 12:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/462c5589bc1a 8024182: test/java/util/Arrays/SetAllTest.java fails to compile due to recent compiler changes Summary: Use explicit lambda due to javac simplfying rules

hg: hsx/hotspot-rt/jaxws: 4 new changesets

2013-09-04 Thread john . coomes
Changeset: b99d7e355d4b Author:mkos Date: 2013-08-23 09:57 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/b99d7e355d4b 8022885: Update JAX-WS RI integration to 2.2.9-b14140 8013016: Rebase 8009009 against the latest jdk8/jaxws Reviewed-by: alanb, chegar ! src/share

hg: hsx/hotspot-rt: 5 new changesets

2013-09-04 Thread john . coomes
Changeset: c8da1b6a9762 Author:mduigou Date: 2013-08-20 17:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c8da1b6a9762 8023433: Improve 'make help' Reviewed-by: tbell ! NewMakefile.gmk Changeset: f643fee2b40f Author:mduigou Date: 2013-08-26 10:09 -0700 URL:

Re: jmx-dev RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-04 Thread Daniel Fuchs
Hi Jaroslav, That looks like a reasonable small change if you are anxious to get that fix out of your plate fast. I'll trust that your analysis is right and that declaring waiting volatile is enough to fix the issue. It was certainly an error to access 'waiting' from multiple threads without any

Re: jmx-dev RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

2013-09-04 Thread Jaroslav Bachorik
[ping] Thanks for the reviews. I still need a reviewer to take a look at this. This issue blocks a P2 targeted for JDK8 (JDK-7148504). Thanks, -JB- On 07/18/2013 11:54 AM, Jaroslav Bachorik wrote: > Hi, > > thanks for the comments. > > Here (http://cr.openjdk.java.net/~jbachorik/8002307/webre