Re: Codereview request for JDK-8023669: MBean*Info.hashCode : NPE

2013-09-10 Thread shanliang
David Holmes wrote: On 30/08/2013 12:11 AM, shanliang wrote: Here is the new version: http://cr.openjdk.java.net/~sjiang/jdk-8023669/01/ This seems good to address the NPE potential. You are changing the values of the hashcodes though - is that a problem? Good question! It should not be

hg: jdk8/tl/jdk: 8024141: Unexpected timezone display name

2013-09-10 Thread masayoshi . okutsu
Changeset: 13ee370ee8b3 Author:okutsu Date: 2013-09-11 15:29 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13ee370ee8b3 8024141: Unexpected timezone display name Reviewed-by: peytoia ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/sun/util/locale/pr

hg: jdk8/tl/jdk: 8024501: sun.security.mscapi.Key has no definition of serialVersionUID

2013-09-10 Thread xuelei . fan
Changeset: c9083205e6eb Author:xuelei Date: 2013-09-10 21:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9083205e6eb 8024501: sun.security.mscapi.Key has no definition of serialVersionUID Reviewed-by: weijun ! src/windows/classes/sun/security/mscapi/Key.java

Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

2013-09-10 Thread David Holmes
On 11/09/2013 8:00 AM, Kumar Srinivasan wrote: Here are the updated changes: Looks okay to me. David The build changes are here: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/ the delta changes since last reviewed: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev

Re: jmx-dev Codereview request: 8023529 OpenMBeanInfoSupport.equals/hashCode throw NPE

2013-09-10 Thread David Holmes
I'm a bit confused. The two webrevs are vastly different: http://cr.openjdk.java.net/~sjiang/jdk-8023529/01/ http://cr.openjdk.java.net/~sjiang/jdk-8023529/00/ Should they be combined somehow? David - On 11/09/2013 12:15 AM, shanliang wrote: Jaroslav Bachorik wrote: On 09/05/2013 10:37

Re: Re: Codereview request for JDK-8023669: MBean*Info.hashCode : NPE

2013-09-10 Thread David Holmes
On 30/08/2013 12:11 AM, shanliang wrote: Here is the new version: http://cr.openjdk.java.net/~sjiang/jdk-8023669/01/ This seems good to address the NPE potential. You are changing the values of the hashcodes though - is that a problem? In javax/management/MBeanInfo.java Objects.hash(getC

Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

2013-09-10 Thread Kumar Srinivasan
Here are the updated changes: The build changes are here: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/ the delta changes since last reviewed: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev.delta/index.html The jdk changes are here: http://cr.openjdk.java.net/~ks

hg: jdk8/tl/langtools: 8024414: javac, should facilitate the use of the bootstrap compiler for debugging

2013-09-10 Thread vicente . romero
Changeset: d87f017ec217 Author:mcimadamore Date: 2013-09-10 16:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d87f017ec217 8024414: javac, should facilitate the use of the bootstrap compiler for debugging Reviewed-by: jjg ! make/netbeans/langtools/build.xml ! make/

Re: jmx-dev Codereview request: 8023529 OpenMBeanInfoSupport.equals/hashCode throw NPE

2013-09-10 Thread shanliang
Jaroslav Bachorik wrote: On 09/05/2013 10:37 AM, shanliang wrote: I have added 2 tasts to make sure that call OpenMBean*InfoSupport.equals/hashCode do not throw NPE The unit tests and JCK tests are passed. Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8023529/00/ Bug: https://bugs.openjdk.j

RE: Project to improve hs_err files

2013-09-10 Thread Mattis Castegren
Hi I don't think these problems will be critical: "1. As David already mentioned we are in context of crash handler, so increasing the number of calls we are doing, we increase the probability to finally get nothing." Right now I am gathering feedback on what information would really help diffe

hg: jdk8/tl/langtools: 8005222: Fixed bugs should have tests with bugid in @bug tag

2013-09-10 Thread joel . franck
Changeset: bb7271e64ef6 Author:jfranck Date: 2013-09-10 13:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb7271e64ef6 8005222: Fixed bugs should have tests with bugid in @bug tag Reviewed-by: jfranck, jjg Contributed-by: Andreas Lundblad ! test/tools/javac/default

Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

2013-09-10 Thread Staffan Larsen
In SunCommandLineLauncher.java: 198 if (home.length() > 0) { 199 String os_arch = System.getProperty("os.arch"); 200 if ("SunOS".equals(System.getProperty("os.name"))) { 201 exePath = home + File.separator + "bin" + File.separato

hg: jdk8/tl/jdk: 8023878: (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java fails intermittently

2013-09-10 Thread alan . bateman
Changeset: 909aced59bef Author:alanb Date: 2013-09-10 10:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/909aced59bef 8023878: (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java fails intermittently Reviewed-by: alanb Contributed-by: yiming.w...@oracle.com