hg: jdk8/tl/jdk: 8023669: MBean*Info.hashCode : NPE

2013-09-13 Thread shanliang . jiang
Changeset: ba0b95f310c8 Author:sjiang Date: 2013-09-13 10:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba0b95f310c8 8023669: MBean*Info.hashCode : NPE Reviewed-by: dholmes, dfuchs, jbachorik ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classe

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-13 Thread David Holmes
On 13/09/2013 5:21 AM, serguei.spit...@oracle.com wrote: On 9/11/13 8:54 PM, David Holmes wrote: Hi Dmitry, It seems odd that you install the new_method even if there was an exception. What if the new_method is not valid because of the exception ? Coleen suggested this fragment. New methods w

Re: Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

2013-09-13 Thread David Holmes
Thanks - no further comments. David On 13/09/2013 10:21 AM, serguei.spit...@oracle.com wrote: The updated open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 1:03 PM, serguei.spit...@oracle.com wrote: On 9/11/13 9:09 PM, Dav

Re: Review Request (S) 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool

2013-09-13 Thread David Holmes
Looks good to me. Thanks, David On 13/09/2013 10:19 AM, serguei.spit...@oracle.com wrote: The update open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024345-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 5:13 PM, serguei.spit...@oracle.com wrote: The updated webrev: http://

hg: jdk8/tl/jdk: 8024009: Remove jdk.map.useRandomSeed system property

2013-09-13 Thread alan . bateman
Changeset: cc2bae7f8fbb Author:bchristi Date: 2013-09-12 14:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc2bae7f8fbb 8024009: Remove jdk.map.useRandomSeed system property Summary: Removed usage of hashSeed in Hashtable & WeakHashMap, and removed tests Reviewed-by: alanb

hg: jdk8/tl/jdk: 8024675: java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows

2013-09-13 Thread chris . hegarty
Changeset: c53411f89b4c Author:msheppar Date: 2013-09-13 12:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c53411f89b4c 8024675: java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows Summary: amended test to add active, i.e. isUp(), NetworkInterfaces to te

hg: jdk8/tl/nashorn: 5 new changesets

2013-09-13 Thread sundararajan . athijegannathan
Changeset: e60f6add90d7 Author:hannesw Date: 2013-09-12 14:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e60f6add90d7 8024476: Octane regression on Richards Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/runtime/JSType.java Changeset: 572a2e50ba9e Author:

Re: RR(S): JDK-8009213 sun/management/jdp/JdpTest.sh fails with exit code 1

2013-09-13 Thread Staffan Larsen
Looks ok. /Staffan On 13 sep 2013, at 00:22, Dmitry Samersoff wrote: > Forgot to include webrev link. Sorry! > > http://cr.openjdk.java.net/~dsamersoff/JDK-8009213/webrev.01/ > > > On 2013-09-11 17:15, Dmitry Samersoff wrote: >> Please, review shell script changes. >> >> Problem: >> >> Som

Re: Review Request (S) 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool

2013-09-13 Thread serguei.spit...@oracle.com
Thank you, David! Serguei On 9/13/13 4:41 AM, David Holmes wrote: Looks good to me. Thanks, David On 13/09/2013 10:19 AM, serguei.spit...@oracle.com wrote: The update open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024345-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13

Re: Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

2013-09-13 Thread serguei.spit...@oracle.com
Thanks! Serguei On 9/13/13 4:40 AM, David Holmes wrote: Thanks - no further comments. David On 13/09/2013 10:21 AM, serguei.spit...@oracle.com wrote: The updated open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.2/ Thanks, Serguei On 9/12/13 1:03 P

Re: Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed

2013-09-13 Thread serguei.spit...@oracle.com
Thank you for the review! Serguei On 9/13/13 4:21 AM, David Holmes wrote: On 13/09/2013 5:21 AM, serguei.spit...@oracle.com wrote: On 9/11/13 8:54 PM, David Holmes wrote: Hi Dmitry, It seems odd that you install the new_method even if there was an exception. What if the new_method is not vali

hg: hsx/hotspot-rt/hotspot: 37 new changesets

2013-09-13 Thread zhengyu . gu
Changeset: 766fac3395d6 Author:kvn Date: 2013-08-23 11:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/766fac3395d6 8012972: Incremental Inlining should support scalar replaced object in debug info Summary: store in _first_index not absolute index but an index r

hg: jdk8/tl: 8024201: Update bugdatabase url

2013-09-13 Thread mike . duigou
Changeset: 67f64101616e Author:mduigou Date: 2013-09-13 12:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/67f64101616e 8024201: Update bugdatabase url Reviewed-by: wetmore ! make/scripts/webrev.ksh

hg: jdk8/tl/jdk: 3 new changesets

2013-09-13 Thread mike . duigou
Changeset: c65848f2b6a1 Author:mduigou Date: 2013-09-13 11:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c65848f2b6a1 8021591: Additional explicit null checks Reviewed-by: psandoz, alanb ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Hashtab

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-09-13 Thread markus . gronlund
Changeset: 623d923529df Author:mgronlun Date: 2013-09-13 17:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/623d923529df 8021353: Event based tracing is missing thread exit Reviewed-by: allwin, acorn, dcubed, dholmes, egahlin ! src/share/vm/runtime/thread.cpp !

hg: jdk8/tl/jdk: 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null

2013-09-13 Thread lance . andersen
Changeset: 5c7690923663 Author:lancea Date: 2013-09-13 19:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7690923663 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.jav

hg: jdk8/tl/jdk: 8024825: Some fixes are missing from java.util.stream spec update

2013-09-13 Thread henry . jen
Changeset: a7980b099af1 Author:henryjen Date: 2013-09-06 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7980b099af1 8024825: Some fixes are missing from java.util.stream spec update Reviewed-by: mduigou ! src/share/classes/java/util/stream/ReferencePipeline.java ! src

hg: hsx/hotspot-rt/hotspot: 4 new changesets

2013-09-13 Thread serguei . spitsyn
Changeset: ff8a09595db3 Author:sspitsyn Date: 2013-09-13 12:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ff8a09595db3 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed Summary: Handle pending exceptions